From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09F563644CA for ; Mon, 10 Aug 2026 07:48:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348141; cv=none; b=j3OoJhDdELmq4RSDFBWztXY52RNU/IzGBBdZJV1d/loyPjIWo9yRr6ZUHa2BfqCpNIKAETKeQkiqr4REMGf4VW/L2oHZ+ld7h4Fe9YJKnfHKIFX3zI0t9AheyVe3Bz+HBT/EqGpb1xg2SnkFbaU2EcyXmllvegLWbF2AWnGzdwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348141; c=relaxed/simple; bh=MjciWwe2Kaj2lkfhHj13gEMLunzOevuCdW7Fm3VwHkg=; h=Date:Mime-Version:Message-ID:Subject:From:To:Cc:Content-Type; b=DiJB7Birn6K1LbFCSEbXCCseIUWI8BDu8rsBRs+w3udvblVUFCIUcY/byDO8jEASNY1QbYeDR29duBKNik94HFZq18elNID3txmaouie5iq4A3D2qlqU3XHtDa7eRpx5Y9An1Qjhk4tEXLpBY138w1MF4x+lJ96ujJnwdArvoiQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=HLyHm3Sc; arc=none smtp.client-ip=209.85.128.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--mclapinski.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="HLyHm3Sc" Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4955ce558d8so15755855e9.3 for ; Mon, 10 Aug 2026 00:48:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786348138; x=1786952938; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:mime-version:date:from :to:cc:subject:date:message-id:reply-to:content-type; bh=yCJ8f1+7ccBVc7u0OjmORxvYHLZYt4VhM2jRSR10I2U=; b=HLyHm3Scgp8amwgwVAlayH1sNYIycTdXiQfXJ5x+NQJl7fNbrV5fVVYkxtm6ZAZqUr lK6ReQaVCQdbiNrpUrZTUCQERHLAJhiDiC4B2BXr+LSy3B5hMaLtPjeRTxyrKUOrlPXZ p/1X2vmmt5fs5BMtmvWvwWTV4glOZYZr0evnNeEMkORr54zxi4mmnRMYpInonNaRUkPH CMgHpOAtE9ElTOzKJHMVeCGM+nUUvveQ2KwCozFj35N6xhvgzNXg+TKIdOXnFdtET+i8 DApDbFqt/TJiAq8hE8Hu3eN24tpuujYEG2tEzZ35XdyhU2tYbxoHJYrQuYARxTkG9c8l 99aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786348138; x=1786952938; h=content-type:cc:to:from:subject:message-id:mime-version:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yCJ8f1+7ccBVc7u0OjmORxvYHLZYt4VhM2jRSR10I2U=; b=RzYybjwqu7w9eUlo0jiyKBtey4pEoRVMu3j5wf+c9FmwiI+Krefta1UE6hNt8X1kCV O6wNnccUQiDQJt3wIg1WOJmbanjwb620v6/RIQcE0irfMcvIBGWBdHm2le+wbYYKx7OJ S1m6ie0cRO67Q7WumyRzjFMZjMIqmDn1osFmsVwyQrCjDbLIpBMHfQlvq6r75kkU0NGP yh7z2UKuofY6M9lkA3zXPR/83HSYD5g0gBdX5WzODnd6JNV8kk2Sdix3PTYtMDe2GpIB z9Qvl7FXZx9STrOP1f7uEd45DuSeh0Tb+izVrP9UXcW/x9slsEvRxZQMFINy5dp8No6+ D/4g== X-Gm-Message-State: AOJu0YyaxbE9bABaa3JFtIEB07jNe3fpfwQCatrSGMELAtZX/+tlgqpB ZIVqRz/bjujtA3KgKl8ciEK3M4oWqSbY+qVs9KGsiljTxZyfT6fNCrIt+TevRu6KhuVD9KO/z+G 0Rg8AdLnVO2FjqhOVh1u3XQ== X-Received: from wmoo1.prod.google.com ([2002:a05:600d:101:b0:495:6d55:63ba]) (user=mclapinski job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:1391:b0:499:4dca:aa4 with SMTP id 5b1f17b1804b1-4996194deb6mr193286395e9.4.1786348137862; Mon, 10 Aug 2026 00:48:57 -0700 (PDT) Date: Mon, 10 Aug 2026 09:48:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 X-Mailer: git-send-email 2.55.0.654.g21b8a5bc05-goog Message-ID: <20260810074851.306979-1-mclapinski@google.com> Subject: [PATCH v3] ipmi:si: Add async init to ipmi_si From: Michal Clapinski To: Corey Minyard , openipmi-developer@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org, Michal Clapinski Content-Type: text/plain; charset="UTF-8" Added a new config option to allow offloading individual calls to try_smi_init() using workqueue. Saves 100ms on my system. Signed-off-by: Michal Clapinski --- v3: - removed __init from the async function - reimplemented the whole thing with a workqueue - added cancel_work_sync to cleanup_one_si, which means cleanup_one_si now has to run without the smi_infos_lock v2: - instead of offloading the whole init function, offload just the individual calls to try_smi_init() --- drivers/char/ipmi/Kconfig | 9 ++++ drivers/char/ipmi/ipmi_si_intf.c | 79 +++++++++++++++++++++++++------- 2 files changed, 72 insertions(+), 16 deletions(-) diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index 669f76000197..538a7d3c65bf 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -67,6 +67,15 @@ config IPMI_SI Currently, only KCS and SMIC are supported. If you are using IPMI, you should probably say "y" here. +config IPMI_SI_ASYNC_INIT + bool 'Asynchronous initialization of IPMI System Interface' + depends on IPMI_SI + default n + help + Offloads individual SMI inits. It speeds up the boot time. + It also introduces a very small risk that something else might fail + if it depends on synchronous IPMI init. + config IPMI_SSIF tristate 'IPMI SMBus handler (SSIF)' depends on I2C diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 9a9d12be9bf7..79c510a8d00a 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -39,6 +39,7 @@ #include #include #include +#include #include "ipmi_si.h" #include "ipmi_si_sm.h" #include @@ -252,6 +253,8 @@ struct smi_info { struct task_struct *thread; + struct work_struct init_work; + struct list_head link; }; @@ -272,6 +275,7 @@ static bool unload_when_empty = true; static int try_smi_init(struct smi_info *smi); static void cleanup_one_si(struct smi_info *smi_info); static void cleanup_ipmi_si(void); +static void smi_init_work_fn(struct work_struct *work); #ifdef DEBUG_TIMING void debug_timestamp(struct smi_info *smi_info, char *msg) @@ -1970,6 +1974,7 @@ int ipmi_si_add_smi(struct si_sm_io *io) if (!new_smi) return -ENOMEM; spin_lock_init(&new_smi->si_lock); + INIT_WORK(&new_smi->init_work, smi_init_work_fn); new_smi->io = *io; @@ -1982,7 +1987,12 @@ int ipmi_si_add_smi(struct si_sm_io *io) dev_info(dup->io.dev, "Removing SMBIOS-specified %s state machine in favor of ACPI\n", si_to_str[new_smi->io.si_info->type]); + list_del(&dup->link); + mutex_unlock(&smi_infos_lock); + cleanup_one_si(dup); + + mutex_lock(&smi_infos_lock); } else { dev_info(new_smi->io.dev, "%s-specified %s state machine: duplicate\n", @@ -2000,8 +2010,12 @@ int ipmi_si_add_smi(struct si_sm_io *io) list_add_tail(&new_smi->link, &smi_infos); - if (initialized) - rv = try_smi_init(new_smi); + if (initialized) { + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + queue_work(system_unbound_wq, &new_smi->init_work); + else + rv = try_smi_init(new_smi); + } out_err: mutex_unlock(&smi_infos_lock); return rv; @@ -2174,6 +2188,15 @@ static bool __init ipmi_smi_info_same(struct smi_info *e1, struct smi_info *e2) e1->io.addr_data == e2->io.addr_data); } +static void smi_init_work_fn(struct work_struct *work) +{ + struct smi_info *smi = container_of(work, struct smi_info, init_work); + + mutex_lock(&smi_infos_lock); + try_smi_init(smi); + mutex_unlock(&smi_infos_lock); +} + static int __init init_ipmi_si(void) { struct smi_info *e, *e2; @@ -2219,8 +2242,12 @@ static int __init init_ipmi_si(void) break; } } - if (!dup) - try_smi_init(e); + if (!dup) { + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + queue_work(system_unbound_wq, &e->init_work); + else + try_smi_init(e); + } } /* @@ -2253,8 +2280,12 @@ static int __init init_ipmi_si(void) break; } } - if (!dup) - try_smi_init(e); + if (!dup) { + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + queue_work(system_unbound_wq, &e->init_work); + else + try_smi_init(e); + } } initialized = true; @@ -2344,31 +2375,36 @@ static void shutdown_smi(void *send_info) } /* - * Must be called with smi_infos_lock held, to serialize the - * smi_info->intf check. + * Must be called with smi_info unlinked from smi_infos and smi_infos_lock released. */ static void cleanup_one_si(struct smi_info *smi_info) { if (!smi_info) return; - list_del(&smi_info->link); + if (IS_ENABLED(CONFIG_IPMI_SI_ASYNC_INIT)) + cancel_work_sync(&smi_info->init_work); + ipmi_unregister_smi(smi_info->intf); kfree(smi_info); } void ipmi_si_remove_by_dev(struct device *dev) { - struct smi_info *e; + struct smi_info *e = NULL, *tmp; mutex_lock(&smi_infos_lock); - list_for_each_entry(e, &smi_infos, link) { - if (e->io.dev == dev) { - cleanup_one_si(e); + list_for_each_entry(tmp, &smi_infos, link) { + if (tmp->io.dev == dev) { + e = tmp; + list_del(&e->link); break; } } mutex_unlock(&smi_infos_lock); + + if (e) + cleanup_one_si(e); } struct device *ipmi_si_remove_by_data(int addr_space, enum si_type si_type, @@ -2377,6 +2413,7 @@ struct device *ipmi_si_remove_by_data(int addr_space, enum si_type si_type, /* remove */ struct smi_info *e, *tmp_e; struct device *dev = NULL; + LIST_HEAD(to_clean); mutex_lock(&smi_infos_lock); list_for_each_entry_safe(e, tmp_e, &smi_infos, link) { @@ -2386,17 +2423,23 @@ struct device *ipmi_si_remove_by_data(int addr_space, enum si_type si_type, continue; if (e->io.addr_data == addr) { dev = get_device(e->io.dev); - cleanup_one_si(e); + list_move_tail(&e->link, &to_clean); } } mutex_unlock(&smi_infos_lock); + list_for_each_entry_safe(e, tmp_e, &to_clean, link) { + list_del(&e->link); + cleanup_one_si(e); + } + return dev; } static void cleanup_ipmi_si(void) { struct smi_info *e, *tmp_e; + LIST_HEAD(to_clean); if (!initialized) return; @@ -2410,10 +2453,14 @@ static void cleanup_ipmi_si(void) ipmi_si_platform_shutdown(); mutex_lock(&smi_infos_lock); - list_for_each_entry_safe(e, tmp_e, &smi_infos, link) - cleanup_one_si(e); + list_splice_init(&smi_infos, &to_clean); mutex_unlock(&smi_infos_lock); + list_for_each_entry_safe(e, tmp_e, &to_clean, link) { + list_del(&e->link); + cleanup_one_si(e); + } + ipmi_si_hardcode_exit(); ipmi_si_hotmod_exit(); } -- 2.55.0.654.g21b8a5bc05-goog