From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9546388E55 for ; Mon, 10 Aug 2026 07:59:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348783; cv=none; b=RbgueoliRcpmabpFlyoNheR6SjWatWs6t+gBMbgFMzrXNKvIonMDjPcenNddXtTvdueT+Haf+rxFM8888SDY9hPMLKBWuvRnSQx5cwlAbPz13shiB5K12qMPn2M/R1/QQmApbCNZ/1GPLDPY5s6uDjOTs6m0Qw9yC44IdydwGl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786348783; c=relaxed/simple; bh=uD86DJvZDw9bMSCmDq4xvZrO3VykDVvurzO2DO21mXw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=j6ILgV+29VBgVzyz4DhrGYCb7XVMsxKAJkoIVMq0qShaz8CMd2IQVNAptYEm+c67tJV5plC0KLxtvc8TIpFjtc4MDqE0KciikJWqijFTef/zgWZHVahHYSqPYk8SQ3pRks2H1Ii3UCMneNZHnV7UrTYKSLut99E2SVjLI2qkgzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=p0vS/wwk; arc=none smtp.client-ip=209.85.216.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p0vS/wwk" Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-3811f512167so2256010a91.3 for ; Mon, 10 Aug 2026 00:59:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786348781; x=1786953581; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+pcbraSXWcqC+YnM+SOOMfRMFDFBi4/Lpd8ztFJEEpg=; b=p0vS/wwkviV+UWNckOacVxiTbJT0aB4Q/jTSS6OauKQPh7ny1KbkcLahXwhn5NyD2E 4AP5tqS1Gab699aS1CZijdVip0RsadpHXMN/UDYxTq9p0MY+wcPRHDQfoJL3PEJIf85c oAwiCwCyfNY28pNYi+e0YrOJttrJoWlWTOcSBn/pM3+k0B8FD0bJJkyrGyQIUwmS5xGI dyntXgHKfvc/MdQuzE1xyzAkiAGeS5gV7xTpsjNRyhk/Uex42jc9FhnBFh0p8JgLwhyD 1mGnYW1GhvDLOJOucm/TbxUw9oIwlgWB2Gd3n2awl/MkmeC7QzQo4XqxAd6u1a1Fje0I XWjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786348781; x=1786953581; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+pcbraSXWcqC+YnM+SOOMfRMFDFBi4/Lpd8ztFJEEpg=; b=GJpy2CPkW+MbrlSqrMPLYMU7hFFMpMJ4f6Tk1WHQv2vvy8li9+V98iXfiGNNp150qy VPQpMER4Xn7ai+SDabyeqfEA9LVQAu7azcO08ARndJJEhVqefDDRxxkMQxkWL1NWOCo4 qF8BG8gRfUXo6qDgJs9F4DKtqRQHeO6S66cfv111vAeo+mjxuROVSiJlUXw+RCO+g3qs BWQXunKhltje8Y5eEQvRG80BSwfuZuh6RNOh9QT1mVkvU9+TAghB/r44izEuq4KLsQTY 3LRvVjV2O1Ph4lJ8nzH1WwDtkg3w1/YNTlVc+R0jdPWFzBKMb3v/BpUkBEBiZHUTaowC PYlg== X-Forwarded-Encrypted: i=1; AHgh+Rpmmem1n9ezNtiJX93arWWFmz/uiMWHLy/PgEGe+oEFm9Ui+E4RlNb6xE7FRnGgSaCr7OnRwBYJ3hTUEo0=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5PNr6fwatGnpz+Z9MlD1oJa3hW1Ep6xungT1MgU1VpmhR7QU8 DVt8vE1+c6guctL4ENTK5OhbwFuCxFcHQWbvCabmmXDwtpAe+BbNL39agqDy8g== X-Gm-Gg: AR+sD11X7vukTgAmPoq3gTa9URZD/C5qyMsry74klo2Gy5zpdJ0Arv8fJPw7fR7kpyD KHeYqerayf65utFALs17/CAmV3m2XCi6aGmKnS8si9ov0WmBsgUZ2tQNKeqftpWyOvoZ3Pp6NMt n4eqxIbg67U6QN6itXfQKAMwdtQjtKJ10VtcVP9WHiRDvGrChyEkDn6lJObblThbwRv61sozU1G 5V3tkuzGxAajoEhH0YpSsBn3TfIq3/juGOaja4vBoqQTu7ofnSy/OgpCQSu/zHr2AwI3/AH1n7D 6+qUu3lCgF1BipIK+kMn39CwaousHBM1rmaF2gTssK/E+0QJnUT70aQcHIa68y2uMs0ebKM3ISq 4pX8c1itbMfffMM4hrKhpv95o2U0HLrzbp3tNIqyyWrjieGkYFTnjmp3eV41HmpOZ4/dCJUdpt/ WwWxgbb9wktTlpNa7fuu73mWk10+Yv0juJxBFGquGYzcCGzPKj326XCQPc9D2QpWIF1t/otrAn7 gwyTSMbKB0vssE= X-Received: by 2002:a17:90b:1e53:b0:38e:6d4c:14e6 with SMTP id 98e67ed59e1d1-3903c5501efmr37893588a91.3.1786348781098; Mon, 10 Aug 2026 00:59:41 -0700 (PDT) Received: from online.mioffice.cn ([43.224.245.228]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3925fc6f13dsm11391590a91.1.2026.08.10.00.59.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 00:59:40 -0700 (PDT) From: Pengfei Zhang To: Eric Dumazet Cc: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zhangpengfei16@xiaomi.com Subject: Re: [PATCH net-next] net: ethernet: drop skbs with a short linear part in eth_type_trans() Date: Mon, 10 Aug 2026 15:59:35 +0800 Message-ID: <20260810075935.2961699-1-zhangfeionline@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: References: <20260807102802.1696827-1-zhangfeionline@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, Aug 7, 2026 at 6:52 PM Eric Dumazet wrote: > This is obviously a wrong patch. Please fix faulty drivers instead of > adding more code in our fast path. > > If you use header split, you are supposed to use modern NAPI api, like > napi_gro_frags() which will take care of that. Thanks for the review. I put the test in eth_type_trans() because I thought the stack should not be brought down by a driver handing it a malformed skb. I take your point about the cost on the fast path, and that napi_gro_frags() already takes care of this. I will drop the patch. I do not have amd-xgbe or dwc-xlgmac hardware, so I will not send an untested driver change; if I can get access to a device that behaves this way, I will fix and verify the driver there. Thanks, Pengfei