From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDB23CB540 for ; Mon, 10 Aug 2026 12:04:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363490; cv=none; b=lTTt2qpBIIkcJyc+w3nBr6vfiELQ8f2cbnP5sQchiIZzQf7fkSmbtXPA9Eh4KQBUQ5QtMD1S0xkdan63x3sDPjCTgfQzjLTih33XSYYBF+GVSCX8Rid5ESks7FLh/qaJrYFiiu1j2yVwJtkpJEb4IWb5W36DpvIWMpR0p5esDcg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786363490; c=relaxed/simple; bh=NItqIlw0yNt23XrGvLNDmKYzYKHHYzR8arjRUlDDCdQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FZSbUxatZDPijpHceakhR5C4aTQLgxhUXzR7xhssFCEEZb62VjgaRZpdA8P/ArAOwiayNGGTy0RjUNopOyuTw4oKPHaU6lrGSfF348pC83Af/mlilEbiVSSejOAvE5ws/tjKTcEnm6ALw0HUZY+fgDl6WUOXkJP3x3w3Mkj1WRc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fZGCaa6p; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fZGCaa6p" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4954a2dba6cso1202155e9.1 for ; Mon, 10 Aug 2026 05:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786363487; x=1786968287; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=cpjxRd/pvTlykMQ7Gki81PooNujxpnSGhHOAxHlwH7w=; b=fZGCaa6p5QKM3bd2qxmu9RBY1UrtnCeRD21M3f+5M9I3S0rI6oSwEMBhvLkS2FOdI5 AjUz4DIXG+hAmPISl42RGPa/HSh+NOJk6Z1Hqszop+k0FJwow6hCuWBXvMZT35eDnh/b ugfTsqyHAA1MkGInNk92CUrxpEtDb4tICuk8BYIsizd/hR13BodomXWm2jq9xpAPDCcJ sMBQa5/2gTAY6DFgRpvxpTvs8PSBPBCbLHRER2u9mjm0zXNYa9ad+RXwdCCVyo7VIHAe e1BN8W5Cvq4Xh1i5NSEcgdTbnjoQI1B9T+GUR2oY4+CHNBwKB6rB8oimlfTHcm9BArcf +1kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786363487; x=1786968287; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cpjxRd/pvTlykMQ7Gki81PooNujxpnSGhHOAxHlwH7w=; b=MQO50n3XDsgLZ4p47is6zG+GWn+0wGARE8kRPFClPqtuF42hTmiazI1+PfG3R/QGQC afF/NngQuxzLjA1IOYBVvXDYrnhjzc/FqZ/Q1QzqlKYfcxq3JwhGNINJ5VJ4RMZAktaa 5y0G905ikFojKAyw/sGhbXR9i2/Xaa+ntC2gLlHSG7zaFsdwTrFnJhrxrDQ3EwsptAiN NpNead8A8CA6rFzLg4uDr9SbtvMcneFkjAzO2dcG/SEt4Kh69PvZrAIGZkNQzU9fcKBj 5GvGqeut8B04cuxpW2jGJ5a47nfibEwlc1Evd2TE1WVg7TD2frhOEt+bO323AWgfQGhD bfSA== X-Forwarded-Encrypted: i=1; AHgh+RooftDkPtNOIN5wuNSFk1nAet0V3UF9UWGZScovufC0EbDvR9K39OgPyaSq7VN2QGtPL4i2HSs37KX2v8k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1UqLE08P08cs34Yzk/x8EbMQtgPR91FacwZtdPwMFdeAoB+nT Cx33N7MdPgrtmFPzsNSwddnTBuj+5YWPvv4P11SK0xsWJACIKumUV+3M X-Gm-Gg: AR+sD11ZJtfdJeq0H/f8WnN26Toa4CUENffUXPoceevuJ8SaCAHuRElZuJ4sqOszEDH pDkdyKr9XrDPHDyuvMZ8PUVeV3LThhXxM+UVyF01ARnKn3IfhJLZzVueNXeeRPPo0MqEDxkm2D9 PR96b/hamKya3hZsZhr5i668dXlSuKxt7HsA57j1brd03OzozmdjVsmcdLTIA94vmel9CbdX9M2 praTD5JSoPLFZBSinWUZaCS/kBXbFAV1CyZ9AWu70UYNvyIf/sRAamkiUoyxJ74VqZTK0Gv7HPq 0tzW5vNoVtPhMoSnzgb+n4x1tZZ4ERk9hYaTbUXrNYVuFG57O44NAnIycWCKG7YK5yatxm1Y2w8 sFkKfH2GB2mR5xRljbdThyP9ekZFZMdDcMn2J/O1oqtYyh39NIiKDfGz9OCyP2dAlkKJBXOV4Yn 4Eckw7JavHstN8hdU6sIaz9rCb+r/JfxidgbGhHVtYJ/89xVNYPzb6y7tpYQw= X-Received: by 2002:a05:6000:220d:b0:47e:96f2:52a8 with SMTP id ffacd0b85a97d-47fec4e31b9mr30062866f8f.1.1786363486475; Mon, 10 Aug 2026 05:04:46 -0700 (PDT) Received: from skbuf ([86.127.220.200]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021f8f33sm39932368f8f.27.2026.08.10.05.04.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 05:04:45 -0700 (PDT) Date: Mon, 10 Aug 2026 15:04:42 +0300 From: Vladimir Oltean To: Jonas Gorski Cc: Semih Baskan , florian.fainelli@broadcom.com, andrew@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, vladimir.oltean@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: b53: be VLAN unaware when not filtering Message-ID: <20260810120442.255nahzmurjhi5jn@skbuf> References: <20260805072641.402-1-strst.gs@gmail.com> <20260806102327.wrig23oltjzogyi7@skbuf> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Aug 06, 2026 at 01:09:03PM +0200, Jonas Gorski wrote: > > static int b53_arl_rw_op(struct b53_device *dev, unsigned int op) > > { > > u8 reg; > > > > if (op > ARLTBL_RW) > > return -EINVAL; > > > > b53_read8(dev, B53_ARLIO_PAGE, B53_ARLTBL_RW_CTRL, ®); > > reg |= ARLTBL_START_DONE; > > if (op) > > reg |= ARLTBL_RW; > > else > > reg &= ~ARLTBL_RW; > > if (dev->vlan_enabled) > > reg &= ~ARLTBL_IVL_SVL_SELECT; > > else > > reg |= ARLTBL_IVL_SVL_SELECT; > > This ARLTBL_IVL_SVL_SELECT bit is only implemented for a small subset > of switches (bcm5302x / bcm58* and bcm53134). Additionally, according > to the register description, this also requires enabling "per port > IVL/SVL" mode, which is not enable by b53. The description of that > also says that the VIDs used in SVL ports must not be used in IVL > ports. No idea what the consequences are if they do. What does enabling per port IVL/SVL mode do?