From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6A4E429038 for ; Mon, 10 Aug 2026 16:34:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786379696; cv=none; b=FPrlKnSi8T/Kk+f+5HtOV0gM43wPZk+pFbZ27XLMCofJrYKpBnO5uSe6RZfqEZkv+UlXjZ1cg2O5fpG56PLn3LaiSyAt7GD/hKED9Da9aMthGldvOBDhd3zPwVFByiX/NDqMSnzJB0AWAYrXjIlK5MDAt1F7DvSs7wqAzbEH9cE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786379696; c=relaxed/simple; bh=GC+CJo5FlA/SE2/QVcHL36Xcw5XC5Gyu8Y+sDTlvf54=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=XEhIEpZD46U6/0bTr03zRXExlU1IVksPpp++hpIkF/Y4Kkc/2oSHY33sge32n9ph2747HHPHU6xUtQdO9eUndw6b/OClhQf7x/dKvCIHz1+9hXUAJ8GQqoJAhM6VXe7CuWZr712U4tFHLvqeZ+iht1sp74PYZOyt46jyBRjg87Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dXnoSpk1; arc=none smtp.client-ip=209.85.208.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tarunsahu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dXnoSpk1" Received: by mail-ed1-f72.google.com with SMTP id 4fb4d7f45d1cf-69eae8773d6so2389818a12.2 for ; Mon, 10 Aug 2026 09:34:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1786379693; x=1786984493; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=2W9GjrX12XMdTPANAxHOJwxcvmu8lBZVUg7itISKfu8=; b=dXnoSpk1GvFIs/7MzjDDLVPtl0XkokwJi5OyqSbbOIEzmz75l5HDPlLNFvu1KPTfDf jyaFdRmH4POvkAhbdMOy9KFU6osfFDdpuMtlTvHuW4XOW+QM5NeY2dWjrg6e/0xRPa8w 0t8Cy5NlPkgDaiDifX/nnv0ya8U3O8oi+6Ijb4RWPzoSwdbrLvO9bhpCzqr/7+VFqsK3 hfuroVjBwa8zVx7+TV7RYSbLkgqtOSuc72XT6tuTmdkojby1US14V3/iDrBdZ/3CYvu5 XdEjwKXsTpO3+vNyDL6erJRfRkHams8KFk6+ay3c4Mhlh8ulqaMA6EvUz8axjArtkQGc ya+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786379693; x=1786984493; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2W9GjrX12XMdTPANAxHOJwxcvmu8lBZVUg7itISKfu8=; b=d0vnJWc+xTwA2gaB//bQ/cSIvXqNmJfJw89XI5PFU7h4Ool+ZesQbiOJz7WQ8aYzXk 2N1dSJXnG3W9MmSuFyP++TDBNTh5i7VkrSCPsrN6x5J/kp6M+JCLBoWiW+hJABMYkL5y 4Vfb4xup71JlB1gyofuHI38yb9VwK93kH9HntBR2CF4XIXZQGoA1CEJt3brDwnJXMeFF +3Vix3gGPPh3ZDoSOLIGeI08g8IU+fS5/esWLsBdgec4mOGDoW8HS0tj2wIC6KHm4LlK s1LRM73fATA+lB3nwn8lBgwFGMILhYKGHkBBznWULXx4II8KzJ0VIMaIZ4HWfARvBN0L tOww== X-Forwarded-Encrypted: i=1; AHgh+Rr//uKOhEG8YUW6M7uSq0+wSA3uqc5aZAtgRcYKFXuexZyqA24EFhA+SM9SR6jIqOvwz31PptX/bwICbCo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz2APcV3fs5WAJrSb8lEjThM8utS5Yvw/FPqtuKaxD5yOXlLzkl HlaMUSZYMuit7qHyoit8km1DoELu4/uZ2nP1kP0SuwXFjXFcSHUldeNg4eAxxIsu2qLSTHCP+fA UTz47KMSI+JYU4IlewA== X-Received: from edbay18.prod.google.com ([2002:a05:6402:2032:b0:6a0:a508:c896]) (user=tarunsahu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6402:454b:b0:6a1:c908:1701 with SMTP id 4fb4d7f45d1cf-6a355e2d32amr1548538a12.13.1786379692937; Mon, 10 Aug 2026 09:34:52 -0700 (PDT) Date: Mon, 10 Aug 2026 16:28:12 +0000 In-Reply-To: <20260810162814.1398016-1-tarunsahu@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260810162814.1398016-1-tarunsahu@google.com> X-Mailer: git-send-email 2.55.0.679.g6767b8d81c-goog Message-ID: <20260810162814.1398016-3-tarunsahu@google.com> Subject: [PATCH 2/4] firmware/edd: use kobject_put() on edd_device_register() failure From: Tarun Sahu To: Greg Kroah-Hartman , Geoff Levand , "Christophe Leroy (CS GROUP)" , Nicholas Piggin , Michael Ellerman , dmatlack@google.com, Borislav Petkov , Madhavan Srinivasan , Shubhrajyoti Datta , djeffery@redhat.com, Tony Luck , skhawaja@google.com, Russell King , stuart.w.hayes@gmail.com Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, linux-edac@vger.kernel.org, Tarun Sahu Content-Type: text/plain; charset="UTF-8" When edd_device_register() fails after initializing the kobject with kobject_init_and_add(), calling kfree(edev) directly bypasses the kobject release callback (edd_release) and leaks the allocated kobject resources. Fix this by replacing direct kfree(edev) with kobject_put(&edev->kobj) on registration failure. Signed-off-by: Tarun Sahu --- drivers/firmware/edd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c index f980c5b56858..763e7b16d517 100644 --- a/drivers/firmware/edd.c +++ b/drivers/firmware/edd.c @@ -748,7 +748,7 @@ edd_init(void) rc = edd_device_register(edev, i); if (rc) { - kfree(edev); + kobject_put(&edev->kobj); goto out; } edd_devices[i] = edev; -- 2.55.0.679.g6767b8d81c-goog