From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BA73442119 for ; Mon, 10 Aug 2026 19:40:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390810; cv=none; b=PCrVIDHeUMT6MPWeZw7SfQoMTxvAWmiO/SEPZo5zukDPgVLHazpUXEdHROvdU/e7cEgk3JFqUR06/G0hDiCh3JDjpMQpS3xSfpQtUgvSUugUk7fWyhxIeJBoEeuP5h7/DzFSFR4HFjq4TfgqGvywzE3TwX8Yzew3Oan2XQB+d04= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786390810; c=relaxed/simple; bh=iymtdZbAVDC4szK+VL2vsDv4Um3gp/9GnkovC0TOf7E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GV5X0K7hdPtAlly+Z/0wRVX5sPKCO55AsZn88Wo2LG6lCmAfWfCQYxTk4mS9qouwVMbF6LMAO0ueOLShPInbKJlb2jFvxeE83N3IGl64o0Mg6e3JrlpUKtfvN3MEORg2Inih+7IDHrS3qYDRaHmu88K5KNSEkZac3eRDkTXf8o4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FEM3ErQZ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FEM3ErQZ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4954a9e8490so1323045e9.1 for ; Mon, 10 Aug 2026 12:40:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786390805; x=1786995605; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=FEM3ErQZv/iFI2wk3UMNOzwUqmp69J7Ox/rfTj46W83fpT8fRiJSr5CPXXVhOSWLWK DuF/CS3bm/ADH0rajbZcuexCYPDTwCWNo2iPU1FBav7fvUEtaZ1cwVC2LiTDeLdPnMFo Ar2k2r+WoH0W9nXjUBbscIenAzy7AmEwAxCTxBRgfI/G8OzIZQPYBydsLQz6M92RQEq5 6ezcSYVsv0W1dk9GNBZgUK1za6DlT0gdZSmBn7L5rdP97u38q58KIDUvGLWTmylf/QGK WrXxHmIniK48Cmk90p+7A9uTP6MZdtJCwr3ZNYk0IBuq458QHBUM0JojxKEo7pj/2kOP gN/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786390805; x=1786995605; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=XXwcKnRVFOpp4nwM0OPv37Mi9/4jLIaK1M0V9FiJQZsokW765w/6iFPWxBJizi4GMC g9+nAzd6e3NrWt7NPtiKw6IpK6PMQckcguIt1Efibryb8o+KyvWMi2BkjDgZsq2Btbn9 b98x/ZurbiTKE0/iy41a80hHn8e6JytBTKUgTUmb5JDDk7RTtc9xdiGv6hlpOyToy1WI 8D47sm/xiJ8I5ZeJqqaKn5H7VoqQk8PQXlPQcnHHMfky2pGBr875dT056U85YecN1Art rdcGdKXg/aq03vRa/0Sdpju46hle0rPo+91vJe9Jz1yHa6MSjRol0u0sPrE4ZXTmY7So R/4Q== X-Forwarded-Encrypted: i=1; AHgh+RqKmJ8w4lJvXF3ZlnlAakQMY7vYECCpcz09hUKW8sn8d4sQp5Z5DKJxx8r8QItyO3AcRnso3yImhZUsB2U=@vger.kernel.org X-Gm-Message-State: AOJu0YyVEI8xfL6vpfuM1pKx3NyCC3g/9YPQAi/OZvXqrReUY68j7BHg 2tA6C9wOFvPzD51oUBs28x9b24N2kyzLRc3OoNWepYvnPf8QWWv0W7Ch X-Gm-Gg: AR+sD13o8duey2DguAnsfNCeWZ51ZdxsScXciqi+0lyo5i07CMG5Ly90UUQrlhaLLEP zruWUrwHhmDVz1eFZ9r2dI57CcGkru0iMlEsvwjKlE8xBBYsdTS8PH/K6QO3i5L7WB+Elo19nCQ Z18yQu4hX2Loq6GVrYJGgSnid0tz/Gn+HT7bScpaRw+bVlaQc+rcnyOwtByzp11AmWz4St49xgQ ICm7qqmlJTam2Ca/dDrD1CVNGZSzLiGahiBOmIph72YhGR1Qf8CvIfgOL6AOJjdgNSOimSfnz7C u+8gmQNy5u1HFN8djJS5O83OAXhymXEbWwGN6INdaftTieavzFwkApn/ExRjET2qwrs/aCc83Li uI0tgJFe2Z6VmIt1tHERdzZwreKvvV4BopJITCzd/JEEJpBQL8FAgc825egvvwDid9ie0BgvIR4 +2yZzwRbe+7ErmoduhW9n20Z6ALdbv83u0WuC4PhA1UCTGF8SlQ7PW/4UhpDo3alogr5LJP88PV EU= X-Received: by 2002:a05:600c:8287:b0:499:5f81:8ca1 with SMTP id 5b1f17b1804b1-49974667332mr8638055e9.6.1786390804533; Mon, 10 Aug 2026 12:40:04 -0700 (PDT) Received: from antoniarch ([78.213.94.207]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-480021506cbsm39291689f8f.14.2026.08.10.12.40.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 12:40:04 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v4 2/9] rtc: abx80x: fix error check after i2c_smbus_read in read_alarm() Date: Mon, 10 Aug 2026 21:38:19 +0200 Message-ID: <20260810193826.210683-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810193826.210683-1-apokusinski01@gmail.com> References: <20260810193826.210683-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit i2c_smbus_read_i2c_block_data() returns the number of bytes read on success and a negative error code on failure. The existing code treated any non-zero return value as an error. Fix the error handling by checking only for negative return values. Fixes: 718a820a303c ("rtc: abx80x: add alarm support") Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 5486d9d0b1e5..fdf9664ebb6f 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -294,7 +294,7 @@ static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) err = i2c_smbus_read_i2c_block_data(client, ABX8XX_REG_ASC, sizeof(buf), buf); - if (err) + if (err < 0) return err; irq_mask = i2c_smbus_read_byte_data(client, ABX8XX_REG_IRQ); -- 2.55.0