From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f170.google.com (mail-vk1-f170.google.com [209.85.221.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 137A63B71A6 for ; Mon, 10 Aug 2026 23:06:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403180; cv=none; b=iVAx/yYEjCXidbPlNcst/Tn//K/U+PZLEpPXSuGS6M6sOlq1Z25DLYa97e6DfDWMUH2KJwYuCqIujmzUUB1vj8RT5n4e9XAuAByxItupLLAXBJu759OLUrXiJqGdc7hXmXKxQgazkqJBcJ5LdtDIoIiDfmyX+GiJbEAh03maLbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403180; c=relaxed/simple; bh=O7lAK9Itxu3BtFZebuGm+soxk8EufQFIVRqNLSr9Y0g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DYCOHTtTklA2OPJIFGtpUX2mgTAUaAgp/0gOlNUzhtNazBJc1ZhJfSnaiYj2FrLCgUFqEtXoC6LTDnarK6PYT0eUQ3w2YLk9yCcK5FZs6qcOT9TPoNrCPRPidjECKmQVxah4fAlklr3jEKOPBZJHbvf3HsAVkJygQ0o6TQw/zmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com; spf=pass smtp.mailfrom=peridio.com; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b=dcfmmgL/; arc=none smtp.client-ip=209.85.221.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peridio.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b="dcfmmgL/" Received: by mail-vk1-f170.google.com with SMTP id 71dfb90a1353d-5bfc4f26c67so87882e0c.3 for ; Mon, 10 Aug 2026 16:06:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peridio.com; s=google; t=1786403178; x=1787007978; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=sND6wzkbiGyKvdiG9Z9kRm+epdaTPvk4GyaXe9tvODk=; b=dcfmmgL/UcF4bmjkp9fEgXkxf7S9WCRAv+4lyIa6RfeGT/7FbY8X9Her51KN1GZS0o PW3c551S6yu9FfxpEzKDf2xEgM8cWHqHXK4wQhl0UGkY9ACczYyTSbAgS+FKYCinRdU6 45nfGmo9umsCx9kgDBR3f1PBs1iIJoAxU97kuQggBj75p9mnBSuQ+Jc3TSv2YYoX6yra TK3FO6pVkCwLMMC9PBQmINTmqWPyfwjpRALxx1fHbLKNLTbFiWuMBvy678ZRhPxIxjGP R+MO6fSm8jSkojijm8vo5/yWulLUGpwKVZaPX/VPwRLcCO8RyBSkR5Dm0bsjust0+gWQ 1KkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786403178; x=1787007978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=sND6wzkbiGyKvdiG9Z9kRm+epdaTPvk4GyaXe9tvODk=; b=E1j6wC0btmqRKb156Yu2fEpqOAfBfAUVdCTfektgEmDtJigcuqQtQSMwXZFfzM7XdP dyxhE3u88+A5Qhs7it4Gqsk33lUbLj309SVujG6tGrPhK6j/u7Ss0q2vijlxJH6TLAbe dG5oYV/07/5IvT9Ys9EEIsi6WTHVBVvDx4EYwqCex3SB3CIrOFEs3gxnQkodQ2Z69n97 y7BsVAaEP3q5il54DiMN0ZA/r8qONNpVocdMZ5kgsqzUfc5WSyrG6mCc+wgAq1HCh+ot yJkgcF8JG0MVShdbAo1KLqsUXXBakpKJGGUdqTmZV4L0qNFUO8nFICD3W/tEQa/cFxUf YELQ== X-Forwarded-Encrypted: i=1; AHgh+RphY0M/xcrmwuiMEk3blUlgMKrQk+9bENo9U+e/MRclIYYijU+hjOk8c1TSvLhLM6RSUHiiVH+cAuvzj4A=@vger.kernel.org X-Gm-Message-State: AOJu0YwND2yyWyy30iKPMEom2447j0Lfg9AmxfYTFng/oOoiwcwlsjlS vP5JhHa3XyIJC8z4GkrwOwYSz0j+r97gB4ehVJXZoYUzdqDNTr85quFHKdWFdl1CUJ5V1665gEk ZduWVNUs= X-Gm-Gg: AR+sD10kRw71oUw31no6q2lrhfeQuTfPVN6fH/quBKQehXMvnGTOm3ocO17OCZCUpRt ugP3vqk0cdUpZybswVk/sF53ToErbsBk3NdMT+T5q1uGOPN01fXnM5gXq2dTFwVt1OkrO+nfoPo 9+0ihp9gl4cfwU+8FBdPiC/mY1QJ/DpGh3e+XLkvyxIqnObwjXcAWMfpm21+TAypH0VtM5Ocmfn GmTlq9u+y3X2+TT3IemeB3Pq1cMUe1itsFdXGynhk/rqNIruNGoL/5hOA+TalBcwo9c7jGRrqs4 KGRcMKWS4ju9JBOFxgW8F8WWvGHCKFGHWNuXPAGw4vMNdzTVYlNo46fJ5MUqv0AiEDPJpOVORou NvXa0KRH3h+EwHg3QSvDO7YnmFwG0YZPFCsZaGj/0mPY+yHHZ4Btc1OXgP0f6zDvcTqD6P2OQjU KGcQHHHusA8RMCui5+2qeA26n1k1ADDMpMXcVSa0MiNOhJYCH+FGAbz9I8s5kqkI/ozA== X-Received: by 2002:a05:6122:6c06:b0:5bd:a3d0:923c with SMTP id 71dfb90a1353d-5c3d8d1a62dmr4758463e0c.0.1786403177877; Mon, 10 Aug 2026 16:06:17 -0700 (PDT) Received: from localhost ([190.113.101.40]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c40b1a8f75sm4737386e0c.10.2026.08.10.16.06.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 16:06:17 -0700 (PDT) Sender: Javier Tia From: Javier Tia X-Google-Original-From: Javier Tia To: Carlos Maiolino Cc: "Darrick J . Wong" , Dave Chinner , Allison Henderson , Andrey Albershteyn , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v3 1/6] xfs: initialise error in xfs_defer_finish_one() Date: Mon, 10 Aug 2026 17:06:13 -0600 Message-ID: <20260810230611.2859909-9-floss@jetm.me> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810230611.2859909-8-floss@jetm.me> References: <20260810230611.2859909-8-floss@jetm.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1468; i=floss@jetm.me; h=from:subject; bh=O7lAK9Itxu3BtFZebuGm+soxk8EufQFIVRqNLSr9Y0g=; b=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqelljdkIzN6Vm6qJyjzD8yEylWzJ49lYuL+7hF mhBN6Hvjd+JAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCanpZYwAKCRC17sMLqGd3 H0h2C/9q1FfvCHZUTjpMqZgcixlBy6ktrW3R+ilbZX6SIJkKPmGNb0tgsfoS482naCCHoSppic0 uTZLgE4fjZZ6d4ScY4ADsthGb/BtRLZddGfZfeKjyV4o0bbcPuJR1OsMI88X4Z8iwOwGT8RSXTc ku9S3RuuqFjXuHk2y6OZCTHgVyYvERsHRr3CXYwBfMs2lWqkrGy3B4R0AFi5gJjwKZDaBDsgp3i ZUacCCJ/plSySYNri0ysQvG/PoeJtipZtQ5j+u2A2bj/99QYh8bjM/4bIjzXxlQ4Wtbna6q+0x9 Gmjne4hson+QfKQfrtNy2unywyTyAl8XZJ4GfyXmj+8HBVD+rbRoS9OZvow8y6ChHSjG265UWgi AIQglW4YZECI6+gc662fccIAmFwtMphfJHb1yehOgXrl8bihT/OfDs0mwIVvJByQQbjjWu7KZUp eRw/RUaqOTMmP82N6K7Z7nLmFGtTubaI4Ak2SNm1aT1df+BWtx5PX1IWC842WD2bwdj8A= X-Developer-Key: i=floss@jetm.me; a=openpgp; fpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F Content-Transfer-Encoding: 8bit xfs_defer_finish_one() declares error without an initialiser and only assigns it inside the loop over dfp->dfp_work. When that list is empty the loop body never runs, control falls through to the "Done with the dfp, free it" path, and the function returns an indeterminate value. An item-less pending item reaches this through xfs_defer_add_barrier(), which xfs_reap_ag_blocks() uses on any CONFIG_XFS_ONLINE_REPAIR kernel. xfs_defer_finish_noroll() treats any non-EAGAIN return as fatal, so a non-zero stack value turns a successful barrier into a SHUTDOWN_CORRUPT_INCORE in the middle of a repair. Zero is the correct result: reaching the free path means the item loop drained without a non-zero error. Fixes: 3f3cec031099 ("xfs: force small EFIs for reaping btree extents") Cc: Signed-off-by: Javier Tia Reviewed-by: "Darrick J. Wong" --- fs/xfs/libxfs/xfs_defer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c index 89501e8bd2f8..843c33304441 100644 --- a/fs/xfs/libxfs/xfs_defer.c +++ b/fs/xfs/libxfs/xfs_defer.c @@ -583,7 +583,7 @@ xfs_defer_finish_one( const struct xfs_defer_op_type *ops = dfp->dfp_ops; struct xfs_btree_cur *state = NULL; struct list_head *li, *n; - int error; + int error = 0; trace_xfs_defer_pending_finish(tp->t_mountp, dfp); -- Javier Tia