From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C00A0430CF4 for ; Tue, 11 Aug 2026 13:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455416; cv=none; b=s2n+7PCJHrOn4OdP4tGnHEVJ7kW1vr5LJuvXVnovCDfBjUdM7E0M0hu5PZ3NDtDkN1FGdvOeJsm+49QPLpJr4GlwPD6qC4QOJTiJNSOMhBjHr1Wgkyplf3uk7N4yqQChrOl3Ucq9/1/yHFZMBuizBE2T/rQn35GLx716Woql5PU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786455416; c=relaxed/simple; bh=ryf8Hd4nI6jqhAT1OBjk5xfOQnB0C6q+0/GQIGWdgsQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=r60QKlbc16XiYbN+cYG/in4BgLwMR+Nxlbz7XA3U2YBCrt0anjDGR5ZJXTgfKrl2ZtmFG9lVrTiEYlPhWEQD0peuRcmYs0XCQdoQHoCbZpVDLYvsOinHRwwUmn12AWPjj33Gz30mI8g2uiJxsfYX5BD9hV6qQmDOca5ekZTTAuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=cHfArXoe; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eOw9mzBM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="cHfArXoe"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eOw9mzBM" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67BDWv9i693968 for ; Tue, 11 Aug 2026 13:36:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= PBKZTJRPc4aJNkS3BLkPLws3+8SnD6OJK/D31466cvo=; b=cHfArXoe1G1igSv4 ewt79K0VVekUNzoomiOcEQWrTaeFUqUDcu9SOViG3o0wuhGlrokUYjzOMKOlFBw9 AP6yD5fv/IiyYJ8gHqTz6xs6sHrW8cDklbvVxOnUOfHPtPGDTN5Rji5Y3MjxXCPi Ub+VcM7YtpcgM2CYs4hC1tVOMKcw5dkQ8LJeSFXh1L8cAfHR2xlWEYd2QoPe/MNh lyW1vyRQUpaF6kjyMaeOTGm/58IXboTzVhboURHfH4XOEgiCchwys1UBod/zjKiz nwdsddHtognwOB30uvsWpdNvSL7Mq7Q3VBREFC5xLSkCB98Z8pqKHvPiYBxxWXpy FPycjg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g049gr640-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 11 Aug 2026 13:36:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2ccb687f82eso48469495ad.3 for ; Tue, 11 Aug 2026 06:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1786455410; x=1787060210; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PBKZTJRPc4aJNkS3BLkPLws3+8SnD6OJK/D31466cvo=; b=eOw9mzBMx9kJNDkspxHSbExbAnwtaABs1NfVbnlfbq12BHrr+WEpvdh/551enfwu6s +6QlUWhpI2i3UHaMRRSKcSdwJ+VlkrPStTuk7KQGmxFCkBFnkTtWqARTxc/6c2uws4xL mL7hJS+jZpU8rNzbKmiq8l42yRSNEZsQ4hI33K8eqSW815TPad3Ddllr3i0UoP+l0yVt brVROD5NIuCmw3QKzFut5yVt/BzHzKm8cvBvRsgK6xRbnSXF1A4lScrudX1yVhprTC0a FqXagqQEpvIKumnoM9ghtod8Qf1J2U4pUwc8LA275aboBkhK5kVbjocyUNO8mDy9tAft r/sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786455410; x=1787060210; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PBKZTJRPc4aJNkS3BLkPLws3+8SnD6OJK/D31466cvo=; b=bLv6DGIpNJR7rx1WF/FOahWWPad8iFHPN1KkQCVcYBL7GeeH0LIR2tbwFUCa+Ob+j4 NtIlL7s0tQQmbRVap+PjGgj97nx+EJsn8XaylI6mlr4JDoggXY4j05EY5FbITSPfVCz4 TCOAH9E5RewBD11Ph+8RnKyBqip1Vty7OBt9eEZJSDsxg3HrpJABaAyIb+iUdQruZndE 8Zp5mwDAPqhPTLa8a8NQiivuK2yaoPZ8WU9l/VUBGPsvZOEBKqMO4I7JbbGTiSDKmqim zjlkl/ZWJAckK/Pi0DE9hwZFGDHzQnrJzkTRba1sqKByihcWaJkDGK+ZkZmOvgIMbbSK txhg== X-Forwarded-Encrypted: i=1; AHgh+Rol279iOWpo9mejZg49lOwSVe5w4tkBgQBRxo95OWP/K8cIyUmVvNrlKkb9PLx5yIhoS8/K8wNoQ+Oy2No=@vger.kernel.org X-Gm-Message-State: AOJu0YwIPqCrb4SI6W9nN3EjsW02C+U7mI6VJk83UjH4LAe+bBSSI1DI ADQwlDJSurtcAwoqZVgTShnHODOotI1MRitfuwoyXodwRIqxxU30093Jay4vzllMqlRuY1GFqAH WOvXERuejo5YV3r0U0ica9XzkYiNRdAelxNSAe3WSRyRT24rFqGsG68+Q46aFfqmGPME= X-Gm-Gg: AR+sD11lNmC7X1TX1cnlBQaRRNunsc1Z3K1AIEuQA80yYuEQMLvea7ZHb15ySNB3YqZ A4yp6XHyv90QcgVUalyqxcP1BrbneMMYkeTAXib1ki43f+OKRi1e0VpBwqBi8VJqemFMCdLT/x0 1xxW7KZhAWj7JY8+yjrO4Ea05TZdzmly2SdxqJxnQ1lsko4cWC18ouEupFicqV9o0Vp0I3wTp6S laffFeIRJbf7+2qF0l0Q44plhrI/GpaFG+G68GedkGdw+8uBjKRD0N3LjRqs0tJM4c201lG7rmy g4kVEyEOvKQU4pstNQQx9KLrJn1StY9st9auCFHdgErFMwUU3aYDxByuYklqnQmQR4scaaGuaTP joyW6DxCUPqwmrC4VVzVAMAggxk4iPZ3jAPwcp3U/RjWPMycvfQOufqOp X-Received: by 2002:a17:902:ef4d:b0:2ca:62e:cc4f with SMTP id d9443c01a7336-2d3179824f5mr47183735ad.23.1786455409579; Tue, 11 Aug 2026 06:36:49 -0700 (PDT) X-Received: by 2002:a17:902:ef4d:b0:2ca:62e:cc4f with SMTP id d9443c01a7336-2d3179824f5mr47182825ad.23.1786455409155; Tue, 11 Aug 2026 06:36:49 -0700 (PDT) Received: from yli42-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d315f4819dsm8360885ad.37.2026.08.11.06.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 06:36:48 -0700 (PDT) From: Yin Li Date: Tue, 11 Aug 2026 21:30:34 +0800 Subject: [PATCH RFC 05/15] arm_mpam: Fix device_node refcount in DT resource parsing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260811-mpam-resctrl-dt-knp-support-v1-5-ea6397bead59@oss.qualcomm.com> References: <20260811-mpam-resctrl-dt-knp-support-v1-0-ea6397bead59@oss.qualcomm.com> In-Reply-To: <20260811-mpam-resctrl-dt-knp-support-v1-0-ea6397bead59@oss.qualcomm.com> To: "Rafael J. Wysocki" , Shanker Donthineni , Conor Dooley , Fenghua Yu , Krzysztof Kozlowski , Rob Herring , Reinette Chatre , Konrad Dybcio , James Morse , Ben Horgan , Bjorn Andersson , Danilo Krummrich , Greg Kroah-Hartman Cc: linux-arm-msm@vger.kernel.org, ganapatrao.kulkarni@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, devicetree@vger.kernel.org, driver-core@lists.linux.dev, Srivathsa L Rao , Huang Yiwei , aiqun.yu@oss.qualcomm.com, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1786455321; l=1766; i=yin.li@oss.qualcomm.com; s=20260811; h=from:subject:message-id; bh=ryf8Hd4nI6jqhAT1OBjk5xfOQnB0C6q+0/GQIGWdgsQ=; b=x5yeS79Rh62eUQVQ3gSGWwDDXvkKDLnAyOGYhwpSc1e05BrHTfEuigvJj8c5TUPwqxk5SQKrp /idl74HvQpZCB0whsc6thSG6yJJVYowhyPJBLVy3zn+p/4Gd93Qx/oe X-Developer-Key: i=yin.li@oss.qualcomm.com; a=ed25519; pk=e/2LM97aSWGBMrxY240URBi9Zi8/kL5hXgB+VHkYvW0= X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDExNCBTYWx0ZWRfX/y9PhjoWQolm fUo/2153hPNo4SgqXXm7GDDxSc47ArDmTvnQQ1wVGdMXKKhjNci5/3qlp9KpXkW9wEwj46Gmn7T iLDLZ04BOilVqsjSknBDyxRDeeAiT6Q= X-Proofpoint-ORIG-GUID: I43QrWPHJQyOMNRjtuaSKP_n_EqptloW X-Proofpoint-GUID: I43QrWPHJQyOMNRjtuaSKP_n_EqptloW X-Authority-Analysis: v=2.4 cv=cvarVV4i c=1 sm=1 tr=0 ts=6a7b2572 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=CToXZ0GCVVG03vgtT4YA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDExNCBTYWx0ZWRfXxGtkviSF+XWx Va4Kd1e2sEwcg9cGEVztDlIyetzanq+aVWrQIPfz2dDLPNjzk0QQxnqiz9LnWUWjydHK1ly43av 3DJVQvFOgwYYYZHp/05qu6le2l5AgYn70XHdGSHZd1A2quAiMgFPtZW1ZNDTw5Nsd3e4yPFz/Nx wYFcjs0ZBaPg/Jl2GlUlos2CGPQSXb0vo9L2ak2lACT9XuOST1EMIqAj6TQ6EWM8tYRfxUKtD9s /sfzE3b55T45jKZF3c17QoQTS4ppVUi3XnFpJsbRuzlOwE9AnxD3me9IsTJyeXShAjKobDheG4q 6w+CeOeqnI+HPanq4ZfaPmltUxFtK6uIHGcDKpAc5nsCz9AbfUFJjA0ResFbhiSkgJX4Bkya816 TdMiGwIb06JHDoL7yV+TdgaQUwZMOFxGdfsxDmsUHh2YV6VEinwshF8j+K3m0I21yCYj3NiR1Uv KzJ245zaeoqT2agNqgQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-11_03,2026-08-10_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 priorityscore=1501 lowpriorityscore=0 malwarescore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608110114 When a cache-parented or memory-controller-parented MSC is probed via device tree, the parent node was assigned directly to a __free(device_node) variable without incrementing its reference count. Both the parent and the cache/memory variable are declared with __free(device_node), which causes the compiler to automatically insert an of_node_put() call for each variable when they go out of scope. Since both variables point to the same node but the reference count was only incremented once by of_get_parent(), the node ends up being released twice, causing a refcount underflow. Use of_node_get() to take an explicit reference so each __free variable holds its own reference. Signed-off-by: Yin Li --- drivers/resctrl/mpam_devices.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index 975ddab771b4..559fa09128b4 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -280,7 +280,7 @@ static int mpam_dt_parse_resource(struct mpam_msc *msc, struct device_node *np, type = MPAM_CLASS_CACHE; } else if (of_device_is_compatible(parent, "cache")) { - cache = parent; + cache = of_node_get(parent); type = MPAM_CLASS_CACHE; } else if (of_device_is_compatible(np, "arm,mpam-memory")) { memory = of_parse_phandle(np, "arm,mpam-device", 0); @@ -290,7 +290,7 @@ static int mpam_dt_parse_resource(struct mpam_msc *msc, struct device_node *np, } type = MPAM_CLASS_MEMORY; } else if (of_device_is_compatible(np, "arm,mpam-memory-controller-msc")) { - memory = parent; + memory = of_node_get(parent); type = MPAM_CLASS_MEMORY; } else { /* -- 2.34.1