From: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
To: Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Liviu Dudau <liviu.dudau@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
Grant Likely <grant.likely@linaro.org>,
Heiko Stuebner <heiko@sntech.de>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
kernel@collabora.com,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>,
Steven Rostedt <rostedt@goodmis.org>
Subject: [PATCH v3 0/3] Rework panthor's cache flush and soft reset locking
Date: Tue, 11 Aug 2026 16:08:30 +0200 [thread overview]
Message-ID: <20260811-panthor-cache-flush-fix-v3-0-47d2c1bb1dab@collabora.com> (raw)
There are two problems in panthor's cache flushing/soft reset code
related to locking.
The first problem is that the spinlocks are taken with _irqsave, even
though the contended lock is never acquired in a raw interrupt handler.
Only a threaded handler locks it.
The second problem is that the wait_event condition references
pending_reqs without holding the required lock. This means there's a
data race.
While resolving the first problem is easy, the second problem requires
adding some more macro variants to wait.h, which is done in the first
patch.
New tracepoints to debug cache flushing duration without initial locking
waits is thrown in for good measure as well, to complement what's in
lock_stat and what the function tracer can already do.
Signed-off-by: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
---
Changes in v3:
- Drop new wait_event macro patch as the existing ones have a memory
barrier that makes the current use valid
- Rewrite fix patch to use scoped guards, and just get rid of the IRQ
disabling
- Add separate fix for the outside-of-lock pending_reqs clearing in soft
reset path
- Move tracepoint patch to before fixes for easier before/after testing
- Link to v2: https://patch.msgid.link/20260730-panthor-cache-flush-fix-v2-0-28790478bfff@collabora.com
Changes in v2:
- Use trace event template for the two tracepoints (ty Steven Rostedt)
- Link to v1: https://patch.msgid.link/20260729-panthor-cache-flush-fix-v1-0-205921ed3c81@collabora.com
---
Nicolas Frattaroli (3):
drm/panthor: Add tracepoints for cache flushing
drm/panthor: Revisit reqs_lock handling in flush/reset paths
drm/panthor: Take reqs_lock in soft_reset for clearing pending_reqs
drivers/gpu/drm/panthor/panthor_gpu.c | 70 +++++++++++++++++----------------
drivers/gpu/drm/panthor/panthor_trace.h | 49 +++++++++++++++++++++++
2 files changed, 85 insertions(+), 34 deletions(-)
---
base-commit: dc462ab791b686c48545c160ecc81be64f77a846
change-id: 20260728-panthor-cache-flush-fix-b36cb15f92c3
Best regards,
--
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
next reply other threads:[~2026-08-11 14:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 14:08 Nicolas Frattaroli [this message]
2026-08-11 14:08 ` [PATCH v3 1/3] drm/panthor: Add tracepoints for cache flushing Nicolas Frattaroli
2026-08-11 14:29 ` Boris Brezillon
2026-08-12 12:21 ` Nicolas Frattaroli
2026-08-11 14:08 ` [PATCH v3 2/3] drm/panthor: Revisit reqs_lock handling in flush/reset paths Nicolas Frattaroli
2026-08-11 14:33 ` Boris Brezillon
2026-08-13 15:29 ` Liviu Dudau
2026-08-11 14:08 ` [PATCH v3 3/3] drm/panthor: Take reqs_lock in soft_reset for clearing pending_reqs Nicolas Frattaroli
2026-08-11 14:37 ` Boris Brezillon
2026-08-13 15:30 ` Liviu Dudau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811-panthor-cache-flush-fix-v3-0-47d2c1bb1dab@collabora.com \
--to=nicolas.frattaroli@collabora.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=rostedt@goodmis.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®