From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17E5E30CD82 for ; Tue, 11 Aug 2026 14:09:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786457372; cv=pass; b=jPfzEMRtFTYOJ0xbZKnUQdf9+iZSCf1s7B01ceQpYL6PsPjleNi7EcSEOxNk8MgABd5NlNNnf5oBV9h6qX4F+gm0q2whVBTzxLPAsN/l1vviivv8Uo+SH/rSW1Q+rZ2onbw0f3bJCTwBAcCnOfStO1xI94iTSUsPq2jUh9p/iew= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786457372; c=relaxed/simple; bh=aUSprBRKoh95EufdzdvB8ZfNqQV0g1E5lDiA5iLLbE0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=dlGONxyCLKNi5ZqcdfcNb9sII1GMCX9+9OFXr0DUiLrNsdxq7l+dpHuPBZndWiZeT1dMMf/CI3RK5jX3KfA3zVkZUM7OTPgIIDXAk5Mkh7u+jvEWGOGFSq7kvmQQtYmVVUUQcLn28GB7zXispXhJTzOOtWTvN0BLkbSdrwOpC3w= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b=Z3/8YS25; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nicolas.frattaroli@collabora.com header.b="Z3/8YS25" ARC-Seal: i=1; a=rsa-sha256; t=1786457333; cv=none; d=zohomail.com; s=zohoarc; b=Ak53tQMwJfivqA0+oxwbnM0L5TLa4MIQg3pXOkAayDs9jSmL49WiQQRsaRIhr1uHuSeCWMlN2K4XyPxYhSMIQkOEm12TRZTFhdINAyDZjL2hagWSQi1o70sPvmjFjpAP3zoz+6zKqHxdT+747Ouy1c0ll8TsTWV13orvm8Q1M60= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1786457333; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=3fT14n90ozqqTYJQMw6uHTyJd21LufucJb+NqjZg9zg=; b=Q5oSgFdnWia4p6hcj7K+GYUjD/qp595I3nXyCU0hm8hbBITuVcYjoJ2c6P0OSj4g1d93pA39au9Dq112KDv2hv0gaP/K15Wp+qMspwFEz/Gqjr6Wboy6iakXUq8DAvNW/QZmFfvGcM6hXtPf0is06jCgr8ezWj5dw8AGqmgsbjE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nicolas.frattaroli@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1786457333; s=zohomail; d=collabora.com; i=nicolas.frattaroli@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=3fT14n90ozqqTYJQMw6uHTyJd21LufucJb+NqjZg9zg=; b=Z3/8YS257bLyWTOJaOWSub2DVtKJUAt+qjQXwVvYRbSKIsrRnl4jzcIeFijQS1a2 f33ZFoaoIcSzpgURBdsHXJ8Iwt9zXAqd17f5XjzyAUeOZ8xG6m9FIRkzmjNgAbZxZlD pqnLdQHeUSTyso9qAA3REQGse4ECpVnEBelE0N0o= Received: by mx.zohomail.com with SMTPS id 178645733151453.25361545246915; Tue, 11 Aug 2026 07:08:51 -0700 (PDT) From: Nicolas Frattaroli Date: Tue, 11 Aug 2026 16:08:31 +0200 Subject: [PATCH v3 1/3] drm/panthor: Add tracepoints for cache flushing Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260811-panthor-cache-flush-fix-v3-1-47d2c1bb1dab@collabora.com> References: <20260811-panthor-cache-flush-fix-v3-0-47d2c1bb1dab@collabora.com> In-Reply-To: <20260811-panthor-cache-flush-fix-v3-0-47d2c1bb1dab@collabora.com> To: Boris Brezillon , Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Grant Likely , Heiko Stuebner Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com, Nicolas Frattaroli , Steven Rostedt X-Mailer: b4 0.15.2 Add two new event tracepoints: gpu_cache_flush_start to be emitted after acquiring the flush mutex and reqs spinlock, and gpu_cache_flush_end to be emitted when leaving the function. This allows debugging the duration a flush takes irrespective of initial function entry lock contention by subtracting the start tracepoint's timestamp from the end tracepoint timestamp, and additionally contains information such as which caches were flushed. Reviewed-by: Steven Rostedt Reviewed-by: Liviu Dudau Reviewed-by: Steven Price Signed-off-by: Nicolas Frattaroli --- drivers/gpu/drm/panthor/panthor_gpu.c | 7 ++++- drivers/gpu/drm/panthor/panthor_trace.h | 49 +++++++++++++++++++++++++++++++++ 2 files changed, 55 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c index c013d6bf9a59..68e2dd2527df 100644 --- a/drivers/gpu/drm/panthor/panthor_gpu.c +++ b/drivers/gpu/drm/panthor/panthor_gpu.c @@ -337,6 +337,7 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, guard(mutex)(&ptdev->gpu->cache_flush_lock); spin_lock_irqsave(&ptdev->gpu->reqs_lock, flags); + trace_gpu_cache_flush_start(ptdev->base.dev, l2, lsc, other); if (!(ptdev->gpu->pending_reqs & GPU_IRQ_CLEAN_CACHES_COMPLETED)) { ptdev->gpu->pending_reqs |= GPU_IRQ_CLEAN_CACHES_COMPLETED; gpu_write(gpu->iomem, GPU_CMD, GPU_FLUSH_CACHES(l2, lsc, other)); @@ -345,8 +346,10 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, } spin_unlock_irqrestore(&ptdev->gpu->reqs_lock, flags); - if (ret) + if (ret) { + trace_gpu_cache_flush_end(ptdev->base.dev, l2, lsc, other); return ret; + } if (!wait_event_timeout(ptdev->gpu->reqs_acked, !(ptdev->gpu->pending_reqs & GPU_IRQ_CLEAN_CACHES_COMPLETED), @@ -360,6 +363,8 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, spin_unlock_irqrestore(&ptdev->gpu->reqs_lock, flags); } + trace_gpu_cache_flush_end(ptdev->base.dev, l2, lsc, other); + if (ret) { panthor_device_schedule_reset(ptdev); drm_err(&ptdev->base, "Flush caches timeout"); diff --git a/drivers/gpu/drm/panthor/panthor_trace.h b/drivers/gpu/drm/panthor/panthor_trace.h index 6ffeb4fe6599..6951b95b1de7 100644 --- a/drivers/gpu/drm/panthor/panthor_trace.h +++ b/drivers/gpu/drm/panthor/panthor_trace.h @@ -76,6 +76,55 @@ TRACE_EVENT(gpu_job_irq, __entry->events, __entry->duration_ns) ); +DECLARE_EVENT_CLASS(gpu_cache_flush_template, + TP_PROTO(const struct device *dev, u32 l2, u32 lsc, u32 other), + TP_ARGS(dev, l2, lsc, other), + TP_STRUCT__entry( + __string(dev_name, dev_name(dev)) + __field(u32, l2) + __field(u32, lsc) + __field(u32, other) + ), + TP_fast_assign( + __assign_str(dev_name); + __entry->l2 = l2; + __entry->lsc = lsc; + __entry->other = other; + ), + TP_printk("%s: l2=0x%x lsc=0x%x other=0x%x", __get_str(dev_name), + __entry->l2, __entry->lsc, __entry->other) +); + +/** + * gpu_cache_flush_start - called after cache flush locks taken, before flush + * @dev: pointer to the &struct device, for printing the device name + * @l2: "l2" flush flags + * @lsc: "lsc" flush flags + * @other: "other" flush flags + * + * Fires after any initial lock contention around the locks needed for flushing + * caches, but before the actual cache flush is requested. + */ +DEFINE_EVENT(gpu_cache_flush_template, gpu_cache_flush_start, + TP_PROTO(const struct device *dev, u32 l2, u32 lsc, u32 other), + TP_ARGS(dev, l2, lsc, other) +); + +/** + * gpu_cache_flush_end - called after cache flush + * @dev: pointer to the &struct device, for printing the device name + * @l2: "l2" flush flags + * @lsc: "lsc" flush flags + * @other: "other" flush flags + * + * Fires after either the cache flush is complete, or has failed. Can be used + * together with gpu_cache_flush_start to get how long the flush has taken. + */ +DEFINE_EVENT(gpu_cache_flush_template, gpu_cache_flush_end, + TP_PROTO(const struct device *dev, u32 l2, u32 lsc, u32 other), + TP_ARGS(dev, l2, lsc, other) +); + #endif /* __PANTHOR_TRACE_H__ */ #undef TRACE_INCLUDE_PATH -- 2.55.0