From: Boris Brezillon <boris.brezillon@collabora.com>
To: Steven Price <steven.price@arm.com>, Liviu Dudau <liviu.dudau@arm.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Boris Brezillon <boris.brezillon@collabora.com>
Subject: [PATCH v2 11/17] drm/panthor: Don't pre-allocate VMAs or page tables when preparing a full VM unmap
Date: Tue, 11 Aug 2026 12:17:45 +0200 [thread overview]
Message-ID: <20260811-panthor-unplug-fixes-v2-11-6b583e37f9ae@collabora.com> (raw)
In-Reply-To: <20260811-panthor-unplug-fixes-v2-0-6b583e37f9ae@collabora.com>
In the cleanup path, we unmap the full VA range to make sure things are
clean before the VM is released. I'd rather not fail on memory
allocation in that path, so let's make sure
panthor_vm_pgtable_prepare_unmap_op_ctx() doesn't allocate VMAs or
page tables when the unmap range matches the VM virtual address range.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
drivers/gpu/drm/panthor/panthor_mmu.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
index a48466788f4d..acdc0dd04f8b 100644
--- a/drivers/gpu/drm/panthor/panthor_mmu.c
+++ b/drivers/gpu/drm/panthor/panthor_mmu.c
@@ -1466,6 +1466,10 @@ static int panthor_as_prepare_unmap_op_ctx(struct panthor_as_op_ctx *op_ctx,
op_ctx->va.addr = va;
op_ctx->flags = DRM_PANTHOR_VM_BIND_OP_TYPE_UNMAP;
+ /* Unmap on the whole VM range don't need new VMAs or page tables. */
+ if (va == as->base.mm_start && size == as->base.mm_range)
+ return 0;
+
/* Pre-allocate L3 page tables to account for the split-2M-block
* situation on unmap.
*/
--
2.55.0
next prev parent reply other threads:[~2026-08-11 10:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 10:17 [PATCH v2 00/17] drm/panthor: Fix the unplug logic Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 01/17] drm/panthor: Disable reset work before unplug Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 02/17] drm/panthor: Further delay reset work enablement Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 03/17] drm/panthor: Make sure reset requests in the resume path are not lost Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 04/17] drm/panthor: Make sure reset requests in the post reset " Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 05/17] drm/panthor: Flush the cleanup_wq in the unplug path Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 06/17] drm/panthor: Drop unused vm argument passed to panthor_vm_prepare_sync_only_op_ctx() Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 07/17] drm/panthor: Move the debugfs initialization to panthor_device.c Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 08/17] drm/panthor: Split panthor_vm Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 09/17] drm/panthor: Add fine-grained restrictions on VMs Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 10/17] drm/panthor: Check AS state before disabling Boris Brezillon
2026-08-11 10:17 ` Boris Brezillon [this message]
2026-08-11 10:17 ` [PATCH v2 12/17] drm/panthor: Make the VM cleanup path more robust against UAF Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 13/17] drm/panthor: Track user owned VMs Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 14/17] drm/panthor: Track user owned groups Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 15/17] drm/panthor: Fix the unplug logic Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 16/17] drm/panthor: Add a debugfs knob to simulate unplug failures Boris Brezillon
2026-08-11 10:17 ` [PATCH v2 17/17] drm/panthor: Add a debugfs knobs to simulate reset failures Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811-panthor-unplug-fixes-v2-11-6b583e37f9ae@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®