From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 794FE419314 for ; Tue, 11 Aug 2026 08:27:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436873; cv=none; b=gEV9oFYepYl1X9uMgh/KbhyOpKalt9SMCIzHlLc+uJaFh42b8TKfigpm3uhJrJYVkN88IqkMgSIDMR6vTFtoMEZH42bWH+hNyeQLU1jPohnWf/u7ARpBlKyad+uxcZF/N01RrW7Jp1Di9CEAy4+E9RecrMs4DEQei3QwJY1Ayz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786436873; c=relaxed/simple; bh=0NFMkiI9cGUJGQu0nU9aq2ncgiF85JLhExyubCYkRTE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=MprLixhLm6Hbj68jYyaIcvP8YgKCRUrxtnq3X60oWjPfHYGdR03BS1ZbhTmehMLcmSiNLBjGMDIDo+rNATLXLjDzh/UjLFNu2VORDI8QZljxTDjcstyPglamxpBnlOiLzO4Svg3+qSzJv1eQpYQvrWQYzNzMADea41H8d3aZA0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E/SQHQZ6; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E/SQHQZ6" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-4a475409044so603683b6e.1 for ; Tue, 11 Aug 2026 01:27:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786436870; x=1787041670; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cY5JFkhr2MFK4a7Q8KfriRWA+QTcA2VyYLDaWVkulWM=; b=E/SQHQZ6kXKICHorM0s2Cz83MfOJ8Kp/9BEBBVd2v194uV1gXl3XsYR1+68j82WuuC LgaApsgtgax0VFyPxr8JOCefaM2uGK7VXVvD8zIsPX3b2NYptCFDVFs3P+aqC6aVgUIP H9LhYyOURBYJ6MdPcrLucdfSK7qDgRAYUoPoxcP4e8z82b7hhUBxqEuq+c47j5y5lhJi psnbD4F7ytApkFyDzxTU+JIjzgOeY0UmWaoNNpM36ftUUuzKrMxhiUpjUxJRkSiJrHcg /RmkBO2MhFiHLB2rvk61Gd0BSp9SwaDdeqq9urZ6r78puLRyJ+kmaQ6FOEE+tPPoq2tV 2FYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786436870; x=1787041670; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=cY5JFkhr2MFK4a7Q8KfriRWA+QTcA2VyYLDaWVkulWM=; b=LtDnQSHFeS1I2b9jKHjS3KY9gbVPLr1TaVq4DXbGq7OE12t1cW0TPMSXnvl9uBnI8K HfvkrbdYJAGyPs5TdhVpJqtgOzkWW5AsycSdMRPYVbmJ+s6QuiKZZvIJ6XuBEDRZIm+s FcmmXwVRoYaFmILRkTN1OLW5eRtXLbGrsuLWeH6DJCLk5/CLLR1UnWxeiB20TbjvxbIh wX+YyLMbe89/1zgoDU4YpuFVb4qV3q82EM5tHHCLiKAZTw+orgd8YtENntR6UDK9P/dG 4KU4Z9YzUxTOIxEoeXHjmwj6cyrSL3oDv6Zbbl6s97/JI4yTXQFcrzcu4csD3sz39nQ1 Lsug== X-Forwarded-Encrypted: i=1; AHgh+Ro/ayF1Q4+DHMbIDllN7ubz8On4JtoHaLW+5tHUd6nMEa84+dCK9aZ1FAetaL/AxJRs6Ky6HBp7YsLHULI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7t2AipWaTXok1a5WtWKP7FOGGm4Aa1GyP8970Nhh1xXJlykdN d+TQ3zYJ9FZAp9+LLzsT5E7KnVuMAucifBYEy9Brp/MQ5BLvx8qqHmmU X-Gm-Gg: AR+sD11Dq246eyXadFQYfgrVwNBMO+btMPsbeLJwiJkxwVRPi1nVRiwzzAJWn+Fdxvh Y7gL7X/9qf84LhQDrXK56IiZqMRVvl4H4pH7+OkExvtZBjAEJLCC6Av1N2HL4QPGBg3AgpKhi69 6IhuNtOQEecYtcxZOa5lfKVMR0w438aGq+fWxakjTNlnmlqLZTZUhpkJzLOFv54n4d97F5fGpGD 5rljmjyPl8gR1N/uyaZsCNT4Tzl/i//GHXn0HEiJ9tXK+ckHjWbC3admTUybke5LNg0+3Kxiwc8 6Q5LIf7cOpyLw9/XF6PIfMqE6j2PybCL0S5HRfmfZamA5TXSg+ukVp8CNcp1/p10YAdnsO1M7VT PP8ohxF6e+Fj3bVQ+TvE5tRVbA09fKr6bfUh3Zrzr+2r1XQlUSpk9ScP5vCo075296uewhGU3S2 Rg0zQWu6lmksAjKTVA3/dNthD7pWZ+L7d/6xckY4AX8ewBjH8yUNmhWsCOiuvt/xG9fgBNnT2kG tcaKxVr9w+FvvESKLYFwixmy1pmhEc0ZWrF7VBCIoRQyK7gbs+4P7eDBJgByNiRktd/k/x0gQzC X5KGw2ofHnf+l23rAvkeGBQHc/DyKZHjxO/9AILvDoqwpI0iYrI8t4PRX+RdNMR9uxSqbtCv383 Y1rwMmiceTAVymUuA X-Received: by 2002:a05:6808:4f47:b0:495:f67c:d96a with SMTP id 5614622812f47-4b1fd77a01cmr907432b6e.12.1786436870348; Tue, 11 Aug 2026 01:27:50 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4b1fff55fdcsm318095b6e.6.2026.08.11.01.27.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 01:27:48 -0700 (PDT) From: James Hilliard Date: Tue, 11 Aug 2026 02:27:25 -0600 Subject: [PATCH v6 3/3] mfd: ac200: Add X-Powers AC200 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260811-submit-ac200-mfd-v6-3-c5b1292c8498@gmail.com> References: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> In-Reply-To: <20260811-submit-ac200-mfd-v6-0-c5b1292c8498@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The X-Powers AC200 is a mixed-signal companion IC with a paged register map accessed over I2C. Enable the shared input clock and prevent its rate from changing. Match the vendor driver's 40 ms wait before the first register access, initialize the paged regmap, report the chip and package revision, and apply common reset. The Ethernet PHY link endpoint is independently enumerated on its MDIO bus, so publish the regmap through managed syscon registration for lookup through its AC200 firmware reference rather than creating an artificial MFD platform child. The managed entry is withdrawn before the regmap is released, while the function driver separately manages the PHY analog supply. Cache only the common page selector. Individual functions can reset independently and invalidate their other registers without regmap's knowledge, so leave all functional registers volatile. Reset the chip during managed teardown and system shutdown. Consumers can use device links to ensure that they unbind before the shared AC200 resources are released. Signed-off-by: James Hilliard --- drivers/mfd/Kconfig | 12 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/ac200.c | 170 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 183 insertions(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e4fd4572472f..f8354a0f6b5c 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -205,6 +205,18 @@ config MFD_AC100 This driver include only the core APIs. You have to select individual components like codecs or RTC under the corresponding menus. +config MFD_AC200 + tristate "X-Powers AC200" + depends on I2C + depends on OF + select MFD_SYSCON + select REGMAP_I2C + help + Support for the X-Powers AC200 mixed-signal companion IC. The AC200 + contains audio, video, RTC and Fast Ethernet PHY functions and is + co-packaged with some Allwinner H6 and H616 SoCs. This driver provides + the shared register access used by the individual function drivers. + config MFD_AXP20X tristate select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 72d3944b0ad8..f8101d2a9ce9 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -150,6 +150,7 @@ obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o obj-$(CONFIG_MFD_DA9052_I2C) += da9052-i2c.o obj-$(CONFIG_MFD_AC100) += ac100.o +obj-$(CONFIG_MFD_AC200) += ac200.o obj-$(CONFIG_MFD_AXP20X) += axp20x.o obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c new file mode 100644 index 000000000000..25066bb36ac7 --- /dev/null +++ b/drivers/mfd/ac200.c @@ -0,0 +1,170 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MFD core driver for the X-Powers AC200 + * + * Copyright (C) 2019 Jernej Skrabec + * Copyright (C) 2026 James Hilliard + * + * Based on the AC100 driver: + * Copyright (C) 2016 Chen-Yu Tsai + */ + +#include +#include +#include +#include +#include +#include +#include + +#define AC200_SYS_VERSION_REG 0x0000 +#define AC200_SYS_VERSION_PACKAGE_MASK GENMASK(15, 14) +#define AC200_SYS_VERSION_CHIP_MASK GENMASK(11, 0) + +#define AC200_SYS_CONTROL_REG 0x0002 +#define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0) + +/* Interface register accessible from every register page. */ +#define AC200_TWI_REG_ADDR_H 0x00fe +#define AC200_MAX_REG 0xa1f2 + +struct ac200 { + struct regmap *regmap; +}; + +static const struct regmap_range_cfg ac200_range_cfg[] = { + { + .range_max = AC200_MAX_REG, + .selector_reg = AC200_TWI_REG_ADDR_H, + .selector_mask = 0xff, + .window_len = 256, + }, +}; + +/* + * Each AC200 sub-block can reset independently, invalidating its register + * contents without regmap's knowledge. Cache only the common page selector; + * this avoids a selector read-modify-write for every access on the same page + * without ever returning stale functional-register values. + */ +static bool ac200_volatile_reg(struct device *dev, unsigned int reg) +{ + return reg != AC200_TWI_REG_ADDR_H; +} + +static const struct regmap_config ac200_regmap_config = { + .name = "ac200", + .reg_bits = 8, + .reg_stride = 2, + .val_bits = 16, + .ranges = ac200_range_cfg, + .num_ranges = ARRAY_SIZE(ac200_range_cfg), + .max_register = AC200_MAX_REG, + .volatile_reg = ac200_volatile_reg, + .cache_type = REGCACHE_MAPLE, +}; + +static void ac200_disable(void *data) +{ + struct ac200 *ddata = data; + + regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); +} + +static int ac200_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + unsigned int version; + struct ac200 *ddata; + struct clk *clk; + int ret; + + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + clk = devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to enable input clock\n"); + + ret = devm_clk_rate_exclusive_get(dev, clk); + if (ret) + return dev_err_probe(dev, ret, "failed to lock clock rate\n"); + + ddata->regmap = devm_regmap_init_i2c(client, &ac200_regmap_config); + if (IS_ERR(ddata->regmap)) + return dev_err_probe(dev, PTR_ERR(ddata->regmap), + "failed to initialize regmap\n"); + + i2c_set_clientdata(client, ddata); + + /* + * No minimum delay is documented. Match the vendor driver's 40 ms delay + * before its first AC200 register access after enabling the input clock. + */ + msleep(40); + + ret = regmap_read(ddata->regmap, AC200_SYS_VERSION_REG, &version); + if (ret) + return dev_err_probe(dev, ret, + "failed to read chip version\n"); + + dev_info(dev, "AC200 revision %#lx in package %lu\n", + FIELD_GET(AC200_SYS_VERSION_CHIP_MASK, version), + FIELD_GET(AC200_SYS_VERSION_PACKAGE_MASK, version)); + + /* Reset the chip after dependent function drivers have unbound. */ + ret = devm_add_action_or_reset(dev, ac200_disable, ddata); + if (ret) + return ret; + + ret = regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); + if (ret) + return ret; + + ret = regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, + AC200_SYS_CONTROL_CHIP_RESET_DEASSERT); + if (ret) + return ret; + + ret = devm_of_syscon_register_regmap(dev, dev->of_node, + ddata->regmap); + if (ret) + return dev_err_probe(dev, ret, + "failed to register regmap\n"); + + return 0; +} + +static void ac200_shutdown(struct i2c_client *client) +{ + ac200_disable(i2c_get_clientdata(client)); +} + +static const struct of_device_id ac200_of_match[] = { + { .compatible = "x-powers,ac200" }, + { } +}; +MODULE_DEVICE_TABLE(of, ac200_of_match); + +static const struct i2c_device_id ac200_i2c_ids[] = { + { .name = "ac200" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, ac200_i2c_ids); + +static struct i2c_driver ac200_driver = { + .driver = { + .name = "ac200", + .of_match_table = ac200_of_match, + }, + .probe = ac200_probe, + .shutdown = ac200_shutdown, + .id_table = ac200_i2c_ids, +}; +module_i2c_driver(ac200_driver); + +MODULE_AUTHOR("James Hilliard "); +MODULE_DESCRIPTION("X-Powers AC200 MFD core driver"); +MODULE_LICENSE("GPL"); -- 2.53.0