From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12B2A42DA44 for ; Tue, 11 Aug 2026 23:11:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786489922; cv=none; b=VqU+l1rVftKYkhXoRW5vrGNrx41K1Dx9qhYhRM6t8ENjB2ahFvEp6omDzpukaWR6n/fNfZTec40VP3hldJgyO3gd5Md5wxc7nB4Ha00479Gc/GnjeNoklOm8Av5KyDsCxLs2nYc16yKDCbwz7Y98EE5CXBriC8cO5QEgN7z404w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786489922; c=relaxed/simple; bh=QralU1poZQg09RVKr5NNb/BibZe2gOrv/KNDHTC44yo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uVm/pYvsUed+iZhA2AYhA3gN5eJuI2RPRuGwdUWm3cnicoA+BkwbEjxYa0YebWtH7oUI1mZUqbdV/ZcHqfACXRN89m7dIEPjbv566coq0NjWKGlp33xmAeySXdkOuyB2ttzODc5B6jq7nV2kzdLwxe7vLXgVcg8AkrkxKAmWQaQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HyFC+3Xf; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HyFC+3Xf" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-7ee50eb2db4so320887a34.3 for ; Tue, 11 Aug 2026 16:11:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786489919; x=1787094719; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VBgBajntdhkFY7cnFzN+T0hqoforp5BZwweLljzEDt0=; b=HyFC+3XfHi8DkzTh8eH35pgh8bl+E89DT4D+WIe03++781bIfslZ7Hjtueiqb6N3yl IZjrjsgcV6Puv1Gydwrj6ltkTv2m4ExX/pZMjp/0x2ZthDTObxRGqNz4p4uz8y/AWmLL 79r+NlVjlPdP3NbXf+UvhBlg1t668oTiU53J4A31BN22gmEr5BsQajylaIiZTOBDnJM2 yC4awI5Qh6BYo1ZYtCyeqm1mEfIzsjCkKXg8eRJToaAkHdVaCHsCrEKYxwrtp4PDhPtp 5h++6e773ikAy7EWony4sXtwDlnxwyS2AEuOrO8O0HlHHoOtPgQmOBlmkDF+cE8fmlIJ S6eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786489919; x=1787094719; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=VBgBajntdhkFY7cnFzN+T0hqoforp5BZwweLljzEDt0=; b=pt8Te36gGX4+MZZM16dql/Zo/ianxdFaijniU1iTc5Nmj+rc+s06PxLHX3zOJVqTNt zdc/5Xo8Tt3LCjBnBhBCiWni7/ECBZnPba0iFv5rIyiv4ZRQ3gkuTIFPa1wCaOYE9hoM pp913cOt50iADlB3MeJTyHN0er71eAqklytpPg/Ffh5Vd9cwvV0Hqzljep8GNzzecF1V lbmJTOt/SB95K7SYpo0tT/7lUWJmuFWMgBHSR8wyO3OJtBu87RbT+9tXqcWjsfM1tUov 2mZYDxXT6dMV48SIQ/tAs9T8RIMgKiUw/DRRBC6sJ+WGyg2NjreYRdz8zY90WEua5WAT +zig== X-Forwarded-Encrypted: i=1; AHgh+RqKzl5cCce+NPdcYNNg+h6wv09B0OxSYFuvMBBM5FR2kP9iospfPFzHZeaOfWw65NTA5YLe2zawFGifKeE=@vger.kernel.org X-Gm-Message-State: AOJu0YxFNgZA5OqfM9vpE6b0Z00pMOokPm6LdDu9TfXGjQ91P2GYPAKX pStyslP5RLRenAVExERkU4sfY2Y6IxHDRYslcynYYaAg38C/iCCzMgKg X-Gm-Gg: AR+sD13JALjdcSyMNdWS5BeyS7VhFjGs1iZEUVGNgKlpeqbczgrWdjkuPvAEgLMfVnO Z9Hlwg7e0rFi6QPxjAeN0viSj5tHpChupb+eRecvWvF2lOhSNx2PW+qhfYTsoEGuEU+VL+RkKYE opcWbd9FC9+eE8Nsx1A8iPgnUfwQukGxqh8+qhIJo7zlf8+it9kxYV4xLr/CMuM8cPKe28Yk2h3 nzYj62S64ScHd1v2qJtewVQzye+flzJVwCzy+BYxbdajKZU3kE/7WoEmaFt4ONewMzBIRzdNXlu xXRDAHpBAM3262y0d7PMNXhFu9RCA4Gcv7wPcUjUyrDm2DfAa1BBlPe8LD2u/acZxVxdXrJLpBa 9FSR331cjtiVFdB7B7k1Y5x5RFvgim4Vqq0cGzviX6ogJzUn0MWABr+3Df3uF5PGBjGrQSS28hx FFBwFGnYZtfGxpt/lmw1x9SEnXc3VFrP5qaRIpLcqpsZrlj5dbuAXgqJH/Qj9bpS9ULenAc6YFw bH67rRc+4fo9jSTG7WeMK1o4rp0LDDjTvkCv/6AXjo8/Uj9Ky8wEjRAOabOuqJEHqO/OjTSdbSV oOsBLT4Naarku0dW+D4bXFzkRty/yl9qeKhNeS+RFNdMN1Z+65y04CRQCriBOkjHebSkAml+IBE XwUwZAyaYkPpM0B4k X-Received: by 2002:a05:6820:c8a:b0:6ae:8a52:ffa5 with SMTP id 006d021491bc7-6b0b2adad44mr401448eaf.23.1786489918939; Tue, 11 Aug 2026 16:11:58 -0700 (PDT) Received: from [127.0.1.1] (184-96-154-59.hlrn.qwest.net. [184.96.154.59]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-45e3510fa5fsm713176fac.1.2026.08.11.16.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 16:11:58 -0700 (PDT) From: James Hilliard Date: Tue, 11 Aug 2026 17:11:31 -0600 Subject: [PATCH v7 2/2] mfd: ac200: Add X-Powers AC200 support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260811-submit-ac200-mfd-v7-2-8b06f552a4d7@gmail.com> References: <20260811-submit-ac200-mfd-v7-0-8b06f552a4d7@gmail.com> In-Reply-To: <20260811-submit-ac200-mfd-v7-0-8b06f552a4d7@gmail.com> To: Lee Jones , Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , James Hilliard Cc: Andrew Lunn , "Jagielski, Jedrzej" , Andre Przywara , Chen-Yu Tsai , =?utf-8?q?Jernej_=C5=A0krabec?= , linux-sunxi@lists.linux.dev, mfd@lists.linux.dev, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.15.2 The X-Powers AC200 is a mixed-signal companion IC with a paged register map accessed over I2C. Enable the shared input clock and prevent its rate from changing. Match the vendor driver's 40 ms wait before the first register access, initialize the paged regmap, report the chip and package revision, and apply common reset. The Ethernet PHY link endpoint is independently enumerated on its MDIO bus rather than created as an MFD platform child. Keep the regmap attached to the AC200 I2C device so a separately enumerated function can resolve that device, establish its required lifetime relationship and retrieve the regmap from the provider. Cache only the common page selector. Individual functions can reset independently and invalidate their other registers without regmap's knowledge, so leave all functional registers volatile. Reset the chip during managed teardown and system shutdown. Signed-off-by: James Hilliard --- drivers/mfd/Kconfig | 11 ++++ drivers/mfd/Makefile | 1 + drivers/mfd/ac200.c | 163 +++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 175 insertions(+) diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig index e4fd4572472f..cac3fff5aee9 100644 --- a/drivers/mfd/Kconfig +++ b/drivers/mfd/Kconfig @@ -205,6 +205,17 @@ config MFD_AC100 This driver include only the core APIs. You have to select individual components like codecs or RTC under the corresponding menus. +config MFD_AC200 + tristate "X-Powers AC200" + depends on I2C + depends on OF + select REGMAP_I2C + help + Support for the X-Powers AC200 mixed-signal companion IC. The AC200 + contains audio, video, RTC and Fast Ethernet PHY functions and is + co-packaged with some Allwinner H6 and H616 SoCs. This driver provides + the shared register access used by the individual function drivers. + config MFD_AXP20X tristate select MFD_CORE diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile index 72d3944b0ad8..f8101d2a9ce9 100644 --- a/drivers/mfd/Makefile +++ b/drivers/mfd/Makefile @@ -150,6 +150,7 @@ obj-$(CONFIG_MFD_DA9052_SPI) += da9052-spi.o obj-$(CONFIG_MFD_DA9052_I2C) += da9052-i2c.o obj-$(CONFIG_MFD_AC100) += ac100.o +obj-$(CONFIG_MFD_AC200) += ac200.o obj-$(CONFIG_MFD_AXP20X) += axp20x.o obj-$(CONFIG_MFD_AXP20X_I2C) += axp20x-i2c.o obj-$(CONFIG_MFD_AXP20X_RSB) += axp20x-rsb.o diff --git a/drivers/mfd/ac200.c b/drivers/mfd/ac200.c new file mode 100644 index 000000000000..0964e637afef --- /dev/null +++ b/drivers/mfd/ac200.c @@ -0,0 +1,163 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * MFD core driver for the X-Powers AC200 + * + * Copyright (C) 2019 Jernej Skrabec + * Copyright (C) 2026 James Hilliard + * + * Based on the AC100 driver: + * Copyright (C) 2016 Chen-Yu Tsai + */ + +#include +#include +#include +#include +#include +#include + +#define AC200_SYS_VERSION_REG 0x0000 +#define AC200_SYS_VERSION_PACKAGE_MASK GENMASK(15, 14) +#define AC200_SYS_VERSION_CHIP_MASK GENMASK(11, 0) + +#define AC200_SYS_CONTROL_REG 0x0002 +#define AC200_SYS_CONTROL_CHIP_RESET_DEASSERT BIT(0) + +/* Interface register accessible from every register page. */ +#define AC200_TWI_REG_ADDR_H 0x00fe +#define AC200_MAX_REG 0xa1f2 + +struct ac200 { + struct regmap *regmap; +}; + +static const struct regmap_range_cfg ac200_range_cfg[] = { + { + .range_max = AC200_MAX_REG, + .selector_reg = AC200_TWI_REG_ADDR_H, + .selector_mask = 0xff, + .window_len = 256, + }, +}; + +/* + * Each AC200 sub-block can reset independently, invalidating its register + * contents without regmap's knowledge. Cache only the common page selector; + * this avoids a selector read-modify-write for every access on the same page + * without ever returning stale functional-register values. + */ +static bool ac200_volatile_reg(struct device *dev, unsigned int reg) +{ + return reg != AC200_TWI_REG_ADDR_H; +} + +static const struct regmap_config ac200_regmap_config = { + .name = "ac200", + .reg_bits = 8, + .reg_stride = 2, + .val_bits = 16, + .ranges = ac200_range_cfg, + .num_ranges = ARRAY_SIZE(ac200_range_cfg), + .max_register = AC200_MAX_REG, + .volatile_reg = ac200_volatile_reg, + .cache_type = REGCACHE_MAPLE, +}; + +static void ac200_disable(void *data) +{ + struct ac200 *ddata = data; + + regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); +} + +static int ac200_probe(struct i2c_client *client) +{ + struct device *dev = &client->dev; + unsigned int version; + struct ac200 *ddata; + struct clk *clk; + int ret; + + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL); + if (!ddata) + return -ENOMEM; + + clk = devm_clk_get_enabled(dev, NULL); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to enable input clock\n"); + + ret = devm_clk_rate_exclusive_get(dev, clk); + if (ret) + return dev_err_probe(dev, ret, "failed to lock clock rate\n"); + + ddata->regmap = devm_regmap_init_i2c(client, &ac200_regmap_config); + if (IS_ERR(ddata->regmap)) + return dev_err_probe(dev, PTR_ERR(ddata->regmap), + "failed to initialize regmap\n"); + + i2c_set_clientdata(client, ddata); + + /* + * No minimum delay is documented. Match the vendor driver's 40 ms delay + * before its first AC200 register access after enabling the input clock. + */ + msleep(40); + + ret = regmap_read(ddata->regmap, AC200_SYS_VERSION_REG, &version); + if (ret) + return dev_err_probe(dev, ret, + "failed to read chip version\n"); + + dev_info(dev, "AC200 revision %#lx in package %lu\n", + FIELD_GET(AC200_SYS_VERSION_CHIP_MASK, version), + FIELD_GET(AC200_SYS_VERSION_PACKAGE_MASK, version)); + + /* Reset the chip after dependent function drivers have unbound. */ + ret = devm_add_action_or_reset(dev, ac200_disable, ddata); + if (ret) + return ret; + + ret = regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, 0); + if (ret) + return ret; + + ret = regmap_write(ddata->regmap, AC200_SYS_CONTROL_REG, + AC200_SYS_CONTROL_CHIP_RESET_DEASSERT); + if (ret) + return ret; + + return 0; +} + +static void ac200_shutdown(struct i2c_client *client) +{ + ac200_disable(i2c_get_clientdata(client)); +} + +static const struct of_device_id ac200_of_match[] = { + { .compatible = "x-powers,ac200" }, + { } +}; +MODULE_DEVICE_TABLE(of, ac200_of_match); + +static const struct i2c_device_id ac200_i2c_ids[] = { + { .name = "ac200" }, + { } +}; +MODULE_DEVICE_TABLE(i2c, ac200_i2c_ids); + +static struct i2c_driver ac200_driver = { + .driver = { + .name = "ac200", + .of_match_table = ac200_of_match, + }, + .probe = ac200_probe, + .shutdown = ac200_shutdown, + .id_table = ac200_i2c_ids, +}; +module_i2c_driver(ac200_driver); + +MODULE_AUTHOR("James Hilliard "); +MODULE_DESCRIPTION("X-Powers AC200 MFD core driver"); +MODULE_LICENSE("GPL"); -- 2.53.0