From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F553145B27 for ; Tue, 11 Aug 2026 00:14:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786407290; cv=none; b=NdMhb1bpfeHQd/L2dFAtl+62NES5EjascI+vwju4LvQXIkuC4RduFarZnXxzfsA+JHnXbyXGFHIcnksCZWl/S8LdJPO9R+tlevl25I0GFGa0zTqnkyIx+ayF6rVwui8riVrWyl1BY8BAbeJDH1mEkT12Dk2UJlPeGQ/BTZN7dFE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786407290; c=relaxed/simple; bh=MeHLQO9g34r4IviVhr8HSfXrlFV8n0+EyG6Dj/X+zwk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LPVLp60hTcP1mBiyneo2LIpzACrprnMUnM4rNmqtY6ezxbbC4wnWjUpBjuFq6Ty3aXf4o9NOhxJ+NipF5iwcTa3neZKoz5qujo4Lz0iDL8Otq9jiqpDdjH2vKcEnDT1xw4L1EQpszSaCYrj4NYmgtdnPXXefuysUmGs5T22Ah5M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=aKM9VFXT; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="aKM9VFXT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DC671F000E9; Tue, 11 Aug 2026 00:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786407289; bh=S842M+3n5foIBaw7PfExfIo338XkNBz7Heie7VOdBHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=aKM9VFXT7C8RTuuoXq4xhMvUlWXrYg5/sDDHUAiI8E2ZVq3ShgIPAP+a3DNdtH3Ie 3Ittxtkc9ePPf1SoQG4mPGRn6TLCkXIZ+ndPpCCbUAYK2beENX2+Zo/ywqvmIaTPWF vdHBnhrnwSYyPc5b2uqr5sVDqI1VV3CfU5ocfdm/CaBcxORcUMh+YMBiUMP5etREcO 7Gto+zvpyw6/aGnmNPiqneoNTjNCPJfn+oiglCwInzHhQ16yjBKETjYPwAvKYaBVJ/ c4VZXO12K10cpa8cp3k0R/JBtTp20Ni9GtT4sW8XUfRxepwm2TEcENt5o+IKIkrESD jX6/A7OOre+kQ== From: SJ Park To: Hongfu Li Cc: SJ Park , akpm@linux-foundation.org, david@kernel.org, ljs@kernel.org, liam@infradead.org, vbabka@kernel.org, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hongfu Li Subject: Re: [PATCH] mm/cma: remove stray newline from auto-generated CMA area name Date: Mon, 10 Aug 2026 17:14:40 -0700 Message-ID: <20260811001441.96169-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260810093215.91419-1-hongfu.li@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Mon, 10 Aug 2026 17:32:15 +0800 Hongfu Li wrote: > From: Hongfu Li > > When no name is supplied, cma_new_area() generates names with format > "cma%d\n", introducing an unintended newline character ('\n') in the > CMA name. Nice catch! > > Most CMA regions are created with explicit names, so this path is > seldom hit. The newline only creates cosmetic noise in debug logs, > traces and debugfs with no functional impact. > > Signed-off-by: Hongfu Li Reviewed-by: SJ Park > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index a7929c758df1..a10ea37a261d 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -242,7 +242,7 @@ static int __init cma_new_area(const char *name, phys_addr_t size, > if (name) > strscpy(cma->name, name); > else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + snprintf(cma->name, CMA_MAX_NAME, "cma%d", cma_area_count); It also removes one unnecessary space! Nice! Thanks, SJ [...]