From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 569B82EA754 for ; Tue, 11 Aug 2026 01:17:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786411049; cv=none; b=uZmBCpfcMR5cRTSwXI5jcwYuuQCH8JUbJy7p7B0naWxXnnnrffppAki4e+uA/8eoZPa2hfiuURJyPOLywtUgl9daKxLqcfzuSfOAW+q5KD02zDyQrqrJhn3WT7LFq/gXX8dJTwjB+My6Y7Y02WhWdBDa0xrhpevjIIL9ic9gTPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786411049; c=relaxed/simple; bh=VikHt54Ptc1U5+w3VcuMD6AVAjm4zUAmKq760HwXhjc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Gj8qpfy05ptgG7TkMOYSKK/t1b+cz7BjwNBfWPORQTMRazOPpiemM6Y4Wq0vD/dpkFemPz21iJq+xSmSsRY6OO5lFcZHoVW6Y2S8VTCVn6XCTPv4Y2Bu8G33sQ/OQHKUp9aCoCM6kFqCaCc7thaKOlnl39+qkHGjI1ibjYfuZ3c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LkJE60Ft; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LkJE60Ft" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2d027b7c8easo6474065ad.3 for ; Mon, 10 Aug 2026 18:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786411048; x=1787015848; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QaU2aib2fka6g8K5mPVr/qx+AvcdUlKsiWM47P5rcKw=; b=LkJE60FtTVDJxK0/5ZkXWZMSkEk2l1MTYe/4Ny278iq5i3IV0HeTINgd8KoNDrjvTR rPSMyuBuaRKz9S7s2dkuKNRs3kiUMm7NEcC/kkQ8tLhoVGxT1/JlTwkpU8seoHwVYIHW UejRp9w/MDHh9TkYcIZ82LxCw1+vvu3hoN4uc4/8eBaYM2SmFF0mGupks97VDsk2EpDG NIZWW4VWvrDhrvUGVgUzXTDXsbnY4l2/UVx4Bbju43C34JeTAxreflQ9uC8441zU6Vcx t12Ba68kP4u5frKnC7/+/VssXy9/QH/mHCZadhmf6YuP6ejjTYnpIxRcN0tTwED1kiZU WvkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786411048; x=1787015848; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QaU2aib2fka6g8K5mPVr/qx+AvcdUlKsiWM47P5rcKw=; b=b7d/tDjf3G3QoItEKMpizd7O861bdqMD1X18wivs67s/H/UrJDky9IbLvgDeHS975R gzEQnbQyCLidxkcxZy5lwious44RoRlDcqf3H+G+IKTm7BdSwIKf4MlHHZk3Flt7f4Nu nXkWqqGRvmgLCw6jS01YfwdL9Rv0suQ5wErlsxSs59XjbJ6Y24RyAvj1ytvNd9wskBo4 j8Hyd4BEdeglWd7QmsTmgenEVWrUNU1G1jF8rjahRyAwy1JQ2E1CO5OLZtSTwJb7rnrl 6cFAxjNG6kP+aqNiEpMo2oJx7Ht2mSi5a/RRmynFWM6cV0ZBBarH28SqW5RIi0/8x5LU rdYA== X-Forwarded-Encrypted: i=1; AHgh+RqKi3edVDBU8zfVenh3jiG/c32KK6D1gFZJYUyFruH3vrwIH+OMyjFgukqoh+70sQk3iG1bLBl27eo10Wk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzb4He5q6visBlgfgo2Xi2sl0clLVdprxbk92/EILUU1OTUD813 BluZKgBVWx0FXhwTP9/OOzkI0IgniW1BP6O32c4b3i4XkNVj5gXQ5DIW2Mu5Ww== X-Gm-Gg: AR+sD13Lg1lCJcruUDUgpzP5mq/wJjYWjT37IE9MOBveZdnNw7Iug0FgYHjqRD/sN3V 0+vaycbqrk8N8/K1+mMBQciNtrkE4uHxT4oVBp4mYZ0dQYHX59mifJN3S8GrFuf6u/FGo5b+fwi 4XdRWdlrBcRRR85cb2Zcqtp9iFn84DswTgiPDpsTh9desg8JqAICEkz8wIXkdfZFfnRx6xOGijh hQ8ji4TXsyij1fVdWGwPfmvi8raK//HfYzTkjhdJ6EIpnMoa3HQ/0JztlgfPs9NmxzqQBCTUO9t Y5VMozo0isVZzc8sM/Ql7h3iz+wgTCoHqwHMKJt7L7V1q5xI0U/gKlkb3BhGbtERCQbGNDlqrpF jSx1UC620kTj5Tlj0LFPHOoUlGwKiZMjYivVE9jQp0i8d68hsGlz9AHqIqs6xtWc3sSlkdZi5mD L67toWs1glxxf36llvKNHrp7Dg+NsPNnC88CQSuBd/e4uma8mKDpZ+odhflp/fiQ7eO7QVngagb ruh X-Received: by 2002:a17:903:32c9:b0:2c4:397:dd7a with SMTP id d9443c01a7336-2d0caa4978fmr344731335ad.4.1786411047625; Mon, 10 Aug 2026 18:17:27 -0700 (PDT) Received: from nixos.taile51c2e.ts.net ([122.161.243.22]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be8a706fsm46935750eec.8.2026.08.10.18.17.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 18:17:27 -0700 (PDT) From: "Sidharth (Siddhi) Sharma" To: Sakari Ailus , Greg Kroah-Hartman Cc: Bingbu Cao , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, "Sidharth (Siddhi) Sharma" Subject: [PATCH] media: staging/ipu7: return 0 for IPC messages that expect no response Date: Tue, 11 Aug 2026 06:47:18 +0530 Message-ID: <20260811011718.274510-1-wednisegit@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ipu_buttress_ipc_send_msg() sends a command to the CSE and waits for the send_complete completion, which the interrupt handler raises once the CSE has executed the command. When a message does not ask for a response, that completion is the whole story: the command went through, and the caller should be told it succeeded. The no-response path does the opposite. Right after the command completes successfully it returns -EIO, turning a good send into an error. The IPU6 driver this code was derived from gets it right, since there the no-response case simply moves on to the next message. This looks like a slip made when the bulk loop was collapsed into a single-message helper. Every caller today passes require_resp = true, so nothing is broken in practice yet, but the return value is wrong and will trip up the first no-response command that comes along. Return 0 instead. Fixes: b7fe4c0019b1 ("media: staging/ipu7: add Intel IPU7 PCI device driver") Signed-off-by: Sidharth (Siddhi) Sharma --- drivers/staging/media/ipu7/ipu7-buttress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/ipu7/ipu7-buttress.c b/drivers/staging/media/ipu7/ipu7-buttress.c index 40c6c8473..8b57c7c1a 100644 --- a/drivers/staging/media/ipu7/ipu7-buttress.c +++ b/drivers/staging/media/ipu7/ipu7-buttress.c @@ -265,7 +265,7 @@ static int ipu_buttress_ipc_send_msg(struct ipu7_device *isp, } if (!msg->require_resp) { - ret = -EIO; + ret = 0; goto out; } -- 2.55.0