mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiaxing Hu <gahing@gahingwoo.com>
To: chaoyi.chen@rock-chips.com, royalnet026@gmail.com,
	heiko@sntech.de, tomeu@tomeuvizoso.net, robin.murphy@arm.com,
	diederik@cknow-tech.com
Cc: alchark@flipper.net, linux-rockchip@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Jiaxing Hu <gahing@gahingwoo.com>
Subject: Re: [RFC PATCH v6 7/9] accel/rocket: add RK3576 NPU (RKNN) support
Date: Tue, 11 Aug 2026 14:08:07 +1200	[thread overview]
Message-ID: <20260811020807.1605238-1-gahing@gahingwoo.com> (raw)
In-Reply-To: <4f300b78-d96d-4d98-8819-dc292b0c9b97@rock-chips.com>

Hi Chaoyi,

> I think it should be for every submit. That is, when you set
> task_count_clear, you should also set task_last_layer_clear at the same
> time.

That is what the driver does, and now it does it on purpose rather than by
inheritance. v7 writes

  PC_TASK_CON_TASK_LAST_LAYER_CLEAR |
  PC_TASK_CON_TASK_COUNT_CLEAR |
  PC_TASK_CON_TASK_PP_EN |
  PC_TASK_CON_TASK_NUMBER(n)

per submit, with the three RK3576 bits at 16, 17 and 18 and the RK3588 ones at
12 and 13 beside them.

Thank you for both answers. The layout settles a register this driver had only
been able to reach by comparing traces, and the bit at 18 is one it was setting
without knowing what it was.

Jiaxing

  parent reply	other threads:[~2026-08-11  2:08 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  6:34 [RFC PATCH v6 0/9] accel/rocket: RK3576 NPU (RKNN) enablement Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 1/9] dt-bindings: npu: rockchip: add rockchip,rk3576-rknn-core Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 2/9] dt-bindings: power: rockchip: allow resets in a power domain node Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 3/9] dt-bindings: iommu: rockchip: allow the RK3576 NPU MMU clock set Jiaxing Hu
2026-08-06  9:23   ` Diederik de Haas
2026-08-06  9:55     ` Jiaxing Hu
2026-08-06 11:29       ` Diederik de Haas
2026-08-06  6:34 ` [RFC PATCH v6 4/9] pmdomain/rockchip: add optional per-domain power-on settle delay Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 5/9] pmdomain/rockchip: cycle optional power-domain resets on power-on Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 6/9] accel/rocket: select the per-core clock and reset counts from match data Jiaxing Hu
2026-08-07  8:10   ` Diederik de Haas
2026-08-06  6:34 ` [RFC PATCH v6 7/9] accel/rocket: add RK3576 NPU (RKNN) support Jiaxing Hu
2026-08-07  8:48   ` Diederik de Haas
2026-08-07 12:55     ` Robin Murphy
2026-08-07 13:32       ` Diederik de Haas
2026-08-07 14:24         ` Robin Murphy
2026-08-07 21:16       ` Jiaxing Hu
2026-08-08 12:39         ` Igor Paunovic
2026-08-10 10:47           ` Jiaxing Hu
2026-08-10  1:31         ` Chaoyi Chen
2026-08-10 10:47           ` Jiaxing Hu
2026-08-11  1:08             ` Chaoyi Chen
2026-08-11  2:08           ` Jiaxing Hu [this message]
2026-08-06  6:34 ` [RFC PATCH v6 8/9] arm64: dts: rockchip: rk3576: add NPU (RKNN) nodes Jiaxing Hu
2026-08-06  6:34 ` [RFC PATCH v6 9/9] arm64: dts: rockchip: rk3576-rock-4d: enable NPU Jiaxing Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811020807.1605238-1-gahing@gahingwoo.com \
    --to=gahing@gahingwoo.com \
    --cc=alchark@flipper.net \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=diederik@cknow-tech.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robin.murphy@arm.com \
    --cc=royalnet026@gmail.com \
    --cc=tomeu@tomeuvizoso.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®