From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5676338D401 for ; Tue, 11 Aug 2026 02:52:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416781; cv=none; b=WbRleWwSw4KVyncjUyjdJcYXrEmR34X+QdqieYQi23WIwplkxsWNngb8gcN+VMYxo8xc12n/7Dnombwy9X1/EM43SoO5R8LzMLQa9UFHJUoLCYdqTlUv7ZToTNhh0QCQhYNTDUMV9rrBF5/rj/AQgPxP38Wb0aHUA/my1TBBW2U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786416781; c=relaxed/simple; bh=mfJ7PcOBwsnB6aSIscE9ZAxiaKATiOnevE9RU8JcccY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=fUfMyhBAHmEekOXnIaUn2yI/niT9Vo3NEXPHCd1PxjjWVG48K2vs+zpAg80o/fhox7C7LVHOrv4hDXurmx/tKtywRhswpmhvAbbox9Oai9n4sVJQJNEiYcm2Romj27gO8uWiznrvbF+gTnBexfre1Py7vnt3MhIRCKzxrpYitEg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=surriel.com; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b=JwZAbhVR; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=surriel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=surriel.com header.i=@surriel.com header.b="JwZAbhVR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=surriel.com ; s=mail; h=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5WGoRZehvZShX8ntlBWBCd1g1DPrfcbm3SKIWuxii1M=; b=JwZAbhVR3ay33saSROg6T4Ppwb 25v0RbqOWQ1fh9DD+Qun9DwVwfJw0AM5zZDsgi7/zunwBNgPAq56cnWR+ekB98kkO9VsZ7W7oPpzW NPiNauO41x/GDj8amqVOCqknIHkh16v4VSuXymdJMZe9RP8nPe+tJdtIl1wvwL2S+Doe3P9Xlv3Ly sO5dyRUQc+q8QQ1y5VO4Aa2jkq6KYYJf85A60ytF0GJTYrUSj9IoP4WzjFPxJN/4B1l4noBjE9z8S GIvJB9mp8pyC2N0XYEFU+Xm7i57pzrWO2eEAuy3Onqgj0XF3IDRd2tn9FnEfQ0yYFdUQV8lH0eanZ PGUdJviw==; Received: from [96.67.55.146] (helo=fangorn.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1wtcb6-000000007kZ-2JhS; Mon, 10 Aug 2026 22:52:12 -0400 From: Rik van Riel To: linux-kernel@vger.kernel.org Cc: kernel-team@meta.com, Rik van Riel , Andrew Morton , David Hildenbrand , Jason Gunthorpe , John Hubbard , Peter Xu , linux-mm@kvack.org Subject: [RFC PATCH v3 1/8] mm/gup: break out gup_fill_pages() helper Date: Mon, 10 Aug 2026 22:51:50 -0400 Message-ID: <20260811025157.1632867-2-riel@surriel.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811025157.1632867-1-riel@surriel.com> References: <20260811025157.1632867-1-riel@surriel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit __get_user_pages() fills pages[] and flushes each page's caches in an open-coded loop. Move it into a gup_fill_pages() helper, which the follow_page_mask() call chain can then use to fill its own pages[] slots. No functional changes intended. Suggested-by: David Hildenbrand Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Rik van Riel --- mm/gup.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 0692119b7904..7bb40be89529 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -633,6 +633,23 @@ static struct page *no_page_table(struct vm_area_struct *vma, return NULL; } +static void gup_fill_pages(struct vm_area_struct *vma, unsigned long address, + struct page *page, unsigned long nr, struct page **pages) +{ + unsigned long i; + + if (!pages) + return; + + for (i = 0; i < nr; i++) { + struct page *subpage = page + i; + + pages[i] = subpage; + flush_anon_page(vma, subpage, address + i * PAGE_SIZE); + flush_dcache_page(subpage); + } +} + #ifdef CONFIG_PGTABLE_HAS_HUGE_LEAVES /* FOLL_FORCE can write to even unwritable PUDs in COW mappings. */ static inline bool can_follow_write_pud(pud_t pud, struct page *page, @@ -1461,9 +1478,6 @@ static long __get_user_pages(struct mm_struct *mm, page_increm = nr_pages; if (pages) { - struct page *subpage; - unsigned int j; - /* * This must be a large folio (and doesn't need to * be the whole folio; it can be part of it), do @@ -1493,12 +1507,7 @@ static long __get_user_pages(struct mm_struct *mm, } } - for (j = 0; j < page_increm; j++) { - subpage = page + j; - pages[i + j] = subpage; - flush_anon_page(vma, subpage, start + j * PAGE_SIZE); - flush_dcache_page(subpage); - } + gup_fill_pages(vma, start, page, page_increm, pages + i); } i += page_increm; -- 2.55.0