From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 433292EBB84 for ; Tue, 11 Aug 2026 03:47:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786420053; cv=none; b=EsJQ3cwoKiq3GndtiAgcrh6s0jjI2uFqUtpK7Y82R+Wsp2e8ZyqHjUMrqoUYcXaEkax9VkY2fNCgtDM0csxWGdghKhHSShl6dRBsweTdFEB6OAy2bYWJW4Euw1YgEVw+z9FPs51m14aktX0fHaLwSMCwAfvpxxD7ve8b6pUQy1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786420053; c=relaxed/simple; bh=DyKm8VUkzskxpXoICI1bt3LPFqZDrsD2Xa2/Z1K2Msc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=O5+pzthnjHjhoMKE68Cvb6dYfQ8Jtp02dgrOcZjz4CytzZajt/jdzL/kKAKqUWo3D188tGHOaMR3RlBG1Nc0MwYHiTyMl4gGGEYinDiVy/vnY8ExemtPwato1RgsGhNiD3HhHIlYtR57wTWBtw3ieXnfLLsd3mz81HCAgSZZxT8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=i/eJRfMD; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i/eJRfMD" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-84fa3b14ee1so208361b3a.0 for ; Mon, 10 Aug 2026 20:47:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786420051; x=1787024851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fO//i2RtgcRB0nXNuwN1GB8vOhXT0TWv6CJA+FzAN1E=; b=i/eJRfMD1pHWwxenQTFOc5zJQW577h7huRsk3luG72Nu05SMXvPM14JXuwsqGy3MBU +UBVrbftP3IyOV4xOTX5IK1kORzyDbMdlYKJkpl/qDgtuasQ9drJVYOX4fUvh2eQ3ehp DEG9ZwpERZ+YUoSDn61tIpc/JIQgG/tTWDimjNHG9pXkfq5GqeHOCKphBZtjIJU+rnX1 qgLHBZJ2LwYoBVc+3SWD3Kh1wGEH6umXyRgdI0HCW1Ss8aSkoksNx6bdboms7pWPcAc7 ZvvCUfGTTGS5AR7BErhUSuCUQvgf5dM+8spMp8SzL1TUtRUjGiHyeTBFsI5MpZtx4h+W ai+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786420051; x=1787024851; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fO//i2RtgcRB0nXNuwN1GB8vOhXT0TWv6CJA+FzAN1E=; b=oT6ZkdQrCpLxbtNx0w2UBdGCCvrx35YXn42QX4f0GGJm8xHZ9ydOesC/ijZrrcBVLY a8QjgPW/81Kwh2l1tQt9O1pnp5U+eKTBAQXit0eF4BvS0a6+sQA3hLXCpa3WYJRM8sZy otbTaIBtjSqMHABgQP+Clpjt1e95AIC8WU83EBCghCllF+2qq3m9CGyGMaVZUUC46dLb uRnbKBVoANd+/6W8HFKmTvfo7j+Tjmteod5a+/3ZJ3vWo8DiRMsLGmgocE42/fyfsPgE XyImPu8uLMAQDAznmruZHio6ICdlXMZWTrfO4NpjU6I1Fjj7TbTtCJFBOeFSnd3hMZFh enkw== X-Forwarded-Encrypted: i=1; AHgh+Ro5uWLQ1WwAYDr7l0N11xf5h4n9hYTEgJB+AepaQOAkT15T3g0KIRb8TGvJO2PYZmFHyUcWemR0GnLTAxs=@vger.kernel.org X-Gm-Message-State: AOJu0YyRTA4BCHt7gAVAmmVH3r5/qeXoPluf2k39a0gyDBZeVeaQ/Eql gK175RMnsu1LRQFAVp13q1C1AxzKZ3eJR/UuJ1Xh0UJNpJw/zKayOche X-Gm-Gg: AR+sD10h1pTU3HrwpPSwXcdiyGPfnHmVzRYtaN0V/B+i1Qq7ntjjlxb/XapskXgAL2i slAPaJpLmGdzzXMO6tggL08PBSWfv328UJltueIgJ5QwGX2fpXfE6LWsa7X2rAILm/oQJ0n9J1l DxpLreKSMffTZ1pek56/9n99GpWOtdGjc39Y/Fu01V9swpKKqh70RWZG6DCeLrytEENVoxlyJBg /nZyeh2wctYepuIgM50bWfAXnjI6b3is5U8Cyt6w04jvyhTjGoSqQV2I/dKA38l2OQFYBw2mhO4 8cNw2jmNMZUMmfFmL/lK/3M7JaaqTil4eJj3kTwHiXjEZJKmRmEUV95yLGqgkg9MbwY5GPsL36M Hc1lYkx/Zg2APYtEmJQgCxM7iXgDoIrY3qD24OQWVjxI8rGTS/23+4B863HxNJ5Y9YEBEJp2pTI bPwflFesLYw45I3f+6EgVdI7D6xIPjZuTzFLfXCOpZClq7r8iZ9TyLmr2rQM1On/JQeCO3VlVuc MKN+IOZ0snudw39QFH2qVchFIGGWfqdD0W1zZ9j0LdreQo0P41OjPhJbW0DCmsSP3BFpbLkGgMW VVDBXQ== X-Received: by 2002:a05:6a00:90a7:b0:848:3f91:da82 with SMTP id d2e1a72fcca58-84fa8926f7cmr157503b3a.32.1786420051437; Mon, 10 Aug 2026 20:47:31 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a589d7bsm4537514b3a.53.2026.08.10.20.47.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 20:47:31 -0700 (PDT) From: phucduc.bui@gmail.com To: Radhey Shyam Pandey , Andrew Lunn , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Michal Simek Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH] net: xilinx: axienet: Propagate errors from optional IRQ lookup Date: Tue, 11 Aug 2026 10:47:15 +0700 Message-ID: <20260811034715.6034-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available, while other errors should be propagated. Propagate all error codes returned by platform_get_irq_optional() other than -ENXIO. Another call to platform_get_irq_optional() in the same function already handles the return value this way. Apply the same error handling to this call site for consistency. Signed-off-by: bui duc phuc --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index fcf517069d16..7ef099db1bcf 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -2957,12 +2957,16 @@ static int axienet_probe(struct platform_device *pdev) lp->tx_irq = irq_of_parse_and_map(np, 0); of_node_put(np); lp->eth_irq = platform_get_irq_optional(pdev, 0); + if (lp->eth_irq < 0 && lp->eth_irq != -ENXIO) + return lp->eth_irq; } else { /* Check for these resources directly on the Ethernet node. */ lp->dma_regs = devm_platform_get_and_ioremap_resource(pdev, 1, NULL); lp->rx_irq = platform_get_irq(pdev, 1); lp->tx_irq = platform_get_irq(pdev, 0); lp->eth_irq = platform_get_irq_optional(pdev, 2); + if (lp->eth_irq < 0 && lp->eth_irq != -ENXIO) + return lp->eth_irq; } if (IS_ERR(lp->dma_regs)) { dev_err(&pdev->dev, "could not map DMA regs\n"); @@ -3047,7 +3051,7 @@ static int axienet_probe(struct platform_device *pdev) ndev->ethtool_ops = &axienet_ethtool_ops; } /* Check for Ethernet core IRQ (optional) */ - if (lp->eth_irq <= 0) + if (lp->eth_irq < 0) dev_info(&pdev->dev, "Ethernet core IRQ not defined\n"); /* Retrieve the MAC address */ -- 2.43.0