From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6DBFF4C6D for ; Tue, 11 Aug 2026 09:04:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439068; cv=none; b=F9KgHJgDsSNOhnPz8EDSgtP/9g3v9rF4CDma6FCWBj7RwvcK6evo6Dve5wyB7ciT4cOuo6QEgSr/7Iq2adqSKLock18zb7EG9zr4YsHh4KG9NZ5NmAZPZQDUVPhd7D/baha3aVgB/dj8dET4B44KFTlq4MTvN3KnqFuSmWyL2MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786439068; c=relaxed/simple; bh=L433lSGeAgbk6jdO25yBmQ4JQ7OtU3fLPNjeQrpjwIk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ch6lL/H0LhaiWAZkM5WUG+GjJY4tLNgg1v+jaWXgBbWvrgNo8LOXoNP+ckwU9krUS2J+jLiYbgqoEmf96dlvubTcxL0XI81oS6ed/77jBOyALA8LmNRto5mxoD0nOZT4nlk9rUO1eb/NgMt2nhKi/X8CB9Th6Hklz1M2jXlrJ1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=LLkjqkwj; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="LLkjqkwj" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D26621516; Tue, 11 Aug 2026 02:04:22 -0700 (PDT) Received: from localhost (unknown [10.2.196.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 710313F632; Tue, 11 Aug 2026 02:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786439066; bh=L433lSGeAgbk6jdO25yBmQ4JQ7OtU3fLPNjeQrpjwIk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LLkjqkwjoqf/V6guQDEXsYBcoS49lUw7etQMbB98Grd15uTJaUWo6h5tGDIUu+Yq0 lVzvyI2m3d0olRN+IGxlIfaAXVoKG9MwXG74TEJblE6fkqYuegpKZictHst0DQv6IM lXlRlVI6EEvDqcpBOnrIp4J1eSw6jwp14zol4PIk= Date: Tue, 11 Aug 2026 10:04:24 +0100 From: Leo Yan To: James Clark Cc: Suzuki K Poulose , Mike Leach , Yeoreum Yun , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] coresight: trbe: Hide enable_sink sysfs file Message-ID: <20260811090424.GD15499@e132581.arm.com> References: <20260807-james-cs-hide-trbe-enable-v2-1-0b2af223feed@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807-james-cs-hide-trbe-enable-v2-1-0b2af223feed@linaro.org> On Fri, Aug 07, 2026 at 11:13:22AM +0100, James Clark wrote: > TRBE doesn't support sysfs mode, but the enable_sink file can still be > successfully written to enable the device, and only attempting to enable > the source would later fail. > > Avoid misleading users by adding a flag that devices can use to hide > either the enable_sink or enable_source files, and set it for TRBE. > > Don't set it for ETE as it's possible that ETE could appear on the > legacy bus and work with sysfs, and writing to enable_source already > reports EINVAL if the device doesn't support sysfs mode. It is a pity that we cannot determine from the ETE registers whether ETE is connected to the legacy bus or TRBE. > Signed-off-by: James Clark Reviewed-by: Leo Yan