From: Nirmoy Das <nirmoyd@nvidia.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Frank Li <Frank.Li@nxp.com>
Cc: Akhil R <akhilrajeev@nvidia.com>, <linux-i3c@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Nirmoy Das <nirmoyd@nvidia.com>
Subject: [RFC PATCH 2/2] i3c: master: Propagate SETAASA early device-add failures
Date: Tue, 11 Aug 2026 03:38:11 -0700 [thread overview]
Message-ID: <20260811103811.3380073-2-nirmoyd@nvidia.com> (raw)
In-Reply-To: <20260811103811.3380073-1-nirmoyd@nvidia.com>
i3c_master_bus_init() ignores errors from
i3c_master_early_i3c_dev_add(). This is recoverable for SETDASA devices
because they can be discovered later through ENTDAA.
SETAASA devices do not participate in ENTDAA. If their early attach or
reattach fails, bus initialization still sends the SETAASA broadcast and
continues without registering the device. The target may consequently
have an active address without a corresponding I3C device.
Abort bus initialization when early device registration fails for a
SETAASA device. Preserve the existing fallback behavior for other static
address methods.
Fixes: bbaf8733b848 ("i3c: master: Add support for devices using SETAASA")
Assisted-by: Codex:gpt-5.6-sol
Signed-off-by: Nirmoy Das <nirmoyd@nvidia.com>
---
drivers/i3c/master.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 922da77cbdf324..7a83f39448e8ed 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -2537,8 +2537,12 @@ static int i3c_master_bus_init(struct i3c_master_controller *master)
* addressable.
*/
- if (i3cboardinfo->static_addr)
- i3c_master_early_i3c_dev_add(master, i3cboardinfo);
+ if (i3cboardinfo->static_addr) {
+ ret = i3c_master_early_i3c_dev_add(master, i3cboardinfo);
+ if (ret && (i3cboardinfo->static_addr_method &
+ I3C_ADDR_METHOD_SETAASA))
+ goto err_rstdaa;
+ }
}
/*
--
2.43.0
prev parent reply other threads:[~2026-08-11 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 10:38 [RFC PATCH 1/2] i3c: master: Emit firmware modalias for SETAASA devices Nirmoy Das
2026-08-11 10:38 ` Nirmoy Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811103811.3380073-2-nirmoyd@nvidia.com \
--to=nirmoyd@nvidia.com \
--cc=Frank.Li@nxp.com \
--cc=akhilrajeev@nvidia.com \
--cc=alexandre.belloni@bootlin.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®