From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A8BB25B088 for ; Tue, 11 Aug 2026 13:18:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786454336; cv=fail; b=UiyrR4Kxe2dA1GH19RWt/yeiM1vwnopSNVm5s5iy/EHPtkl7pCxEP8M8Bxc3w6RpHiChqC4BnXcKLmjr4iTt0RU/epPTrp7FeQ38F1LkGpqkVEBzMKRWyeI2QfIA1KnVc0gOnYCg3xp96jSTEh+g3hGayX0s2W7qkjQ0onUKtKM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786454336; c=relaxed/simple; bh=t4eJbAfKOBZS+wYMeQKaE2cJOwCZJQ/fgPqTnTIak3Y=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=vF0xSy6+vQfSNZ2JjhDjnN2jFvaZwlwW4Vo5fz1ykembKeis9GEppY+26ZGLhkO1u+TLRLAVgUg1YeKCcNiZjn+Tezi8fMMMC3MAFNaG0cF6tHfy0KohxEJCQgx50mhE5FA6r40hpNr5gJK/qmr+wodBZl/pKHJ3VWx+oswPYg8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=qDK/XetT; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=FPqQCPI5; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="qDK/XetT"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="FPqQCPI5" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67BDHs1K1536135; Tue, 11 Aug 2026 08:18:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=PODMain02222019; bh=oDjfPR1s3QnnX91X RFhJltqcTvvfJg8FSNdF6bH7UqA=; b=qDK/XetTLO7ia8dzyNtk/EWBJq5ZdJiv 3wuVVNVuzKg9nuRRZN4flRLMr2YThqbmuvB3zkStYCUJyXW3ZMvjECH7OwoscNiE 9lKluQ5zdl8nOd8HupIUaAD2bOZ34kdn2lwd1KxtvlWhb5CgJb3KUlbmEVNeIJgE rti6z4zZDSpU2ivZ78JPhOmQJcEIWCgupPE6xtG+ZgkpoWP5ddfkChEcbeS7UYYX aYm7lkjWfkg3eR2YndAf3h8mkjDhxiCvQ80C3wrIxmfJJWcyLN1foErSq94euClF YD/k6AvekU48PvQWyEj7oZStKx/hbh/cs/Mue+tdxWXkhLB546nL3w== Received: from sa9pr02cu001.outbound.protection.outlook.com (mail-southcentralusazon11023123.outbound.protection.outlook.com [40.93.196.123]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4fx1v0w33p-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 11 Aug 2026 08:18:27 -0500 (CDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZzRnTuKuSk5nivuc0QKAvNFAVA0Wibbgscgns10o54gUj3Yg2AkDft4/MIrjFpoqtU3PRudRsq0AhFsjcB6BsaoDIsGcIlSBJ5RFRlSNK6USFlZjnJSPpK2XbnJfnnjEfZuMya6Oh3LRbqnhNX+W+pX+UQ1XIqgcqCp+3Fjj+etK0ZZ3yVoesZ3ioQce8UtKVO3cfOUhEyDBzXVAw/YR+0NJ8gr3iQ0SG36wgZjUwVFGd5e0aZmbqDS7zvLuT4BwRsBG0Pgo8APk7+znkMWuuEugU8jtWYCkX+EX6jpVB+jQWF1NhAypaPJaT6qrRUiE16Jfau/oc+KCP8dyH3EkBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oDjfPR1s3QnnX91XRFhJltqcTvvfJg8FSNdF6bH7UqA=; b=W4QdJzrSkURhufXrTjdxpCkFNooVOhG59VnzkB/zHDQkhf6oeStMKowDyUPNrlvJWdbFhodDSxec06uauLPPRcI6Yf7RM17vFSeI+djTQar6QnFRzT/zXNpBkS5F3icDq5ryn8u2pwQGIFB3ssaZP5OyJXPQ/EGU+sptwV2XUaUTUKu/47lxCzlyfdGHsXe2T2Yi4xYCgEzeIiVuPtTqpB44jT+c3TJBl6ht6WAghdfM1a8sD3BZzD6BnlGVXRInMGXYyEGUrauPW9pBGB64n4y6K7HLxX5mwCZgH7JyODNV7A22a9fxEhG2eto7uwwXZ1kDZBirmu1BqLQYmk/sTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=softfail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oDjfPR1s3QnnX91XRFhJltqcTvvfJg8FSNdF6bH7UqA=; b=FPqQCPI5K3SlgiSF9ZTk+NUVqhdq//zCDX44Kp4BDqYT7x0gqPC7mEALyM4zSkkTfhttFNF0qAe24AzhjS7ZcCCguGvHxhBg1tcPTUDA3A/p+U8S7HXiHdQJNt9olTQOXAA6X77C6Ce2TcT1rsoYCDYJkKL17W7P0yijAnkQsus= Received: from IA4P221CA0007.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:559::17) by LV3PR19MB8805.namprd19.prod.outlook.com (2603:10b6:408:26a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.292.25; Tue, 11 Aug 2026 13:18:21 +0000 Received: from BL02EPF0001A104.namprd05.prod.outlook.com (2603:10b6:208:559:cafe::91) by IA4P221CA0007.outlook.office365.com (2603:10b6:208:559::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.12 via Frontend Transport; Tue, 11 Aug 2026 13:18:21 +0000 X-MS-Exchange-Authentication-Results: spf=softfail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning opensource.cirrus.com discourages use of 84.19.233.75 as permitted sender) Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL02EPF0001A104.mail.protection.outlook.com (10.167.241.135) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.315.6 via Frontend Transport; Tue, 11 Aug 2026 13:18:21 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id 62DB3406544; Tue, 11 Aug 2026 13:18:20 +0000 (UTC) Received: from ediswws07.ad.cirrus.com (ediswws07.ad.cirrus.com [198.90.208.12]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id 496E982025A; Tue, 11 Aug 2026 13:18:20 +0000 (UTC) From: Charles Keepax To: broonie@kernel.org Cc: pierre-louis.bossart@linux.dev, wiza@saarinenkoti.fi, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com Subject: [PATCH] regmap: sdw-mbq: Fix swap of timeout and retry times Date: Tue, 11 Aug 2026 14:18:16 +0100 Message-ID: <20260811131816.332082-1-ckeepax@opensource.cirrus.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A104:EE_|LV3PR19MB8805:EE_ Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: 9cef5132-5d89-42d8-7fde-08def7ab0429 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|61400799027|23010399003|82310400026|376014|10067099003|56012099006|11063799006|16102099003|18002099003; X-Microsoft-Antispam-Message-Info: 8sDxrwKc8F6UIunBLIq3HbxuqCtCEdbF7sqzhznTcfzMu1mp0g7cr0znfMfSg4B8TFsVNLeeQ8A7dhsbueVP2kkS3o7IPtGVfJfcI9krL5EttACkERCQfgZ9a3GIjBbTUVrT7a9X6vyX7/fBu0mRefuPqXHVOVrAqj4tA04YuIFMaVF9mplse0IR/DninKTLynh/QDVkQkmHfzoMD/FFSj4c3io+twvQujgMeZpAWCVI1uCq+ExsKBm8KAR2aZIwWXFy0VJX4/hp4KjF5CMmWq/ehf0ddxGw3zF9E8IIO7gi6Zbc1bEfD/kB+PewWzAbVp+1t88bXN7TMA3UpUdP+nEz610VXxtORrMPeOEb6aL0bvZIniPI7utVMUFsKao/LgNmDdiv0GZQxIlTvXxQ6AW3huuEt9y4lPKk7Jmv8OnDQILeiKIpkRKDxW/tEk3aQNz+oigvnrUNi8kZ+M/NlXWLS4RaU/c92cKTvCrIvQ1kS/RMrupWOWnUCicJD5uUkd+qjBozmYjA85oDD0UHyl4XOn2SSZGsgq52qWiED24B113bTmk1LDo9s3/cgXsHRFOLSxUObJD3Dt/SgmMiYUOdP5OeKc9NtQB0f8d4ozBIq8b6ee1P1I6/bxW9Dn8Eq42gWD3MPtmA/Dt0GuAkL3mEVqMGc8CVtdYJTmgZl68= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700016)(61400799027)(23010399003)(82310400026)(376014)(10067099003)(56012099006)(11063799006)(16102099003)(18002099003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1FpddbalLRRfjDicRjpJP6ZPJBco3kZAuRWt7kYFO8QnakZiBa6Wf5N42DgHexHupa5psBSAdjrTyms+/S3B9gVzv+9id31PAG0oj/WdsKJFp7VGrNudgYNZTaFqXPHHz98OHvBvuZOMT8OGfubi3hAfmo6agnyAJNZ1y+4iVq8dOPguKUU1S0IrYfYGHgod3hWr0WRYo3blsAzM4fmZoWf/gEUnbI/dKwiWPJRDhjpMGD/OhikVHc0oe90oTYDxfpOURhQBXUbFiVKZ241JZ7h7GtSGXJzoC/OQqtHdyPwCxz1kuj9IC9Ah1xFc6XycNjxojba3CYaUXWiTVzujXvPXAvnLdWOTgl+yeY+u0lJUgYak9Qv4yMXTGu0hFyEtb11tPaPmzD8WeyE+zDquECrD9xPKaY2W2zuiEDMGmrcNbCmyeA1ZGSzXNWSq9fIc X-Exchange-RoutingPolicyChecked: QPfb3+R1xsoni/RutSt45rP9CgKBkhClkewD1N/wPZDO45NeECQ1kx4y+/4p8RpphCepkX3F+pYV8pvLaEoGizpeGOPRlJdXlNpvhHY4RhoH+7nsImYxAvIuEyvB+s0N+2P16e/hqKS62XDnM+SknuIrEhvseM0j801ag7rjTtSmq4slXHeTpLTaNp+dGsc9J/FtKg8fHu0MOOnEHLYG54NLYTx/We22n/NuHd8hkaQcoZy1ELmX7azF7j2xkXL34CsqlhGtiiw0ahleGKmnwO9/fD3d1rgiRRBfN7nGkeOZkhmhMdAEZbBnA4feBqQACxu8Z2zyY1wM4lziWamXfA== X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Aug 2026 13:18:21.2423 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9cef5132-5d89-42d8-7fde-08def7ab0429 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL02EPF0001A104.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV3PR19MB8805 X-Proofpoint-Spam-Info: AW1haW4tMjYwODExMDExMCBTYWx0ZWRfX1awRuFIhC3NA rnEMG7cvHhXtrLTmiRrHUiVCBBWQBrjqC+vq7MsOBv7qeE9lMRhFPJLNpzizjo3iE1DFqBMtpax Mx0aRcJFpgCbPOCuzM9QhSqITnwXN8U= X-Proofpoint-ORIG-GUID: 875joD--COsL1CAF8XPTux_BHdPZxPk3 X-Proofpoint-GUID: 875joD--COsL1CAF8XPTux_BHdPZxPk3 X-Authority-Analysis: v=2.4 cv=ZMrnX37b c=1 sm=1 tr=0 ts=6a7b2123 cx=c_pps a=3JIx0no49nfI/nrzBlLv0w==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=Sv0fKeRqtYgA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=iX4cTi3TZMoOKdANLEfx:22 a=Dj2-6B8FqX4mGL0U3gbX:22 a=VwQbUJbxAAAA:8 a=w1d2syhTAAAA:8 a=oP09rwdbUtG95NdwZUMA:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODExMDExMCBTYWx0ZWRfXzbE3zKlEmCs3 f5LhEtACUuv54Rli9SikAFaubY95YV5z6zJfjCOUdF1w1z2YO0RnhbzfHfsMcClPF9QlldMw1dW 25e28Q4QdheoBKP2kZgGwbkSxX7m3gm0fZ+FCwtbzgvB16FMx68PXL5BXoY6JWb6bpSOAJH5gcp JP7mBhSThM/jjUy3x+jS5Yckm0EQeH9Q6MUUoc1qpGyTjswgm4NxiBh2tVrNNX+i3YizBivs6B0 m2wr9bZ8yjMsEsJHBi7zYNGzUpeb/Urox9RJJ1SHj/ngQmlQtY3l3Q1AKxG99jjBRv74f6YSpwU FyqSenKbery0oEc32HKjyI2MIFEbMyy8JAa1gZCZFSLEPVIfC+ldwmmYA/JNX0MdF3yEN7c55zD 7LdI06/MxLGUKfWyNMxgQEco56d2syNCZc/TwpYeCgiA2bRDq2lgrWR2pFsvhsh2JXRm0ezhiTP PuWjIchaNDuznRBuWkw== X-Proofpoint-Spam-Reason: safe When polling Function Busy using read_poll_timeout() the total timeout and retry delay arguments are swapped. This leads to only a single retry being processed, it seems the existing users typically do succeed before the first retry. Swap the arguments over to ensure the correct polling time. Reported-by: Ville Saarinen Link: https://lore.kernel.org/linux-sound/ansTPGgVNoDJlA5r@opensource.cirrus.com/T/#m680731a2f307f1f5176b27ed5aa560ddc94e5d62 Fixes: 5bc493bf0c37 ("regmap: sdw-mbq: Add support for SDCA deferred controls") Signed-off-by: Charles Keepax --- drivers/base/regmap/regmap-sdw-mbq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/regmap/regmap-sdw-mbq.c b/drivers/base/regmap/regmap-sdw-mbq.c index 2585933d4946b..6d7c760cbef2b 100644 --- a/drivers/base/regmap/regmap-sdw-mbq.c +++ b/drivers/base/regmap/regmap-sdw-mbq.c @@ -59,7 +59,7 @@ static int regmap_sdw_mbq_poll_busy(struct sdw_slave *slave, unsigned int reg, if (ctx->readable_reg(dev, reg)) { ret = read_poll_timeout(sdw_read_no_pm, val, val < 0 || !(val & SDCA_CTL_ENTITY_0_FUNCTION_BUSY), - ctx->cfg.timeout_us, ctx->cfg.retry_us, + ctx->cfg.retry_us, ctx->cfg.timeout_us, false, slave, reg); if (val < 0) return val; -- 2.47.3