From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E63DA394785 for ; Tue, 11 Aug 2026 15:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786461062; cv=none; b=LFkreyaY5RWbiM+xSSzkkwjPzBf6V05vpXnDkNkUONId22TINXO0/p3yqAyIxkM3OPvGprq5uNYcSoD4F1UOPF91coOIiOM8giKvemwzfIjdNQLDds+bccLW/YrjQouLgvt/MH1JaiAT8FebHwx63g/iCdJ3XYnohWWthbY0DgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786461062; c=relaxed/simple; bh=8d5yVoAb9XmO6nXvBOeBLHAkN1VDedVlxO+0f8K+PZk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=i4PotYOcDloPmDYeXe6OIDRl/pH/uHIZaJQ/4TAzZoWIJSiPHbPBiWib9zhcslXyo+Yr+pUnJ0KvzyQ1ThNqWDaSVEziBdyR6I0UlruAeVsaCN0+yIrnqOgGpike1Whe88ufGix0G6dDZM2Qxb2635BsCdwie6fpt1ofTsM3EL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cx44Q10r; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cx44Q10r" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4954df200ddso22122545e9.0 for ; Tue, 11 Aug 2026 08:10:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786461056; x=1787065856; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FqY4BGNrVrEdqqs5mL1dMpbRJH5xMB3zokQi0/ffwZ8=; b=cx44Q10rOucsNiydACSsfpmzZysdUyJhUMS3m2j+elO73Uga2FB1TXJw8Pk+I9joJo J8lz0xYQZv0krj7jedYbvD6d8KBm4l3soCblTgiKGIW1Cx7PwY7nL305UVsGGcwoD3U4 06Mo2HpT/l8PzL5/hZDoygL4wfyIPxzyH+3nAPEvkyFV5wpQF/GQN6j0+/G2to1/C3Vs CNnfnTfKBIYs8xr+D121F1s0fCcJbcOSubv1dkJ22opCGdjNLPTZNxHZcMO+P/8hnFjq 4Ppa8BXW7585datHedaigXeVFuTp8Rcoq5WDGxApwboRWjyVLdi2QIlvUTeQpNkJUt/w W35g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786461056; x=1787065856; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FqY4BGNrVrEdqqs5mL1dMpbRJH5xMB3zokQi0/ffwZ8=; b=GEloC7IoYiO6Mfo3ArmhBMiyMrprZhzdk6er528SyGCOebc/mWKHbzqkrAjCxb90ag D5PQPPOmEM+d3wfUINNzeRP9wGmCFJo8AkvqYoKIQqJpBxXWyc6NSFMFIQu09D8Iv2SI 80JshKWgXp9/HM+S7Nf9DS1mxWkfODqZfgTeP8VPRgm5Nv0T+WrigZS/f37fyeuZ0rG0 Q3y9nAC7HyAotnRbgwdMZU5eaXTUTua1+1++3EiJGlGAlI9bJjg5n4clSWSmeqnwsmUm xMosScqEQxi9vEnUKU0G1cAYO52rEUxPXOn/eE9yO9fSrFY8oBRJ/TQS7BS8fEu/1Izf Na2g== X-Forwarded-Encrypted: i=1; AHgh+Rr2pl/kVOdXy/co3qABvFeD/lsmD1q17xzDvqdLd0Ilf6UqKWouhRBjcSS3/IGQH1xonK2zzk1JNTa+w+U=@vger.kernel.org X-Gm-Message-State: AOJu0YwgleIiHPIAopDLs/iSxQi+/ysIX8B4T97FZsqTLtsm+eSliWuh QDtpcm4ZFiK/lO0v9QBmdbi1xtexCOuGarzqznisGzpYtkd00tosBubD X-Gm-Gg: AR+sD11nKrCUvUdKngd/3o6TBirnJzbpQEen1P0hBy1/WFPY8UZHkygOfT/hxOLt1Nt rodJzWumahBz3H4LWu5OOs5/wBmQ6qNPcvICDkIjgoVphmKms30nVNFNDyMma0mpM3r9Pdn8Kic mRQUYU17YtvlKNtwg2GaA7yRm0NT08p9TgvVoJZxaBWlasRomhZ5IOnYZFX2LOlN59hzdLp+5Dc nw2rmfqu3ILfYKw7pPE8Uj3tQ5O1pypD9h+H6+v8YcCwB6fzXgku7woU9qhXGUKi+M9ktEHJLey +uHLwM4R7Kw/q3iIp5LSHHNvV0NZRC1ilRcJ/ymg8VEpvF+nClpq3YPu0usd6I7PvJ2AOZJyWEo QOYsHDWdVESiDjIZieYwb71WDZ1F/QdBOBA8xk6Acbb9AwLYawyC8s6OEdMEIiHB/oKCP22yXPr xtaQyVF3HnwuE+vBoHkokPTQ4dG8ZJ3PKowetp7/bIr3f2V2iQN3u+6/VF4uV9GktValCo5tNwG p3KR3XWfRT5W2GnFnwfY/8oFA2ANVQn68E= X-Received: by 2002:a05:600c:154c:b0:499:79b9:e226 with SMTP id 5b1f17b1804b1-49979b9e359mr30314355e9.0.1786461056011; Tue, 11 Aug 2026 08:10:56 -0700 (PDT) Received: from osama.. ([2a02:908:185:7e40:b0cf:778:ae86:13b1]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49977e57785sm54307265e9.2.2026.08.11.08.10.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 08:10:55 -0700 (PDT) From: Osama Abdelkader To: Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH 5/6] drm/panel: Use devm_mipi_dsi_attach in display vendor panels Date: Tue, 11 Aug 2026 17:09:49 +0200 Message-ID: <20260811151000.75038-6-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260811151000.75038-1-osama.abdelkader@gmail.com> References: <20260811151000.75038-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the managed MIPI DSI attach helper in JDI, Sharp, Sony, Visionox and Leadtek panel drivers and drop the corresponding manual detach calls from remove paths. --- drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 8 +------- drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 8 +------- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 +------- drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 8 +------- drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 7 +------ drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c | 8 +------- drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 8 +------- drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c | 8 +------- drivers/gpu/drm/panel/panel-visionox-r66451.c | 8 +------- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 4 +--- 10 files changed, 10 insertions(+), 65 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c index cbe354b51bce..ce299160d3ab 100644 --- a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c +++ b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c @@ -202,7 +202,7 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); return ret; @@ -214,12 +214,6 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi) static void jdi_fhd_r63452_remove(struct mipi_dsi_device *dsi) { struct jdi_fhd_r63452 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index 01bd748aecec..d9cba45eb729 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -380,7 +380,7 @@ static int jdi_panel_probe(struct mipi_dsi_device *dsi) if (ret < 0) return ret; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { jdi_panel_del(jdi); return ret; @@ -392,12 +392,6 @@ static int jdi_panel_probe(struct mipi_dsi_device *dsi) static void jdi_panel_remove(struct mipi_dsi_device *dsi) { struct jdi_panel *jdi = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", - ret); jdi_panel_del(jdi); } diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index 0856df5a6ee2..b660d7055810 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -585,7 +585,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "mipi_dsi_attach failed: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -598,12 +598,6 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi) static void ltk050h3146w_remove(struct mipi_dsi_device *dsi) { struct ltk050h3146w *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c index 7f19fd5b8060..6ec6f81877aa 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c @@ -651,7 +651,7 @@ static int ltk500hd1829_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "mipi_dsi_attach failed: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -664,12 +664,6 @@ static int ltk500hd1829_probe(struct mipi_dsi_device *dsi) static void ltk500hd1829_remove(struct mipi_dsi_device *dsi) { struct ltk500hd1829 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c index 989b030ea22d..11615551e8a6 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c @@ -244,7 +244,7 @@ static int sharp_nt_panel_probe(struct mipi_dsi_device *dsi) if (ret < 0) return ret; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { sharp_nt_panel_del(sharp_nt); return ret; @@ -256,11 +256,6 @@ static int sharp_nt_panel_probe(struct mipi_dsi_device *dsi) static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi) { struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); sharp_nt_panel_del(sharp_nt); } diff --git a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c index 0456f3d705e7..236d45121a44 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c @@ -235,7 +235,7 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -248,12 +248,6 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi) static void sharp_ls060_remove(struct mipi_dsi_device *dsi) { struct sharp_ls060 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c index a14c86c60d19..08e4adf9e0f0 100644 --- a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c +++ b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c @@ -216,7 +216,7 @@ static int sony_td4353_jdi_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -229,12 +229,6 @@ static int sony_td4353_jdi_probe(struct mipi_dsi_device *dsi) static void sony_td4353_jdi_remove(struct mipi_dsi_device *dsi) { struct sony_td4353_jdi *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c index 216a6ad8696e..5ce8b1cdf024 100644 --- a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c +++ b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c @@ -474,7 +474,7 @@ static int truly_nt35521_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -487,12 +487,6 @@ static int truly_nt35521_probe(struct mipi_dsi_device *dsi) static void truly_nt35521_remove(struct mipi_dsi_device *dsi) { struct truly_nt35521 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-visionox-r66451.c b/drivers/gpu/drm/panel/panel-visionox-r66451.c index 690cccedd438..40bbc3ea6958 100644 --- a/drivers/gpu/drm/panel/panel-visionox-r66451.c +++ b/drivers/gpu/drm/panel/panel-visionox-r66451.c @@ -306,7 +306,7 @@ static int visionox_r66451_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -318,12 +318,6 @@ static int visionox_r66451_probe(struct mipi_dsi_device *dsi) static void visionox_r66451_remove(struct mipi_dsi_device *dsi) { struct visionox_r66451 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c index 50f8a84537ca..7a60b1d436df 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -388,7 +388,7 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "dsi attach failed ret = %d\n", ret); goto err_dsi_attach; @@ -404,8 +404,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) static void visionox_rm69299_remove(struct mipi_dsi_device *dsi) { struct visionox_rm69299 *ctx = mipi_dsi_get_drvdata(dsi); - - mipi_dsi_detach(ctx->dsi); drm_panel_remove(&ctx->panel); } -- 2.43.0