From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B780E3B5302 for ; Tue, 11 Aug 2026 15:41:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462890; cv=none; b=dlMYGuUP0aEQ97chdQkufsTrwbzhV/Oi8AIvzIqR3/u7wKtLSGxOTnV3vc4SPwml7/4eXdx+7EE2ZIBuqOJ/PZYfXfyJyuRFC+EcWtRS3nM+pYkyS+T1DZmjC53CsjV5AQFWwA4+QjMmWB/0wzcHai1Dg8iryZTk46nfShoRaWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462890; c=relaxed/simple; bh=/V1r6QXOL+eNTn/p3qGEcfXKl0uwiefVorjHNpHVPeI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=lVG4LgAAwVgXy1S2aqv8d35FcANmF18zZcfMfU4OXBiOR/AFPOpYVOsPNf4L3LzZoA81wSFU+MiXZRzSGnoREme5NBa2pPQbg+cUuC/4/msRuJf9Y6fGWnqLVNJhYQn2YO9rG2zUc5mngL+A6AjZZ2fOldKdOV3NSM8ubkeqpxs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bTffQ3j2; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bTffQ3j2" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-4980fe6b3beso9276965e9.0 for ; Tue, 11 Aug 2026 08:41:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786462887; x=1787067687; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=HYWQ6l3VVM6j4JRhvg6XxcplbTfEh60ar/rx0eHl1vY=; b=bTffQ3j2f3Jmr39taCD6XCE+/q8snZQrfMKwA/qsHltmeQ5ul2mR5SyUeO6oeYTkYY TLElnNAxqylbCh6shM5sQfIaGuBtoqKGWVEb/yO+H6VY8Lv9GDTyl61dIF7CcEH56XA8 Jw+HsCJR2sD8h92tImg+tER06NwBVjDvbqIdC/ItKt49XZkPW6ryj478dvD9IOCeOofe 4d1uGAMQjwtHxurawlABjS06NTi+riH6i+XYrni2PZxxFp1qBbM2uQwQ8qJaWD+ESP0h AYy3zBDNCJnbsk9IGUSiKCueOjUOlOVtAy03BZA6d9Aa9feI4xxM2PnEJoY3dZs9kiBF 0siQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786462887; x=1787067687; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=HYWQ6l3VVM6j4JRhvg6XxcplbTfEh60ar/rx0eHl1vY=; b=pSHmKJSM7ZvjF7M82cGEaSrWDDYzs7BYZhYBaOiDEPR0uq2VdwQY2v6nkH2OPlvRWD bv+6gv35HBCVCHH/fpEw/gBJ3R0KG+4Xv4yIYK/TLGTbcR1bSYD0kMIGyG5PQw7/pVbH itaM9PR/33fQR9L3rNm7+BHFb8HHw0bCGjpPQhuDQxa71MVDDwlVf61+f6LVAZk87xpr DvmbxRp9xS9Wt8raRqYJ6L/k7fCigMYXD2LTRBgsE5khk7GZa1y5/zJCtFxkq76Balvf kg+zN2dEg9pl595Z3hhMLNVKUU9X0G82DpAplZ8YvDUoiDhIm8MBEP6BBpCLM39gESGQ 1APA== X-Forwarded-Encrypted: i=1; AHgh+Rr+P7iw+ewfXRlbL+XRM8KZdOtpbocFmNHTVcFy00+tOX8Jihu8RWR5P3Jf2TCm/wjePh2LNJs/3XVRAsY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3IR2xTPBdDfxdRA8l/xNfYQVglaHhWVkWC6rGYKY73emKmzt8 diV5vcn3Lt7iAmgKJxxHCOLknZVYQ6PnXVMHDI2DCwCX7V2Ge54cV7nU X-Gm-Gg: AR+sD10QS/thRzrJ2m03F1LzXBPJQCCnY/8WN5vFBRTab1132EzK211+aD92+4GBQ7R eSwFy6ip9ZG+Dez6Wyequ/dsZEMGbFEoOlIOyLY4/YgG0gJQxbeAyqyx90lEhFk3gzJXXhKu/Fn ZL8VtPvbtSEJOWNEvhJb1lyu28sHOaXDQ796BufjAI/HrhpPEVX35n6DPlxO18RXIjc/xFY5rxO lvCKClgDPwEucC7QAYUUoGChuUZtOelNVqEGAa0KlsuBMNrcTzv0KFHjUyxU9j8+/VAiElOM57S 3fLRUmyllfniKTLLNypyOYcZ3E1GG52qLUyqOjcXDn4n568fRKZBwRZHWYwx8EgvdAAhPLHnFYK s5t17TXmMFxCYVCjFCQdxRye4QmRmhekY+ibvuGnnef0v8A8ttn4eUm81V0XANqJo0aCUgua4vQ 9Pcg6DA4T7OzjNeKnk+h+rDBGuwxp+32faYBC496riEKS6YEdbOTWYqpSCPxo25TBHxmQvP0YZn L546Ijpt46AwOEN1+TH0wM720fUwUwQXJi6+cH8xzGyHgRCQ/UQNvbqx/FgaTOwWg7M9o+P85Km TaKYU/L/flV/LW3/8iFfOh8/r0RTb/bOBFTYeCHHAvqYsiqBbjV8bZMJSY/tGEcfUvOs X-Received: by 2002:a05:600c:6a09:b0:493:f783:c46a with SMTP id 5b1f17b1804b1-4997a70a41cmr9098195e9.6.1786462886886; Tue, 11 Aug 2026 08:41:26 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a133-e401-bc8e-d36c-2d08-c5e0.310.pool.telefonica.de. [2a02:3100:a133:e401:bc8e:d36c:2d08:c5e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997aaa7aabsm1670275e9.7.2026.08.11.08.41.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Aug 2026 08:41:26 -0700 (PDT) From: Karl Mehltretter To: Andrew Morton Cc: Karl Mehltretter , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Bradley Morgan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Sebastian Andrzej Siewior , Clark Williams , linux-rt-devel@lists.linux.dev, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/6] hrtimer: Pause KCOV during deferred rearm Date: Tue, 11 Aug 2026 17:41:08 +0200 Message-Id: <20260811154111.64669-4-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260811154111.64669-1-kmehltretter@gmail.com> References: <20260811154111.64669-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Deferred hrtimer rearm can run after HARDIRQ_OFFSET is dropped. in_task() is then true, so KCOV attributes the instrumented timer-reprogramming subtree to current. With CONFIG_KCOV_SELFTEST added to x86_64 defconfig, the interrupt selftest fails under QEMU, detecting spurious coverage in __hrtimer_rearm_deferred(). The same happens on s390, RISC-V and LoongArch, which also enable HRTIMER_REARM_DEFERRED. Excluding the involved files instead would cost their coverage on real task-context paths, e.g. the hrtimer and timekeeping syscalls. Take the kcov_pause guard in an __always_inline wrapper around __hrtimer_rearm_deferred(). Use it at all call sites, including hrtick_schedule_exit(). Callers that may run with KCOV enabled for current are built without KCOV instrumentation or marked noinstr. HAVE_NOINSTR_HACK covers pre-GCC-12 x86. The other affected architectures restrict KCOV to GCC 12 or Clang through ARCH_WANTS_NO_INSTR. This avoids relying on __no_sanitize_coverage, which is empty before GCC 12. Tested with GCC 8.1 and 15 on x86_64. Fixes: 15dd3a948855 ("hrtimer: Push reprogramming timers into the interrupt return path") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- Notes: v2: - take guard(kcov_pause)() in an inline wrapper - clarify the test configuration and caller instrumentation requirements include/linux/hrtimer_rearm.h | 17 +++++++++++++++-- kernel/sched/core.c | 2 +- 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/include/linux/hrtimer_rearm.h b/include/linux/hrtimer_rearm.h index a6f2e5d5e1c7d..45e47421fa0c7 100644 --- a/include/linux/hrtimer_rearm.h +++ b/include/linux/hrtimer_rearm.h @@ -3,10 +3,22 @@ #define _LINUX_HRTIMER_REARM_H #ifdef CONFIG_HRTIMER_REARM_DEFERRED +#include #include void __hrtimer_rearm_deferred(void); +/* + * KCOV: Pause outside __hrtimer_rearm_deferred() to suppress entry coverage. + * Callers with KCOV enabled for current must be uninstrumented. + */ +static __always_inline void hrtimer_rearm_deferred_kcov_paused(void) +{ + guard(kcov_pause)(); + + __hrtimer_rearm_deferred(); +} + /* * This is purely CPU local, so check the TIF bit first to avoid the overhead of * the atomic test_and_clear_bit() operation for the common case where the bit @@ -38,7 +50,7 @@ hrtimer_rearm_deferred_user_irq(unsigned long *tif_work, const unsigned long tif */ if (unlikely((*tif_work & TIF_REARM_MASK) == _TIF_HRTIMER_REARM)) { clear_thread_flag(TIF_HRTIMER_REARM); - __hrtimer_rearm_deferred(); + hrtimer_rearm_deferred_kcov_paused(); /* Don't go into the loop if HRTIMER_REARM was the only flag */ *tif_work &= ~TIF_HRTIMER_REARM; return !*tif_work; @@ -50,7 +62,7 @@ hrtimer_rearm_deferred_user_irq(unsigned long *tif_work, const unsigned long tif static __always_inline void hrtimer_rearm_deferred_tif(unsigned long tif_work) { if (hrtimer_test_and_clear_rearm_deferred_tif(tif_work)) - __hrtimer_rearm_deferred(); + hrtimer_rearm_deferred_kcov_paused(); } /* @@ -73,6 +85,7 @@ static __always_inline bool hrtimer_test_and_clear_rearm_deferred(void) #else /* CONFIG_HRTIMER_REARM_DEFERRED */ static __always_inline void __hrtimer_rearm_deferred(void) { } +static __always_inline void hrtimer_rearm_deferred_kcov_paused(void) { } static __always_inline void hrtimer_rearm_deferred(void) { } static __always_inline void hrtimer_rearm_deferred_tif(unsigned long tif_work) { } static __always_inline bool diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 96226707c2f61..3cbf817f52a4a 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -1010,7 +1010,7 @@ static inline void hrtick_schedule_exit(struct rq *rq) } if (rq->hrtick_sched & HRTICK_SCHED_REARM_HRTIMER) - __hrtimer_rearm_deferred(); + hrtimer_rearm_deferred_kcov_paused(); rq->hrtick_sched = HRTICK_SCHED_NONE; } -- 2.53.0