From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 663FC3B71AB for ; Tue, 11 Aug 2026 15:41:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462893; cv=none; b=boqSBZJoCOyO/o4+4OuL+nr/RamLvqPw+QKXpTrWVmdtNV2b2fVdKJLdBBzrcZ9J2yXW+J8/kp4NlBklmOfsQ82+qcq7NZ+LJUjA0588p4/U+ItiizBQSLHgX8jAm8aBNO26+RvrKVWA8QeBYzud/7U1n3OjqmevvoLLxYxeHUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786462893; c=relaxed/simple; bh=s2GsF/HuuhqRgEBoKnXETG0xb+lEGpCR6SzR1Bt2wXA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Y3zMCnbMOw/zM90qYbhf6IfqJYvAEyNBuUdUeV9/ekS2yQoFSuCSkQjE5Vps+Kh1czoGoSJDN8iQulJsMHVFSzX1hbsLS+ZDqgJjTLnqFJLtkhQfZgXpFlaDfpTKSg6wbNY1pcGvV9+J4nPboB8HT7V5kmSycydEwMBtlwTlAwM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QikSISeF; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QikSISeF" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so27683775e9.0 for ; Tue, 11 Aug 2026 08:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786462889; x=1787067689; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=RBg7Waiba/udBzajyRDSpAo3xkVEtASSwhEEWYlwPWA=; b=QikSISeFEBjvNqt1p1DWEyh2+nUlFtevxr0r145g4Jf4oU6OmXmNkveIegfUbhTYTg C5jH1Uzj+AQiO/A+7+oNZwhXPnRYL9ZHAOkYk4deLyDktVU7cxWa/QUUYKksHkBKle9u LyvIq3pqzm+slBxXbg7tZ9io0SiBF72JV4v04zmOG3JzIDxr0YIiGlMBhE79MSkWVEtS itdkBFARoXzLWVoQuHGopVnfGIaq8JIM2OyMQtMKkaMQ4rF2Q9dEbF3jp1fVVfO5bgqh zVXVMKc8DNKgaUOLs9ofebH1HKnZRrbIgiVCn7jqvy7cyL1rog1fhUKkkHl6aWZgqUaK 7N4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786462889; x=1787067689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=RBg7Waiba/udBzajyRDSpAo3xkVEtASSwhEEWYlwPWA=; b=UZZOqptmZY8d1XXSdy6STBdade93yQp3Mw8rIO3O/yB3cLhh1m9K86mzTO6UWX6KME iAJH8eCsogZ8bZ2uqCs1xRo6jFlq5VMLV2l7LT9DbBa5lcXczoepja1oSeqqknN9zkhn bJVwCNGu35RIVCua7pKG4vJguIhrAu/7O5bOEHC4zuXiU/Sv/SW/J5IRgBS5jtctu6h9 +Mh15wos4Xjo7nd2xj3yZ9qQkN1zn/ZspHLpdALAyvz0Iv3moqjBnF3QCnqQZdmJt6AP 5r1ylnB3cM8yuin/qR/5yuFT6Q9QmuHyarNiuUC0fS6pAumQp1uFsKyslvdF3OPPYadi z7gg== X-Forwarded-Encrypted: i=1; AHgh+RqS032BUmFCRjlAXEhVH/PTQxXzTJOPDob91HVTnEfNEru5H+v8yfJUsx4peLaLbZVx6/31pYe8nLBwJAQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxnmVH8wGn2TU3bAx+7vtK4ez1yUjDc23ZpqbgERxrGPAz/V/Sj FtyLTUEHJpafPUluVlTNZW10R2KVEYIX3XkDiEWgHu3IjdtYge/5PEZu X-Gm-Gg: AR+sD12HR/0ZbvJ8qcRQFEhdqMD3rZqhBQSQXFikXdWU2VflxuPEza4/zc4AM31Jn8s OKBdEMv0RpO2sH3la+8h4qv20cWXFDtqgBjNCwBnRe1ZAclyjU2UOofPf/qlUNmvSPpF4iNbnBi BYuEU2jN6WSs7exDuswd/mTrdx0lblNyRkn0tZv15nzsiytEyAfBNBVR0HEY50JXYl3/NY29ogh vaUe76gC8xR4HIeuC/EbfqS9nPfqn2BgA8Nh7ogIllVpJOMf3vzo//fgZZluJ0tJqkdWfwSrLvd fgsz8CAQ96QiYjDZfWQwHy/UvK70wn0inPFW3/gISzMQhHX4X4z6qrYSJUgC1GbdgugFW5LqPCk Uljn9slVgBfktA3Z5G4PmdZc8hZ+kn3HLvSEtzhtTDH+kHMq8guZCEIelZO2xtVVoMHYJqzPuBN 6XR/e0e0PpfetpLnpYp/mdd2tceXenxRwn2p0fkIE6W3Cz72tI/kBUzWifO3yL9gMQVhTDHHvAM x7+c2FyeNmfJ1yvVhmu+DK+xbkWPKhtJsfCPktwauCBxPbowxT8AU0JzvIfYtFkvdI+hO1BWg4Z 2JEs9tgvF8yfy9jZIqCm84eYx7TgKHg4z8Q10LkH7or646BLoUixuymgKe1cRfJgMiBy X-Received: by 2002:a05:600c:821b:b0:493:e365:ace9 with SMTP id 5b1f17b1804b1-49978444628mr78764855e9.11.1786462889308; Tue, 11 Aug 2026 08:41:29 -0700 (PDT) Received: from localhost.localdomain (dynamic-2a02-3100-a133-e401-bc8e-d36c-2d08-c5e0.310.pool.telefonica.de. [2a02:3100:a133:e401:bc8e:d36c:2d08:c5e0]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997aaa7aabsm1670275e9.7.2026.08.11.08.41.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 11 Aug 2026 08:41:28 -0700 (PDT) From: Karl Mehltretter To: Andrew Morton Cc: Karl Mehltretter , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Marco Elver , Bradley Morgan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Sebastian Andrzej Siewior , Clark Williams , linux-rt-devel@lists.linux.dev, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/6] sched/core: Pause KCOV in __schedule() Date: Tue, 11 Aug 2026 17:41:09 +0200 Message-Id: <20260811154111.64669-5-kmehltretter@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260811154111.64669-1-kmehltretter@gmail.com> References: <20260811154111.64669-1-kmehltretter@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kernel/sched/ is not instrumented, but callees such as sched_clock(), architecture CPU-capacity helpers and profile_hits() are. During preemption and schedule() calls, instrumented callees can add nondeterministic scheduler coverage to current. With CONFIG_KCOV_SELFTEST added to x86_64 defconfig, the interrupt selftest fails under QEMU, detecting spurious coverage in arch_scale_cpu_capacity(). Annotating each callee would spread exclusions across architectures. Pause across __schedule() instead, extending the scheduler exclusion to its callees. KCOV_PAUSED remains set while a task is switched out. The guard in its resumed __schedule() frame restores the prior state. Fixes: 5c9a8750a640 ("kernel: add kcov code coverage") Assisted-by: Claude:claude-fable-5 Signed-off-by: Karl Mehltretter --- Notes: v2: - take guard(kcov_pause)() - clarify the test configuration and reword the pause comment kernel/sched/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 3cbf817f52a4a..e49f0bfa0ca73 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -7073,6 +7073,9 @@ static void __sched notrace __schedule(int sched_mode) struct rq *rq; int cpu; + /* Instrumented callees would leak coverage into current. */ + guard(kcov_pause)(); + /* Trace preemptions consistently with task switches */ trace_sched_entry_tp(sched_mode == SM_PREEMPT); -- 2.53.0