From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id F2CDD44C50A for ; Tue, 11 Aug 2026 16:25:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786465562; cv=none; b=hn0VUJvBaS73oRLfktK3H5hYnyRlbg//E2rtVJo+O72ZnaW2LA/8KlMOrS7wXG7pisndul0UBmaClMdUZoKHEs/yMWrzz1ul9AZ5zw5sR98LgPjuyEPRzW5T/MkeUsMsiiW6y1Xc+gYdlhQoTKOhV5UgX6djgr9tpeV7y0joVvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786465562; c=relaxed/simple; bh=igbvvax0JGwfrfFKY+TA5P9JX55tWlcLP0lMbQr2rrU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TZ9IEw1MOY8e5mdCe9iJGo3AxdcGV6e/3yV71E8gfQXLujoF5u+UEjCiRM19RQzmPC224dBESQeFsB3DYZFUD/xTEJdXBN2q1d7YaYX9GzfmSsYOsikr4/UwXTMo4jn40NAPUBNt2+5KNft3NfC7VVkEnKA1f3MsM2+wE8xaiew= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=TkVaNfBk; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="TkVaNfBk" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6E68B1516; Tue, 11 Aug 2026 09:25:55 -0700 (PDT) Received: from localhost (unknown [10.2.196.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0995B3F86F; Tue, 11 Aug 2026 09:25:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786465559; bh=igbvvax0JGwfrfFKY+TA5P9JX55tWlcLP0lMbQr2rrU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TkVaNfBkBsx09OjMZry287mHTgG4IvVeGrC+NoF6CVHZzqXeK/hOvrYFGuPxfhgN8 37wSiRcXDuvsSICmaBMfN4KYuB1Zry6mPd+WKzhiFQg5GGUnhHNwd2qO0vbypVB7vT Xlu7BXzk2x+K5NhJnue0J9OSeY17jaK9lrAIWo2I= Date: Tue, 11 Aug 2026 17:25:57 +0100 From: Leo Yan To: Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v9 05/13] coresight: etm4x: missing cscfg_csdev_disable_active_config() in perf enable Message-ID: <20260811162557.GG15499@e132581.arm.com> References: <20260725113645.57519-1-yeoreum.yun@arm.com> <20260725113645.57519-6-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260725113645.57519-6-yeoreum.yun@arm.com> On Sat, Jul 25, 2026 at 12:36:37PM +0100, Yeoreum Yun wrote: > In the perf enable path, there are missing cases where > cscfg_csdev_disable_active_config() is not called: > > - Branch broadcast is selected but not supported by the hardware > - etm4_enable_hw() fails > > This can lead to a leak of config_desc->active_cnt. > Fix this by properly calling cscfg_csdev_disable_active_config() > in these error paths. > > Fixes: 810ac401db1f ("coresight: etm4x: Add complex configuration handlers to etmv4") > Suggested-by: Leo Yan > Signed-off-by: Yeoreum Yun Reviewed-by: Leo Yan