From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 142F3448B82 for ; Tue, 11 Aug 2026 17:02:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786467767; cv=none; b=JhrIfvOoiwAzKcpru+1+sHiltBy0xTg2cnSTyM8UbhEvimtsWxetOa6IbyjX6cEQ1QboTFi0oLAAVqSP0wF6jsz/M64TOw4mSMdL1gG4p2T1MZDtLOAW/mu4IcwwBA2fNGADgFSEnSLLE0SEeC4G/HwYmTLmMx0Z5eJk3SFX17k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786467767; c=relaxed/simple; bh=ighsZYu56ze1VtoME88ZTPKrQBrVvRxtVSSr3jDVTkE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FVWWRW+6ebNG3Pb8dRclHrZ5uCo3MMpPQ9UPagyLqsV/dPF9Ni7sZucReA/4ic+4tFT2TsesO5veJgCjEl6STPPdSfs0wvKUDsNX6Mqb4XV5/rfDdCUUrS7RQ9jRJLTTccP/PoDuhrIgeahRV0MZ7/4lqHlfTLuCvbWbmAqnDpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=kUM84eTk; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="kUM84eTk" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 287F31516; Tue, 11 Aug 2026 10:02:41 -0700 (PDT) Received: from localhost (unknown [10.2.196.114]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AB6B43F86F; Tue, 11 Aug 2026 10:02:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1786467765; bh=ighsZYu56ze1VtoME88ZTPKrQBrVvRxtVSSr3jDVTkE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kUM84eTkp76JyCxHDet1JgI+LDkGzPflyyARAXD54Ar8//eKpS2Q97iNgRBnXT9Wa gFCO88wgfmHx/dGTchjzXeDzoTVsUnh/jhTv4DCsKEqotYpfwLDzLelvVHeDgnYYKr LDFLxVdJwYGgPCdAe1zbEoIseDkAwe6PepbMY2JM= Date: Tue, 11 Aug 2026 18:02:42 +0100 From: Leo Yan To: Yeoreum Yun Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, jie.gan@oss.qualcomm.com Subject: Re: [PATCH v9 10/13] coresight: etm4x: exclude ss_status from drvdata->config Message-ID: <20260811170242.GH15499@e132581.arm.com> References: <20260725113645.57519-1-yeoreum.yun@arm.com> <20260725113645.57519-11-yeoreum.yun@arm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260725113645.57519-11-yeoreum.yun@arm.com> On Sat, Jul 25, 2026 at 12:36:42PM +0100, Yeoreum Yun wrote: > The purpose of TRCSSCSRn register is to show status of > the corresponding Single-shot Comparator Control and input supports. I vaguely remember that we discussed the issue with always clearing drvdata::ss_status in hw_enable(), which might result in single-shot does not work properly in a perf session. This issue is not introduced by this patch, and I think we agreed to address it later. Could you document it in the commit log so that we can understand and track the issue later. > That means writable field's purpose for reset or restore from idle status > not for configuration. > > Therefore, exclude ss_status from drvdata->config and move it to drvdata. > > Signed-off-by: Yeoreum Yun With above amending: Reviewed-by: Leo Yan