From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D77054772AE for ; Tue, 11 Aug 2026 19:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477343; cv=none; b=qs2GXA77WW99ikE2+3zqcz5KqzwDIaKNvQJFMK5cAF/vxkO+xyR9dioiF2A4TfQl6PFRMhhs64noFeb5VD71dk650Z+DtDHWu5A1N75RJx9GBCxXIdm3I35Gaa/yREw2/DrqaUyQpUPnl65PI5N51+6q9efgOjyuiUEuBDrGZs4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477343; c=relaxed/simple; bh=iymtdZbAVDC4szK+VL2vsDv4Um3gp/9GnkovC0TOf7E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=HAnJxbuSxONBnhQh6Y7v2XMQ8LSnJIIbnb3q9/LcxuZsnrnQPAipk2f3hGqiVaaKOVxIFnTs2OenaCbKdAsSXfObNozyJ+kzTZ3lXPAr+FWRdaOe72JQYJ7Nt/N9tz43ViTmJOE4iDgmz/vM+jJ7niH8Hfutj9Hjo/sh29j8A3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rsu/2LTZ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rsu/2LTZ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4980dc26022so1738925e9.1 for ; Tue, 11 Aug 2026 12:42:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477340; x=1787082140; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=rsu/2LTZTEAhX//Q29JAAyuL/d9olDI3dISJO7M2kpO4uonZSqspmWPeTa8oQMf2P8 nn76FbxH6ph5p6mQYExRgWNQ6yeli/B1K7JQYo9aE3yQXqmzwugptTkPAJz3F+Q6h/j9 RuKKaMJV/pcndzbcx4HITrzLLcRIwWaftWJhsoioWPC/7CX4qkgQxhg6kimZ0jHf+LpW 13CIjZkuVbpfoPEdzgumoLs9XHDnHRh/iSR4BHFICtiNS/1ixJc0I/Iqn/2FRpU/Htc0 1NlSDDFf36CdkEiCHSermn/6v4njmioq1zdnQH4cnX0QR3TYPdqQhX3VjGY7aicIfsU9 g8Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477340; x=1787082140; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+Lv+zt/h7dKa8TuGsaFOLj9Yjn5OU7W3HW8p5oLwNPc=; b=ezAjrD0A7BLM332Khe4g17WK1qnibJxGRno3fsVxyzHK2gVa208dKboJhndlJiHf7O QpJgOQJuEfosatdlKThNS/ylw+9oe7IUj9V11rkO/AyoBNoJdEDSK/N/vjNGSqj431f5 tebNWsFf5tHFrFZKSvK4MC0BhMf9Mvmb6Q1vgnaRXhURCXSiwOi0Bdi9SvsdTND+Esab NfklJXb0tP7fTG6b07ax9KlFvjDZcY+zEF1rZxsnVL5zQkT6ITusfkV+U3p2z9ONFhee nZs8/S7g711AJH5bXFpBYObvD45xkf3jGhDzjQV/rIVHwBqdvQWr4qLzODZpgWRykvR4 buEQ== X-Forwarded-Encrypted: i=1; AHgh+Rq+EG/4HMKPGqExcHA4iDlYfrj3dywuVIwK+tZk13nQQEG9jdRwym6BrOH+/HvOHp4QCwsLxai/wjpqXs4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyw86GW2n5thg6j+O6w7Sa9i+tyLpjh+XjWKJwB1w9s30cTyuaq xQnJVz1ggjKTe394SiwPchL3x+w9YRoipQszvRlskyRL3qedGzwTO2oY X-Gm-Gg: AR+sD11f3apoTzEBsl/w0BcdHOr/KUPogf2mCXzi5j3b05H9l14P8to/HDNQ8WWI4Tq avvIPamcYParvwH3IVw9Tu6DBP3vUeAkUJ/EJ5YnWxcpzvP05g0pPrPWZ8nqqkL6LZncrCydDR5 Orl5G+sE9LJjIhz+9PwfkIMXqqaGUiyxWv+MHyBkI3nKe22CoV+A0A5UjbMmlx6drmvwL+MPAWo K37dMzgpB3Ux+GD9DX9iTpn+Awup/RICdUlv9Zj3M1h/g4IPi40IkHfX5tCx43W+aDGC5u4tyI3 IZvZPj+8EY+PglAC0uaQpb4Z9HAl6519k9JA0SvyjWOvzDgbVa/Vb7vwK6YgCCvzgSnH5ei7i/u MSudp2ATQGK2+BGriAd3K3N8IwRI5TY+Gew2vwHG7YDhRaKddCw2ZU+RWaPmL0tAM5fomdlERRQ +P0UnNjmqkiVqueDBMDSVdqgPaGP55FrXrzz8jnvoViqp9i+/VxuHrCtqD3mwW0UTT X-Received: by 2002:a05:600c:b85:b0:499:516b:83d5 with SMTP id 5b1f17b1804b1-4997845f3f3mr82515435e9.11.1786477339927; Tue, 11 Aug 2026 12:42:19 -0700 (PDT) Received: from antoniarch ([78.213.143.159]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997b22784fsm2606535e9.2.2026.08.11.12.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:19 -0700 (PDT) From: Antoni Pokusinski To: alexandre.belloni@bootlin.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Antoni Pokusinski Subject: [PATCH v5 2/9] rtc: abx80x: fix error check after i2c_smbus_read in read_alarm() Date: Tue, 11 Aug 2026 21:40:27 +0200 Message-ID: <20260811194034.28937-3-apokusinski01@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194034.28937-1-apokusinski01@gmail.com> References: <20260811194034.28937-1-apokusinski01@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit i2c_smbus_read_i2c_block_data() returns the number of bytes read on success and a negative error code on failure. The existing code treated any non-zero return value as an error. Fix the error handling by checking only for negative return values. Fixes: 718a820a303c ("rtc: abx80x: add alarm support") Signed-off-by: Antoni Pokusinski --- drivers/rtc/rtc-abx80x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index 5486d9d0b1e5..fdf9664ebb6f 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -294,7 +294,7 @@ static int abx80x_read_alarm(struct device *dev, struct rtc_wkalrm *t) err = i2c_smbus_read_i2c_block_data(client, ABX8XX_REG_ASC, sizeof(buf), buf); - if (err) + if (err < 0) return err; irq_mask = i2c_smbus_read_byte_data(client, ABX8XX_REG_IRQ); -- 2.55.0