From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8344C478851 for ; Tue, 11 Aug 2026 19:42:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477364; cv=none; b=l9ZZltfKdB8Z4z4asn09Mhp7WvaifSC1ceREy9wYl/tLnGo3XlAM2FYAA7jqT0SpCfxhfQVGUK7LEE76iR9/YTnwHD61P/ordnlOdLhPq/3uEdnIvJ1MAWEGJZFNcp2/mvr0BizX5gKStUsW5XxCX/V1zRjERaoGFz3VJr13kmM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477364; c=relaxed/simple; bh=0MSVQNAfX1H3iU3xjsiD/tQTHV1nkB6xpxwoTTdwURs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=m2f8FQVH/SKWrXW9bBsytNUBrlyrD/dmty4ZSKjm/0MRNhxLox2F+2M/szz6CLWKnz2YvjHylsj7hNn8Zf1NcekQjU8m2OPP9bCi5jGlO0a0nFvt93OmJ6e4ltuR5eLTG+HLizVyWl5Sy42XGAGbuB8saIfCoEeve+uw3XHcyuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Wpv1ZjD0; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Wpv1ZjD0" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4954aff6088so513655e9.3 for ; Tue, 11 Aug 2026 12:42:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477361; x=1787082161; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=maGvDaUsV8Puzc/vzM2VfATUwgjtE+oqcHZemKrSRow=; b=Wpv1ZjD0PEaB6UzCTwI9FgPHMo5nOjXQhXQJbXm5GL+tIjVf2TRJUlLtkFAwRA7373 qabMYMlX/g5Qc4dfrkT4R20HUPy6clBLtycSfTWC17GELlVWr4NgTFKoPctZmpEbQhat 99lPnJKn1EM3R/5QwcPa0Dh13HBKpsoWLfY38L3f81mHImdSNEOCFcIYdQA3a1YgEYCF K74S6Ft9LrBeh3GmbEUJB/s1NwwnVlPluqn9uKVxYLKsbNCgVsIhU6SiiGgrsztZ49mV wykBjJUGDJCOTlfq63RXdzEruL7K/5pUqMgpk+GZgQ0u1yv4NyqY4YtSIamyH6yRNJAs Obxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477361; x=1787082161; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=maGvDaUsV8Puzc/vzM2VfATUwgjtE+oqcHZemKrSRow=; b=KjdJLdA+tVjhuEgnGn9zNzG45X8adXHQpOMTAU/4z0SEnXAVnYExWct2R7fEg9ChAl ON67S6VzgmiUU7g8y0qYvMLyWhoRqBGadff44T6qW4HDn57DKFYcgDVRu65caINqvuhf IO7s/TZOi/qwCGmVECTyUE8qBGlZG5VDQDcFsMiZKxlTfduKpjYz+hj50+Yv4PFZG8aB sFq2x2DtD83NEzcUdfXTtHsrT/e/3z4YlBUMT+am0MErO1MYJaXLLhBy6/sdwCvsi2OR geJWEt+X7hLozjG45KDr8KyjkvMebidhWepJD9VCD5aYX80QGGDFVC3prrGSsdeH5nQ/ ONWg== X-Forwarded-Encrypted: i=1; AHgh+Rp1kUnI3smGFMYl5C5rzGNAU5trFnwGWN2nxBB2b147I3rm0gjGPq/R1q1G4y9AWD3QrjD6gDF4Ynzukx0=@vger.kernel.org X-Gm-Message-State: AOJu0YxWdAVTgK2wWOox8TLPcM9XK0YY2UXf32ckkY8lvMPQcfibp+va CDlirlDYmuCqPDyTH0HpVws3+s1Pmnl23LiglBOWi5fLgjVYQJt0GO7t X-Gm-Gg: AR+sD12OSfBie8YEu+e6YCDo5cN2s4UDXiydAJH4mO9BO18DzfbRoyeACn9W8JEDqWo 4tk5N3TgP7n1WJhk4nD1QSU4tq48ma8v1POCZX+tviRUHOkvzYWvFfW3vQJ90S2VpcIitm3RcY1 GK+92wyyfQkFK+OjrirgwmYNNihyVP2+fNsL2vup9H+0sAkdOk8FZfrjHAAMzo7LGn6pRB3UqMK wtQv8x7UvnRtGr2u/Hed3kzQPDv/rh1VRlpNOzmUSIU9t5lkBdXIhxhWwMSZrrNBZQcVB6ZVyC0 Jy80GsrrhIHqY1yUXPc3ecGi8VQ3EiE5fktV+AjU9/4gFbO2Q8fkwnBNZho9p5k5dWucOVeQ5lE BIMapXdFixMQmu2oDE3Ko7cbiCpY2IGlTdQ7gNCvy/ijC+f5UJPzO41DSKPBwgN2Ut0XucpuwxB bOfXEmBO79PyVUEkOTvbJuVfQswpykxfrFWej5Pjm6gFlIkdEIwJdrv8TQLv3bNWOptIQexNhMA W/UwQzAyMPV5frwIqrKk09bzBlqUzBrGlDd6X2EyLuDl8pUF5+L X-Received: by 2002:a05:600c:1d0c:b0:495:6bc9:62b0 with SMTP id 5b1f17b1804b1-499784611c4mr86084415e9.17.1786477360587; Tue, 11 Aug 2026 12:42:40 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:40 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 2/6] list_lru_init() does not check return value Date: Tue, 11 Aug 2026 21:42:17 +0200 Message-ID: <20260811194224.121597-3-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: list_lru_init() does not check return value in ttm_pool_type_init(). Fix: Check the return value from list_lru_init() and propagate the error. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: Óscar Megía López --- drivers/gpu/drm/ttm/ttm_pool.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 88c0d33eed1a..8637f7942347 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -354,17 +354,23 @@ static struct page *ttm_pool_type_take(struct ttm_pool_type *pt, int nid) } /* Initialize and add a pool type to the global shrinker list */ -static void ttm_pool_type_init(struct ttm_pool_type *pt, struct ttm_pool *pool, +static int ttm_pool_type_init(struct ttm_pool_type *pt, struct ttm_pool *pool, enum ttm_caching caching, unsigned int order) { + int ret = 0; + pt->pool = pool; pt->caching = caching; pt->order = order; - list_lru_init(&pt->pages); + ret = list_lru_init(&pt->pages); + if (ret) + return ret; spin_lock(&shrinker_lock); list_add_tail(&pt->shrinker_list, &shrinker_list); spin_unlock(&shrinker_lock); + + return 0; } static enum lru_status pool_move_to_dispose_list(struct list_head *item, -- 2.55.0