From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6D63440A2D for ; Wed, 12 Aug 2026 12:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539447; cv=none; b=sk2uTey/4Iq6GHJ6/ZoU577+g3DvK8++fiWnt6gZVu5HMyLfOYHlhWLN5p3M5C4TS9Qz3TU8luhL+VE6LfXE6ai+61YzN5dIVnDuJBQlH0SL7N+a1WZ6acknTPXlIp7h7VS4KD54uLla8kSrS9QpxP3LFjk1cZXjrKD5+o+H4jw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539447; c=relaxed/simple; bh=KqroUBF9fy63U0kIpZnbE8J3Xt6EvTVFVK/4HC1fRg0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=SuNRScZ26WsxmursyYGJRi3L7pcPw96cGzA9oJW6fIRz44BbbXiLlIoMWYuQt5kBvkhComPGQsubCKCp8EgZ96GJGHE13EJqUl+or6qlm09K3OyF4FqJaTRWopA+sIzLDSFde2FZubfd3EkBIB0KtiiucNVk3UOjasnZPvGiy18= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=E3ASPS1k; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="E3ASPS1k" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 62F441F00AC4; Wed, 12 Aug 2026 12:57:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786539441; bh=Za4LRzHAXU2RDULMQIs7N/GmIAAtgm2U036qr4uAeQw=; h=From:Date:Subject:References:In-Reply-To:To:Cc; b=E3ASPS1kUHKmmc0d/P8SRmaxilezY1EBf7gMhPgnAsOAtFg77hzimjxGQB3ZCqa8p tSSaHHDP7Lcit4m4jwhrZSmpd5CtJSoYDp0/arbKXm/QgYoLcGttSRey5CsoflYURW zv8F88WpU6672FJ9T9Wer46JFIdBvoiKwOpxAFEHkrpk0cNIbFVa6A3faFFf0MgGkL /1MYTIgJGeLBR+o4/1SYIzepo8QUGvxEOzsZmygl5ITmW/oKdrmoK/lxW9WZ+J5Svr YxUGMeOlia60cZgeJpVlax6AEIeGGLQEB8D7BwGhCL+rIjBsYfrCzzoOepRgb8epkV B4Jb7Yk5PKJrA== From: Maxime Ripard Date: Wed, 12 Aug 2026 14:57:02 +0200 Subject: [PATCH RFC v2 7/9] drm/atomic: Add drm_atomic_can_create_state() helper Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260812-drm-reset-state-flag-v2-7-e96ce13317dd@kernel.org> References: <20260812-drm-reset-state-flag-v2-0-e96ce13317dd@kernel.org> In-Reply-To: <20260812-drm-reset-state-flag-v2-0-e96ce13317dd@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter Cc: Daniel Stone , Harry Wentland , Jocelyn Falempe , =?utf-8?q?Jonas_=C3=85dahl?= , =?utf-8?q?Michel_D=C3=A4nzer?= , Pekka Paalanen , Sebastian Wick , Simon Ser , Victoria Brekenfeld , Xaver Hugl , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Maxime Ripard X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3552; i=mripard@kernel.org; h=from:subject:message-id; bh=KqroUBF9fy63U0kIpZnbE8J3Xt6EvTVFVK/4HC1fRg0=; b=owGbwMvMwCmsHn9OcpHtvjLG02pJDFk1uXPX3NqX8HrZ/KDQtm/3RWVXJL+20eY42WRt9cn8Y tHnGWLtHVNZGIQ5GWTFFFmeyISdXt6+uMrBfuUPmDmsTCBDGLg4BWAie1YyNpzxfh1Ry1f06bus K4vnPx/52wm7GBeJPwh++nk/k1jtDn2ZedcuRqls3Ji2YKfQFt8VVxlrpbe22d3OkEvkUT8ffCR MkfHFgu3xc7cLTK/baynKfKSM46ZaZnf4taP351n6+r4piXMGAA== X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D The atomic reset path will need to create pristine default states from scratch for every plane, CRTC, and connector. This requires all of them to implement the atomic_create_state hook. Introduce a drm_atomic_can_create_state() helper that iterates over all planes, CRTCs, and connectors and returns whether they all provide the hook. Color operations are excluded since they always use drm_atomic_helper_colorop_create_state() directly. This will be used both as a precondition before filling a commit with default states, and to report the device capability to userspace. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/drm_atomic.c | 49 ++++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_atomic.h | 2 ++ 2 files changed, 51 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index e78f7eb6bfd1..d8251447e44a 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c @@ -1608,10 +1608,59 @@ drm_atomic_get_new_bridge_state(const struct drm_atomic_commit *state, return drm_priv_to_bridge_state(obj_state); } EXPORT_SYMBOL(drm_atomic_get_new_bridge_state); +/** + * drm_atomic_can_create_state - check if a device supports creating pristine states + * @dev: DRM device + * + * Check whether every plane, CRTC, and connector in @dev implements the + * &drm_plane_funcs.atomic_create_state, &drm_crtc_funcs.atomic_create_state, + * and &drm_connector_funcs.atomic_create_state hooks respectively. These hooks + * are required to create default states from scratch rather than duplicating + * the current state. + * + * Color operations are not checked because they always use + * drm_atomic_helper_colorop_create_state() and do not have a per-driver hook. + * + * Returns: + * True if all objects implement atomic_create_state, false otherwise. + */ +bool drm_atomic_can_create_state(struct drm_device *dev) +{ + struct drm_connector_list_iter conn_iter; + struct drm_connector *connector; + struct drm_plane *plane; + struct drm_crtc *crtc; + + /* + * colorops don't have an atomic_create_state hook but + * drm_atomic_helper_colorop_create_state() + */ + + drm_for_each_plane(plane, dev) + if (!plane->funcs->atomic_create_state) + return false; + + drm_for_each_crtc(crtc, dev) + if (!crtc->funcs->atomic_create_state) + return false; + + drm_connector_list_iter_begin(dev, &conn_iter); + drm_for_each_connector_iter(connector, &conn_iter) { + if (!connector->funcs->atomic_create_state) { + drm_connector_list_iter_end(&conn_iter); + return false; + } + } + drm_connector_list_iter_end(&conn_iter); + + return true; +} +EXPORT_SYMBOL(drm_atomic_can_create_state); + /** * drm_atomic_add_encoder_bridges - add bridges attached to an encoder * @state: atomic state * @encoder: DRM encoder * diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index 00b3e9fc429a..7dc26e3da65c 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -700,10 +700,12 @@ int drm_crtc_commit_wait(struct drm_crtc_commit *commit); struct drm_atomic_commit * __must_check drm_atomic_commit_alloc(struct drm_device *dev); void drm_atomic_commit_clear(struct drm_atomic_commit *state); +bool drm_atomic_can_create_state(struct drm_device *dev); + /** * drm_atomic_commit_get - acquire a reference to the atomic state * @state: The atomic state * * Returns a new reference to the @state -- 2.55.0