From: Alexandru Dadu <alexandru.dadu@imgtec.com>
To: Alessio Belle <alessio.belle@imgtec.com>,
Luigi Santivetti <luigi.santivetti@imgtec.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: <imagination@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Alexandru Dadu <alexandru.dadu@imgtec.com>
Subject: [PATCH] drm/imagination: Fix NULL pointer dereference
Date: Wed, 12 Aug 2026 14:46:48 +0300 [thread overview]
Message-ID: <20260812-fix-null-pointer-dereference-v1-1-f69b2ffe9520@imgtec.com> (raw)
Fix the NULL pointer dereference from pvr_fw_object_destroy() when
handling allocation failures.
Signed-off-by: Alexandru Dadu <alexandru.dadu@imgtec.com>
---
drivers/gpu/drm/imagination/pvr_fw.c | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/imagination/pvr_fw.c b/drivers/gpu/drm/imagination/pvr_fw.c
index 850a3ec8e775..88f11fb01304 100644
--- a/drivers/gpu/drm/imagination/pvr_fw.c
+++ b/drivers/gpu/drm/imagination/pvr_fw.c
@@ -1425,22 +1425,26 @@ pvr_fw_object_create_and_map_offset(struct pvr_device *pvr_dev,
*/
void pvr_fw_object_destroy(struct pvr_fw_object *fw_obj)
{
- struct pvr_gem_object *pvr_obj = fw_obj->gem;
- struct drm_gem_object *gem_obj = gem_from_pvr_gem(pvr_obj);
- struct pvr_device *pvr_dev = to_pvr_device(gem_obj->dev);
+ if (!fw_obj)
+ return;
- mutex_lock(&pvr_dev->fw_dev.fw_objs.lock);
- list_del(&fw_obj->node);
- mutex_unlock(&pvr_dev->fw_dev.fw_objs.lock);
+ if (fw_obj->gem) {
+ struct pvr_gem_object *pvr_obj = fw_obj->gem;
+ struct drm_gem_object *gem_obj = gem_from_pvr_gem(pvr_obj);
+ struct pvr_device *pvr_dev = to_pvr_device(gem_obj->dev);
- if (drm_mm_node_allocated(&fw_obj->fw_mm_node)) {
- /* If we can't unmap, leak the memory. */
- if (WARN_ON(pvr_fw_object_fw_unmap(fw_obj)))
- return;
- }
+ mutex_lock(&pvr_dev->fw_dev.fw_objs.lock);
+ list_del(&fw_obj->node);
+ mutex_unlock(&pvr_dev->fw_dev.fw_objs.lock);
+
+ if (drm_mm_node_allocated(&fw_obj->fw_mm_node)) {
+ /* If we can't unmap, leak the memory. */
+ if (WARN_ON(pvr_fw_object_fw_unmap(fw_obj)))
+ return;
+ }
- if (fw_obj->gem)
pvr_gem_object_put(fw_obj->gem);
+ }
kfree(fw_obj);
}
---
base-commit: e55fead22ff9ee047ab9f1903860c4b43043514e
change-id: 20260812-fix-null-pointer-dereference-2c891142d988
Best regards,
--
Alexandru Dadu <alexandru.dadu@imgtec.com>
next reply other threads:[~2026-08-12 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 11:46 Alexandru Dadu [this message]
2026-08-19 8:52 ` Brajesh Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812-fix-null-pointer-dereference-v1-1-f69b2ffe9520@imgtec.com \
--to=alexandru.dadu@imgtec.com \
--cc=airlied@gmail.com \
--cc=alessio.belle@imgtec.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=imagination@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luigi.santivetti@imgtec.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®