From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39ECB3438A4 for ; Wed, 12 Aug 2026 13:26:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541191; cv=none; b=TH1CzxZyR6gslHEoJa3nHj4LOo+SfqWMUPGkpJHjnAQ6UXYFaO50Cy2HQ+kHJXjjUJ4EJeBiKyf+G4kc0D52wmvIbe2ik/v/YKsA+mt2JfWSMC/5Z+Rac+ol5qITT6XCCLpZYaBiho74+30qwEanLYR8DS601WZS+QHTL/bHj9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786541191; c=relaxed/simple; bh=x0saQYNNDt8EUyLL450BFMeRZQkNMBDxr8GhSA/j6bo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=stc2drH+iZfTl0A5H7z0KAwb4By/xbuvS1GudfXuVbWVdiymdFIzydExUGmtDaBU+p7OLzxnqJ5rR7fNh8QRr5f5WT5CzRsYtKh86MGBFcdLy5yGFwhAZqjxqciA/5X8siAfKHlLn6HP+3M9yWvE9P+A94upeScuWkgwAJAR51c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LZBh4kmm; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LZBh4kmm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0C061F000E9; Wed, 12 Aug 2026 13:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786541181; bh=AaZdD0Jt+dr/QHiKkj96Jo5zBACuLKjiwAxMjMuJAwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LZBh4kmmUksyKHZa+mXnWGq2pBxAUDiamDrSAMcw7aLbz7d8HTeH+YQ+RCWrPcbs+ Ipprp6mHsl4SdnO4AZv+C4vXZ6Hd6j2K4nIHB24LVtv9+/h92JoJ3nHK+AGJOv5aGK uAzKJ06o7mtNGjej01Thnv35pTSBEyea6ODG/7+eAuB9z4fQlcDV+KnB4kDMfb8z2/ VvWBU7TdLshAsMOdmVXPHjU84FMOQm7mJJ7+iB/8oySIzlkV/15juF8kaHo0GBtWFm qyOL4HvTz0+ejDw7foU1z0eJSaRyIKirFW2OSI2c8fwzLbz1OyPBed5J7mLs3Kc6Ma 5hKxAc5Bcj8YA== Date: Wed, 12 Aug 2026 15:26:19 +0200 From: Maxime Ripard To: Osama Abdelkader Cc: luca.ceresoli@bootlin.com, Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Jerry Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels Message-ID: <20260812-psychedelic-accomplished-swift-4f0081@houat> References: <20260812130429.16850-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="x7nqwg6ptt372roy" Content-Disposition: inline In-Reply-To: <20260812130429.16850-1-osama.abdelkader@gmail.com> --x7nqwg6ptt372roy Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v3 1/6] drm/panel: Use devm_mipi_dsi_attach in BOE panels MIME-Version: 1.0 On Wed, Aug 12, 2026 at 03:04:18PM +0200, Osama Abdelkader wrote: > Use the managed MIPI DSI attach helper in BOE panel drivers and drop the > corresponding manual detach calls from remove paths. >=20 > Signed-off-by: Osama Abdelkader >=20 > --- > v3: > - Move the changelog after the `---`. >=20 > v2: > - break long description lines. > - add Signed-off-by tag >=20 > drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-himax8279d.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-td4320.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 4 +--- > drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 8 +------- > drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 7 +------ > 6 files changed, 6 insertions(+), 37 deletions(-) >=20 > diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu= /drm/panel/panel-boe-bf060y8m-aj0.c > index 84c21c62a43e..6a74523a6614 100644 > --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c > @@ -359,7 +359,7 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_dev= ice *dsi) > =20 > drm_panel_add(&boe->panel); > =20 > - ret =3D mipi_dsi_attach(dsi); > + ret =3D devm_mipi_dsi_attach(&dsi->dev, dsi); > if (ret < 0) { > dev_err(dev, "Failed to attach to DSI host: %d\n", ret); > return ret; > @@ -371,12 +371,6 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_de= vice *dsi) > static void boe_bf060y8m_aj0_remove(struct mipi_dsi_device *dsi) > { > struct boe_bf060y8m_aj0 *boe =3D mipi_dsi_get_drvdata(dsi); > - int ret; > - > - ret =3D mipi_dsi_detach(dsi); > - if (ret < 0) > - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); > - > drm_panel_remove(&boe->panel); > } mipi_dsi_detach is now called after drm_panel_remove. Your commit log should mention it, and explain why it's not a concern. Maxime --x7nqwg6ptt372roy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCanx0egAKCRAnX84Zoj2+ dqCKAX9M4Eg7ur6UTQI/ZPTS1KOSErq0BFjnX7tppCoUddSuhClwMlqxwNYO4mah UDkJkn8BgKJnhYqrTLBhbDlGgu9KMBEE6oWoZI0U2s8lzBsBehDX4vFnYHg/uRIw /JTV2CQuaw== =ZVyQ -----END PGP SIGNATURE----- --x7nqwg6ptt372roy--