mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>
Cc: linux-kernel@vger.kernel.org, marco.crivellari@suse.com,
	 Breno Leitao <leitao@debian.org>,
	kernel-team@meta.com,  kernel test robot <lkp@intel.com>
Subject: [PATCH 0/3] workqueue: sparse and wq_node_nr_active() fixes
Date: Wed, 12 Aug 2026 09:03:17 -0700	[thread overview]
Message-ID: <20260812-wq_fix-v1-0-f7effcfa8d37@debian.org> (raw)

This is a follow up for the patchset named "workqueue: base pwq pool
release and nr_active on the backing pool"

Patches 1 and 2 answer a 0-day sparse report against the percpu pwq
allocation path, bisected to commit 79f23600bc7b ("workqueue: factor out
get_percpu_pool()").

https://lore.kernel.org/all/202608120931.tvTzq1gD-lkp@intel.com/

The warning is not new, that commit only turned the offending assignment
into an initializer. wq->cpu_pwq is an array of __rcu pointers, but
workqueue_congested(), the allocation path and its error path all go
through it with plain loads and stores. Use the matching RCU accessors
instead.

With the two patches kernel/workqueue.c is sparse clean.

Patch 3 is a separate review fix: wq_node_nr_active() warns and returns
NULL for a per-cpu workqueue, which only moves the oops into the caller.

This has been stress tested with a "debug" kernel and wqtest test-suite:
https://github.com/leitao/wqtest

Signed-off-by: Breno Leitao <leitao@debian.org>
---
Breno Leitao (3):
      workqueue: use rcu_dereference_sched() in workqueue_congested()
      workqueue: use RCU accessors when populating wq->cpu_pwq
      workqueue: BUG_ON() instead of returning NULL in wq_node_nr_active()

 kernel/workqueue.c | 24 ++++++++++++++----------
 1 file changed, 14 insertions(+), 10 deletions(-)
---
base-commit: 5e6de6a2b522f659defacb1551d0465ba6ce13cf
change-id: 20260812-wq_fix-be919bd89542

Best regards,
--  
Breno Leitao <leitao@debian.org>


             reply	other threads:[~2026-08-12 16:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 16:03 Breno Leitao [this message]
2026-08-12 16:03 ` [PATCH 1/3] workqueue: use rcu_dereference_sched() in workqueue_congested() Breno Leitao
2026-08-12 16:03 ` [PATCH 2/3] workqueue: use RCU accessors when populating wq->cpu_pwq Breno Leitao
2026-08-12 16:03 ` [PATCH 3/3] workqueue: BUG_ON() instead of returning NULL in wq_node_nr_active() Breno Leitao
2026-08-12 17:18 ` [PATCH 0/3] workqueue: sparse and wq_node_nr_active() fixes Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260812-wq_fix-v1-0-f7effcfa8d37@debian.org \
    --to=leitao@debian.org \
    --cc=jiangshanlai@gmail.com \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=marco.crivellari@suse.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®