From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C9403033F8 for ; Wed, 12 Aug 2026 02:57:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786503426; cv=none; b=jiCjBxt7tX54waaXP8FrB4jT1E7uTNHDVQz/TrZd4dLNeqfSvpxkfU73IuPLIF/yGCAPXurT5Mxx/DunpAL+gDD5b/E2vc8mj4eHUngEstan6dtktiRnsCsJ7FozFGgEPV2gfCWRGYzku0jqmfEJsELV/iKT81J2wQ297q2KR0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786503426; c=relaxed/simple; bh=qvGDeE4OJT/ilYYDNmcOFrDj4LU5bnkefef80tOMTX8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oT1JYeX2/oHCEwausbw+KMWF3ACk+sb7cXXqSZe3cWZDDpscu1W/lkpO8jsdOMZXOk6R6fHOJNHiT/TdxQArVSo5F8Pmk7Jz+HPn3ySY+cY+jtq2EuT21tP335R9nkGfKBBuRwcgP0mJ/3jd/jMAwtlZDBPVscZ7X7XRL4cGbQE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F6dTegZ5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F6dTegZ5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9152E1F000E9; Wed, 12 Aug 2026 02:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786503424; bh=vJNyFEDiKFhs2ub4tOpr7dJKKD9MGTbXcSZgKL0IZ6E=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=F6dTegZ5oInFJcXZFPtFebuiKHa5HOsxK0VWXnv423M8OB+tkxT+G4dFnCqcDtwMD qIkF3l68w+MdjPaPuXdJq3vz1zeDyQMvbklnworS4FoEnQVj5qUQ5zAkNW+jllAHfE Ct2iBfFdGt08QLyazC1mKwIMGmDwMXWQ6h2I+twai2ibDDmyR+/88oX8fEzcWIJxOQ hKfKWRnQXqS9ZiXOIe+JG90y/wJ0jk9xQ1NAnZ+fGyUbEql3yWSrs4pzUYS4aFyxxq 0R5Z+PvJU6LBlgfQMHR14Q6/2Rq2SZxjA7+pSpniB4JXnN+2JJ1DdpQ8P4VT/VK8LJ CpMP/YirfZDhA== From: SJ Park To: Pedro Falcato Cc: SJ Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: replace custom bad page map ratelimiting logic Date: Tue, 11 Aug 2026 19:56:55 -0700 Message-ID: <20260812025656.8687-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260811172156.356053-2-pfalcato@suse.de> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 11 Aug 2026 18:21:55 +0100 Pedro Falcato wrote: > The current logic (allow up to $BURST prints per minute) can be entirely > replaced by the generic version in lib/ratelimit.c, used around the kernel. > > Do so. The only functional difference should be that the new logs will > read something like: > > KERN_WARNING "print_bad_page_map: %d callbacks suppressed\n", ... > > But that should be fine enough. Nice cleanup, thank you! I also agree the change on the log message should be fine. > > Signed-off-by: Pedro Falcato Reviewed-by: SJ Park Thanks, SJ [...]