From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DB4E345ECD for ; Wed, 12 Aug 2026 03:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786503601; cv=none; b=E5/F6sofewOznJOZn/zMcUfbbIxfQNU0ZUl7n/gbT60Ua6nEk0Ai6f3VR8vpqYKyB+V7n6t0UP/QKn6gu/6X5B1gMqK6B9puZcGTePdJIWS04cmRzkvNQ64LSCjxl+sVTYA8IlECfWl9A9erNRMBG1LGhOZeF8uiF1y8yEKsfmc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786503601; c=relaxed/simple; bh=NEi5JmVFeVzxRMlOkJBMNGvzCSkgJkfl5ivsH7elejc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hCb9I7amwfhxg+ynCrf1Zvb8RbtkTR69mmC3KntK/+WPRVEWclmUNi7HXw3OeTbyRsQA3aFv35jEXFo7DjCn/Gb5X/EySp4SK7NSpzPPhhAPblHrEY9LgfHJ6kliuw7O+MI2qaQ7C0jpZlSEIgD1I80Y+iGOXB/eCaUdTfa1X3k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ejYuQmuJ; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ejYuQmuJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F3091F000E9; Wed, 12 Aug 2026 02:59:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786503600; bh=3DsrGZHknKt51D/hWKw/9nQGs0Ea4a5vFpuH13+ofAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ejYuQmuJDMxlxoi6RHEuINerf9JR2b21IkE/uXiYBpwO0d6PRlbnYMj4ZVfYKGrLm tiV2PeATT4h1vyyBmo8d8uIVP++xPuF00IihAzT9JMsEhm5a2mZ11cNtQ33XbzrQUW OBehH06vcqEsUXiyelyFZ/6LwaHo1h7PXd8Hllt28Oo5FCSGT2RS4DHhxdc82RRwxL wleohzN3oX2nYPFCQWLYiq4qEPB8IqWGOV9jcMiRv5w/7bKyoGKhW8ukhSkAMHFx2/ iFJ0HozGzKRDwn5XFBhIE01eHdvejvHEfiQux8SWed3+ir+SzHd1MIMPXd4BhKTvbo KSVkK3VFm1Feg== From: SJ Park To: Pedro Falcato Cc: SJ Park , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] mm/page_alloc: replace custom bad page ratelimiting logic Date: Tue, 11 Aug 2026 19:59:51 -0700 Message-ID: <20260812025952.8854-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260811172156.356053-3-pfalcato@suse.de> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, 11 Aug 2026 18:21:56 +0100 Pedro Falcato wrote: > The current logic (allow up to $BURST prints per minute) can be entirely > replaced by the generic version in lib/ratelimit.c, used around the kernel. > > Do so. The only functional difference should be that the new logs will > read something like: > > KERN_WARNING "bad_page: %d callbacks suppressed\n", ... > > But that should be fine enough. I agree that should be fine. This looks good cleanup to me. > > Signed-off-by: Pedro Falcato Reviewed-by: SJ Park Thanks, SJ [...]