From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2379C40098D for ; Wed, 12 Aug 2026 08:52:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524741; cv=none; b=j6yTjby+BcYRAoGwExCFjoiKaqKN2dN4kqFGBDDP0KBXbN5i/ei2bU6xjhp+dZw3gv+N1uwJjgGzolEgSqLijuK6cFBuJkEtGkFndA+vUyyYE+YsRGV6hh5Cgj37ETkki5JRVQaBfyVKAX/9pHtToQsAGGYcgm+qT5snnq+0dRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786524741; c=relaxed/simple; bh=GOa4PCeZb3TNRPAngDxKwF15NFCECYzINypupzd8BtU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jVg/3GARxAM+29j3Tmp0OyTkP7MbLoaM1Tl7dmyZfn7N7ta4RsEouhIq76fcubSF9t2gCTqMRmUpaEbUXIARGW8Ir9kDSVJX4S213h7Ojk90HJ1eJpj/iduSh8JZOIB1bw4eqF+sszfbrMX3RgrZsJtkQu65VpzqNoEGcWORKmU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ez2zOAnF; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ez2zOAnF" Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-2cca0c5799eso9886345ad.0 for ; Wed, 12 Aug 2026 01:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786524739; x=1787129539; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4x5jxb12BWr160Ndtvg6XwQshT8/0VQ/I3/i+j54xi0=; b=ez2zOAnFdF807VXQRzcYTRMVH/P6OuTk4JPqvpptGohLUkyF2x9nZp+unc+FYWgFZy UotQrC3rxqvbK3D5t97dWklOE8ryRiAONcw7cabtJ+vQ06xoVN0rzZLEQ98O1289s4od zAe5fHDoya5/GxFuldk2BHM0OqA4VISVFSD1G4/Bg30KQXJTFXYRVHZoFZPXk+ZqjElz FiMp0Zh1+HnjRh0REvfYCzyGt70oRCi71K9vw3w8zRk1ZLEAWuNmWjyTAW9EmNSj0eDd VMB1c0PAYqDZTXzaSujS5KbVBTglC6TFC/4Bp7JLc8Jums0fzrqW9Hcv8fL0kGMxdhjk /i0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786524739; x=1787129539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4x5jxb12BWr160Ndtvg6XwQshT8/0VQ/I3/i+j54xi0=; b=Mo4Gi1dbIJgBRTFhly0t9I8Ki+h6TW7J0dVvHTqcSWiB5xjuAiOXyBieCiEsnecHlh jfeLmOAdsDO2/Vk8w9QQCpv3cCzJlffnQ2of1/5b2qOEibrVqpZ8wx/McIDvsc12w5JI 2yUxWptC69RGC7cuex5WLOGE1pF51/qReWtQ7/cMUhi02BSBMX297gch2JYGqGupe1Ky /CFv2cZqh4uqZZocbLP5HHjt/p7wXpHX78NnWwyOQz9vL0JGZznhAKIUH5QDVog48I9o OTsujZz1n2QGyuOC63jSs7K2zL2jGxYaXjo2tLjXkjcg6hCgfIbSY0HGWv2A3jVe2HFW 04Mw== X-Forwarded-Encrypted: i=1; AHgh+Rpzc0JFQvz7xqkKc0Ei1RhuWcSwLjqkTKqfC9CEzDjZHGwyKAtDO3cKEawsDCQc71l/lEwd/2QkfVmbc4c=@vger.kernel.org X-Gm-Message-State: AOJu0YweKE+VMle9+7loaxGGdCxKnVoEtXOOtXcAF69AGd/lWcMMa9kP dMSs8TysHQQyd+7wXLNABlr+dAzc/ilakAiSEN91eFRkrEM74WC5bbrFZ6/tsA== X-Gm-Gg: AR+sD118aigPdhEfbMgrurTUXaXs1YMOR2gc4Z8pTs5jz+/q83ZnoZpfQqjCqWyuLG2 feJfrBdTJva/DGvroPQ3tlYuU4YMHsi36GyoEhIxXs2p/tJ8fcgyWAuxmULs/3htR2+IDU3HOBp 1OKXCOkDK2A+AL6Cg+9499eGsxR28Ss+n0YvghIXVtTtNSEhFmbf4DWUmKB/2pNbKdd62nzzQBu dQRkitKnTKtB7KM9dFHAvqF03RMRrAM9l/LfAoLJPQX65r7bTlarUZ94Em0U2FzvjdlB7sGG24F zK6LR0gOSyttj5H1BLe2WoKhrXz5FTNMlAWUU6Zz9YCIWH8TKpk/5yDlZ/p/XleNohG+0pGobg0 h80hYBL/q6loazCHOkH26uMbxjM9iWontykGCevSXcaEsxz7Brtw7znbQpK0Q1m8fmRvb/5qKj6 fd5tOA1S82wL9jXdZOVpnft91KIhiPLrJZzMy3bXE+t6SvNwB9FCQceyQWj4pR5iFm4XHUGyur8 bSXtGZCBQVwaZmYkV6MeVTv84m7z1dFoxv/PiF18ZyAiSsCUrjbA6L5K7gFAHZOEV1FDPQiv0pE XL1B X-Received: by 2002:a17:90b:5448:b0:38e:6dd:a9ad with SMTP id 98e67ed59e1d1-3930106b2ddmr3589079a91.0.1786524739215; Wed, 12 Aug 2026 01:52:19 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f94d30f4sm2916303a91.14.2026.08.12.01.52.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 01:52:19 -0700 (PDT) From: phucduc.bui@gmail.com To: Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH v2 2/6] ASoC: samsung: aries_wm8994: Drop redundant probe error messages Date: Wed, 12 Aug 2026 15:51:29 +0700 Message-ID: <20260812085133.29658-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812085133.29658-1-phucduc.bui@gmail.com> References: <20260812085133.29658-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc The functions called here don't log the error themselves, but the error is already reported deeper in the call chain, so the dev_err() calls are redundant and can be removed. Signed-off-by: bui duc phuc --- Changes in v2: - Update the commit message. sound/soc/samsung/aries_wm8994.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/aries_wm8994.c b/sound/soc/samsung/aries_wm8994.c index 58e3e08225de..d189db96cf17 100644 --- a/sound/soc/samsung/aries_wm8994.c +++ b/sound/soc/samsung/aries_wm8994.c @@ -381,10 +381,8 @@ static int aries_late_probe(struct snd_soc_card *card) headset_det_irq_thread, IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "headset_detect", priv); - if (ret) { - dev_err(card->dev, "Failed to request headset detect irq"); + if (ret) return ret; - } headset_button_gpio[0].data = priv; headset_button_gpio[0].desc = priv->gpio_headset_key; @@ -623,10 +621,8 @@ static int aries_audio_probe(struct platform_device *pdev) if (ret < 0) { /* Backwards compatible way */ ret = snd_soc_of_parse_audio_routing(card, "samsung,audio-routing"); - if (ret < 0) { - dev_err(dev, "Audio routing invalid/unspecified\n"); + if (ret < 0) return ret; - } } aries_dai[1].dai_fmt = priv->variant->modem_dai_fmt; @@ -671,10 +667,8 @@ static int aries_audio_probe(struct platform_device *pdev) ret = devm_snd_soc_register_component(dev, &aries_component, aries_ext_dai, ARRAY_SIZE(aries_ext_dai)); - if (ret < 0) { - dev_err(dev, "Failed to register component: %d\n", ret); + if (ret < 0) goto out; - } ret = devm_snd_soc_register_card(dev, card); if (ret) -- 2.43.0