From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CD4033264E7 for ; Wed, 12 Aug 2026 10:06:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786529210; cv=none; b=b6HZKW4AdmkTdvP2Cipbr1PThxMC4CswGw0kvuBTr6DW5otWTRjUhLJoovHthIsbgE6l+tuJeQ/U+GeVisx64wSgNTwTJmMTs13AT1Z16xEtvcj/doz75C32t/uNFlxo+/h1q6OoZc/kXY5YaPzpqssyz+7Q3O7/+jlX7B3Y4ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786529210; c=relaxed/simple; bh=y1epoU7xtwpSrBUJjLja8qHClSLStHRQw3R7BhMo9/U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=TWzM76HDEUK9szulrC+wHwba3nlOMYUUGdMkNtM4sIUjRJ4d+sa/L01IOKmTWE5T9ZqjV6zvg/2vze9eUaq1aed7yQ+zIIvYO+N85Y3bqJAIbMD8t1XeXHNREoYQTq5Gs2yuITN0ESgi6PS09Xw7Xl+NlFPkuDId5SDkiTnT/KU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aa+yejLh; arc=none smtp.client-ip=209.85.216.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aa+yejLh" Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-38d489b6b71so965659a91.0 for ; Wed, 12 Aug 2026 03:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786529208; x=1787134008; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=FuY8RYmCvrpYmOBlOCc7chInxbHssgRs/Cgm87/Wy54=; b=aa+yejLh0QbGpMZLflgbxvHMvfd8Jvfo8onHpYocp4cwhOuOtp05DNsZ15/Y13mIfk WNa3DNX/kKJDT3PJ11OPTbajTImMKa2v4/6BTqw3K85ZhL4LHqvA+q789Hti5Ie3uDKj kXJVS5v6ZeTuTuk7jZgy0uSCR7XhnGb/toXy2WQJtYDfwoFf4AFQanQXS+bQgra52x+n Yt8eWjKGekNd8lwYPphrQEm6wJ6ACrfgAhuBEvL1ukg2Y1XR6U65KftB7GHoVHQPBcfY yHFR++xGhKQkjanp6FDJYUas6VJFyYauDcMOaEXDbN+3xrzfJr5QWviCLGqLYKPMMdun hYnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786529208; x=1787134008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=FuY8RYmCvrpYmOBlOCc7chInxbHssgRs/Cgm87/Wy54=; b=f7r4KfHBeN1nsfXj/TvySWz56o2GNR0nJUBWS+J2wm56eBbVl8B13mca8DCNQOZy+K ccTS2wZ6ZirebDWxFsK8oXTnKTFMcI9UFuLSpsVn7F4iqyfLS+d5gKnzK83qYfIuqF9G zzxfgdjuk0AFmD1covl0mfaYhY74i6i5KR04Wl2/OJmtiQq4sDY25j6Up1pDRBVxAstX HUuBtkZ/yXXNuToabkiuIKc87cLCHB6T24AFj3IgEoJpwGcc8iuudzbZ95vuQGnA/4hJ Xactc4q45gEB7jlWZlkl4lDLcvTBWLX4UacFuQJMpyMqlqmyx8iD9AXUJS3i1nI6NaNY Puiw== X-Forwarded-Encrypted: i=1; AHgh+RoWo86gSIHHniiJhrm6GTL1NINXN4jWTV1yU3dTJWS/OvLBoSsFpCHWkeEPZRGYyL2G6b1y+1GdQEJexEA=@vger.kernel.org X-Gm-Message-State: AOJu0YxoYV/tKKJh0HQxvBG41RVUPBWQ9qnNoy6Sw7ssBOIZoJ4DIYEL y0nTxHC2NNWNPmCx1DfdE4NJiF3O9TT0c5H3z+5kumlWL6lFA8w3LEI= X-Gm-Gg: AR+sD11raduzq4TtjX0NXLdGj9O3SJpz64d8RA/0YSxCyzv5yj+j4LGmV97AQzw8640 qzCvV18ojulDlA9/Kf/Rb1bNs0OwhAqBGiuelCTneAFWRV+srKd2a7jdnQnx/v784MgQMoZikA6 bO6ltrIJF0+QzwHiMSUDzSRNKoaJoeAUvSkv7QS+fqOoVYFROvUgdjftotx2PZDmthSsGEqTS1e CHVF6ltq1rz0H6TPlMpqy+vd7BMpDRxhnTSVkY9rbvfIN760dV2b2gfFuaqKktfwVRcbJOrU/Zh Enlejyl0mPzh8T7YBDLbBMfOnPHyqx8GTyd6j2E9sQly0SH6YAoq2ldDUyNvsy59+a38cZWGEgh y571JQPBpiZycQEo3mU+jlp7bqtmkI30OSaKeKR1FPpgXk84gL+G971o1CwAlYCHuyQ1gxx5OaL HT4AntXeE0LaFMAlAUwQKMH+3BYJOSKploJDtBkou1yUXNdqtar+9UrMsAl46z9MG/eY+Pw7cYn 9l2NBY= X-Received: by 2002:a17:90b:384f:b0:37c:6130:7a5b with SMTP id 98e67ed59e1d1-39301244f91mr3492177a91.8.1786529208099; Wed, 12 Aug 2026 03:06:48 -0700 (PDT) Received: from t-rex ([27.59.124.58]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf3c08163sm8581549eec.7.2026.08.12.03.06.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 03:06:47 -0700 (PDT) From: kr494167@gmail.com To: jassisinghbrar@gmail.com, gary.yang@cixtech.com, fugang.duan@cixtech.com Cc: cix-kernel-upstream@cixtech.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH v2 1/2] mailbox: cix: validate fast channel index before request_irq() Date: Wed, 12 Aug 2026 15:36:22 +0530 Message-ID: <20260812100623.36939-1-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812084742.22081-1-kr494167@gmail.com> References: <20260812084742.22081-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Surendra Singh Chouhan cix_mbox_startup() checked fast channel index constraints (index < 0 || index > CIX_MBOX_FAST_IDX) inside the channel switch block after calling request_irq(). If validation failed, it triggered a free_irq() cleanup path. Validating channel parameters prior to request_irq() avoids unnecessary IRQ registration and teardown churn. Signed-off-by: Surendra Singh Chouhan --- drivers/mailbox/cix-mailbox.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/mailbox/cix-mailbox.c b/drivers/mailbox/cix-mailbox.c index 43c76cdab24a..615218c69eeb 100644 --- a/drivers/mailbox/cix-mailbox.c +++ b/drivers/mailbox/cix-mailbox.c @@ -403,6 +403,13 @@ static int cix_mbox_startup(struct mbox_chan *chan) int index = cp->index, ret; u32 val; + if (cp->type == CIX_MBOX_TYPE_FAST && priv->dir == CIX_MBOX_RX) { + if (index < 0 || index > CIX_MBOX_FAST_IDX) { + dev_err(priv->dev, "Invalid index %d\n", index); + return -EINVAL; + } + } + ret = request_irq(priv->irq, cix_mbox_isr, IRQF_NO_SUSPEND, dev_name(priv->dev), chan); if (ret) { @@ -448,11 +455,6 @@ static int cix_mbox_startup(struct mbox_chan *chan) case CIX_MBOX_TYPE_FAST: /* Only RX channel has intterupt */ if (priv->dir == CIX_MBOX_RX) { - if (index < 0 || index > CIX_MBOX_FAST_IDX) { - dev_err(priv->dev, "Invalid index %d\n", index); - ret = -EINVAL; - goto failed; - } /* enable fast channel interrupt */ val = cix_mbox_read(priv, CIX_INT_ENABLE_SIDE_B); val |= CIX_FAST_CH_INT(index); @@ -461,14 +463,10 @@ static int cix_mbox_startup(struct mbox_chan *chan) break; default: dev_err(priv->dev, "Invalid channel type: %d\n", cp->type); - ret = -EINVAL; - goto failed; + free_irq(priv->irq, chan); + return -EINVAL; } return 0; - -failed: - free_irq(priv->irq, chan); - return ret; } static void cix_mbox_shutdown(struct mbox_chan *chan) -- 2.55.0