From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 909A840B108 for ; Wed, 12 Aug 2026 10:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786529227; cv=none; b=e6+Kd/s5ovfzpxN9S14LbyjE0H7K0vQ6v7aN3QsjwKxg+ZW6lofoIpQD0MJVneAgu2tCHy/ruLKvTdqt27S1fXQB3/3C8Jf1Uj4/YOgoi9wfJmxTpPqyBdpUOBINXsXdb9iMgDRUOl99oF+GoN2ZtanNwzNBvXLTkIzaCJ0Hvo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786529227; c=relaxed/simple; bh=rwyJVoh9c01PKTinqh5KhJ6FMfOcot9ArOCEhoix8NM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BpeRbOMgfuycl6RZNAoUSPCW1EeHQJNoHTl5TxQhnCp38acrOKxJTQpWAdxsO6c2KETChUvT8hTtZPDL5kC7NCbNSf0XI+lxUHgkXf7fTCKCa8EG8TMjTzlT0wHNtt96nkkcgIBoi/0aXF8kn1qFy2V7tffjiVmz0TQCZ4x/t7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rdbJyOiw; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rdbJyOiw" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c96c92c0980so462948a12.3 for ; Wed, 12 Aug 2026 03:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786529224; x=1787134024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=t+ISf5AH2/7pdobx9Be9aGkppGjiD1ho1qi799jRs+Y=; b=rdbJyOiwjf6V5s6gH8A+HyZuliI+YbHGmkJZ78LNgnDh5HiI8cke/xLOtRJ4k9GlKO +/dw83zhE8zvLRK3mpN8Y8ijob/lTh3yELbLyYziPgThozYBsPHsp+7bKU3CU4gMWU9R oNhVm8OVPe5vzY/m/4m7Tvji1yzErsIeoXuPbpKn900s4sGOad0FoTHfd1bKu+BzNjwB APBWTTd9UsSK/YsI0p/oDEfL56MHn2a5l6BUZ4cQjunuYeGTfujhE6y2t2rYS1Yb5hiE RYveg2g8oiQJOTPIOoQKj7rI+U1QJ+0lCY0Ip4mFszUh1uu7Ed7kJX5L79kVGKqe7fOH p8Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786529224; x=1787134024; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=t+ISf5AH2/7pdobx9Be9aGkppGjiD1ho1qi799jRs+Y=; b=CdrHkJoBXOVTNlkKIMLP5BK4t4068MW4lt7CruVNFje61j0cfi0aslMXQHBAaRk4cT qoSkFBc1uO9V+HMIud9A7+VAvXb3YyH62FTxi2FPtggPdYnm2opJ87sPJiOKRMedgcnF JGSZlQKv93u86nOQzw4vmWpcDon5KYHNUSWxSz+cvk3VMQWHNws21t+KYX2wVcWoWquD VBkECqO45HBm0Ltg8Ng6bn1X6rkea9TffAJddXh2ekvSrjhLH4h4SxWYZvY4/TOR8yz6 9GqBDlQjUyi1wUdC/SyZ7f+XN5rL9YccwwQ9xRIlTI+yB1Yx9w1Ori8KSOzZI7ReA2dC wKRg== X-Forwarded-Encrypted: i=1; AHgh+RqH8NQ1MGxCEN78TbhcOJaVIG2Um+sPeSg+AmySUUcue9Ewu0fxjo5uQPyuFlvAnHdVdodbp1vTCAIebvM=@vger.kernel.org X-Gm-Message-State: AOJu0YwGzsehuWk8/BwNhYyAnTm+G1s8g8FsThzAQFyWCkpwaGHNwC+E erOpH2ZK6dpFeNziQa0J3ao5CkVZlxc77n8hCiIjNOn/NpzWjPXn+24= X-Gm-Gg: AR+sD12rSZb3vXhENSmyNxxwQ4Pb5DSiMtL6yYOznCRkjeecVhRPt97yZbF9vUWzMoO F6zlMvkuOk0bsS8E8RacmxvRLT6yjDWRdwzuCz6usNLHHRQmnrl8LjpX95KfiUjHqlTMUETbMXO e5B+3qvi4OkHbKv8nA6U/e7AEGsROvcKh3YDnaHogOuBpywC9yqYBKNNc+J1O4bVJs2noO/Z5dG NlmT07+zBhq12Dg2JjdC/QA1A6/Wqjm7q5jhEkZILOKBSEusL9z8JteZ/rUOV38W6Bni/zUpQUx RzXV6HK9QvLhIYUp1w9MF6o/mii9dBybeKa0hHrhuho3EtAcVhAqTtuFIwLS/zZ6REkP4SZqyNm u32ACcMa2QZS6Lb0lUebCuYO/1Cc4CvwY6saL0JEJ69cM0DadtBQGI0bTzNvAWz62Jj9DjFpOUF PRveI5f5kXZBybbz+PeSbl5jNIxg7yiOy34P94Q9dufJALJaziXALfOQu5qi0YI3/h0OpafSD+e zSaYn+v3BG9gapbSA== X-Received: by 2002:a05:6a21:6e95:b0:3b3:fc6:622d with SMTP id adf61e73a8af0-3cc3f868931mr3891421637.38.1786529223659; Wed, 12 Aug 2026 03:07:03 -0700 (PDT) Received: from t-rex ([27.59.124.58]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31cf3c08163sm8581549eec.7.2026.08.12.03.06.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 03:07:03 -0700 (PDT) From: kr494167@gmail.com To: jassisinghbrar@gmail.com, gary.yang@cixtech.com, fugang.duan@cixtech.com Cc: cix-kernel-upstream@cixtech.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Surendra Singh Chouhan Subject: [PATCH v2 2/2] mailbox: cix: fix DT property name string typo and use dev_err_probe() Date: Wed, 12 Aug 2026 15:36:23 +0530 Message-ID: <20260812100623.36939-2-kr494167@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812100623.36939-1-kr494167@gmail.com> References: <20260812084742.22081-1-kr494167@gmail.com> <20260812100623.36939-1-kr494167@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Surendra Singh Chouhan cix_mbox_probe() logged property error messages referencing "cix,mbox_dir" (with an underscore) instead of the actual DT property string "cix,mbox-dir". Fix the DT property string in error log messages and convert probe error paths to dev_err_probe(). Signed-off-by: Surendra Singh Chouhan --- drivers/mailbox/cix-mailbox.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/mailbox/cix-mailbox.c b/drivers/mailbox/cix-mailbox.c index 615218c69eeb..fb5d7641ba90 100644 --- a/drivers/mailbox/cix-mailbox.c +++ b/drivers/mailbox/cix-mailbox.c @@ -585,19 +585,15 @@ static int cix_mbox_probe(struct platform_device *pdev) if (priv->irq < 0) return priv->irq; - if (device_property_read_string(dev, "cix,mbox-dir", &dir_str)) { - dev_err(priv->dev, "cix,mbox_dir property not found\n"); - return -EINVAL; - } + if (device_property_read_string(dev, "cix,mbox-dir", &dir_str)) + return dev_err_probe(dev, -EINVAL, "cix,mbox-dir property not found\n"); if (!strcmp(dir_str, "tx")) priv->dir = 0; else if (!strcmp(dir_str, "rx")) priv->dir = 1; - else { - dev_err(priv->dev, "cix,mbox_dir=%s is not expected\n", dir_str); - return -EINVAL; - } + else + return dev_err_probe(dev, -EINVAL, "cix,mbox-dir=%s is not expected\n", dir_str); cix_mbox_init(priv); @@ -611,9 +607,9 @@ static int cix_mbox_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); ret = devm_mbox_controller_register(dev, &priv->mbox); if (ret) - dev_err(dev, "Failed to register mailbox %d\n", ret); + return dev_err_probe(dev, ret, "Failed to register mailbox\n"); - return ret; + return 0; } static const struct of_device_id cix_mbox_dt_ids[] = { -- 2.55.0