From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C46415F27 for ; Wed, 12 Aug 2026 10:34:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786530860; cv=none; b=ZHkHJWOZzEgi/mE5aAYcN4Ieai5Syu5JUX4yMEj8uXH4uTEeTBC2l5/bGZsQZEedfnkGqYm6SFRHZ8frbsGAqYPDnTEXioIfKOhmlLNP0r/Zrlh53efRY0Z0mJxn/529hCPuw5c4pLKk8huGz9+35zsO/7QbOFAhPauk1BrBT6E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786530860; c=relaxed/simple; bh=QslT1uo1hQY4U0PYOxdmrfNftOyp47nQCRupknM8Y00=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=B5252eQiMi62PaCMYU+fHM65Oak+tGN/3uRRZYaKtaxLPXhq5+DIZeAP39UdWrt2T+CqaRIBeJz85Hxd2ugj8X4sigaJnnjUmw5gadDWSmslYd61Y+XyjxMqeWCoi1/cZWijKFCoPGR0zyAKkDyOA94QxEO0dlM0k8sueo7Z9xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=X5homJhE; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=uFmrTfXf; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X5homJhE"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="uFmrTfXf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786530857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r8qWubulphdV1XFUWAhJ9CU7Q89Wk0Bg4x3ogs9qX78=; b=X5homJhEvkHSiUrhai4rYbdVrBqod1PG+oCTkkYpfmOYq9h+VB1WgqKIvN2WQNpANK8ZT2 3Qm6Bmsw2SSzJgIoZfgVjpDAeyjqsshsuDA2KKjG2vFqam+Vy2Seaw7lWogZqUJkQz1ym3 hD4OhFLNku03eDeUGLwsmrhxF2OO2uw= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-k3uT30ujMrKeijJKGsURRQ-1; Wed, 12 Aug 2026 06:34:14 -0400 X-MC-Unique: k3uT30ujMrKeijJKGsURRQ-1 X-Mimecast-MFC-AGG-ID: k3uT30ujMrKeijJKGsURRQ_1786530854 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-38fcaa5f82cso940771a91.3 for ; Wed, 12 Aug 2026 03:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1786530854; x=1787135654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r8qWubulphdV1XFUWAhJ9CU7Q89Wk0Bg4x3ogs9qX78=; b=uFmrTfXfRJ5GcMvWE+F8RVFESDBO4Qk9DhM1sCNDz02VP6sWknqhq6k3ypWSVkZ9N7 sdVsSswEY5b/DxuXZU7v0Jrjh4xeEiis8fAzzellx8eshMmzaeQr5PptezyxWuOoKm6d Ujjsd2Q18IeqJD2jGJT/OKpg0B868HQTOFC30WDXX0BOZtIoLifPsAIIbdTJyPCnsg9S NGHGlITHOzz6afMJh6G4EemnB3CAT8EvDE7HSDOTIj+ZfYbBq1ZSYcD1cpw7vPx7EAQ+ YldoJVXpeknv6HbQdLVNEuw4TlMRuqwPSW50sx6bJH3vYYoVwVxay60J9B5srF5XzTiN 2lVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786530854; x=1787135654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=r8qWubulphdV1XFUWAhJ9CU7Q89Wk0Bg4x3ogs9qX78=; b=G6h7tBShgs4U2RI9kdfLqAZL3c+4JKX2UrJsmQDYnS1HJcK8XUNB9cVjNcFMfbiGvv ojhAymsXmB+XM/NyGo7xh69yjTlKWMtaq9YxWj5hm24qmhGBNGIDAx/dYklXtwLp6nHR mZORDwHq3nJs90x7XT3vyAnzcq8fIZbfH5euyPB0xAHE0mpHgrcwGhR75GY77VkwDuYi oZFJELR4/H36V9Ush2/ThDVCaau88MQ4U9I9C+h7l0NVH+LT++S9q5gegKdsWEhSsJhU Zu3RqxQkIgZNaol9hg7gbuewWj4n1jbpb2DP4+u+gILOa5xApPl37Fxt5GrQblh5oXVc +lRw== X-Forwarded-Encrypted: i=1; AHgh+RodnkjMZ63NcB0gukMNSnTBGkxPqSneZ/1rE+p5kW0wtDxAPWeHGbR27QST2g0dStGmvEDHnU2/6CqN0Q4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+XDVs3pNTiXPEBTgcl5ME7z71QxAi8v3jA4w26y88v2GInoWE ghBQ0nOUWycG6CoDgSr4XJ7iiCJHrhYw5Qd5c1fJccqp7P9mPe2wEL8n+484lhqZykjf/AyfJU+ l3eh7gmvNUG+Fs7OhL+c6+4FYgQ4htV7pBgkmgXzijbRVYT/O6Xxb6VaAmr9149vAKIXZYfT9qx 8/ X-Gm-Gg: AR+sD11sUxmNpziPhPc8Q0aEg+bjWiXyc0sh6h8+qGKJhpBQFwfZVceenmzzgkHy0qb Zc8VpfcRej1fLDuA05o6OKG4GXZk5Q0RZPezJeYooeRM3dkye33ZPVhBCuXBSFtvj06BjlA/Iga iF7VVBaHdg0B+VNNPwDxr+gQGbw99+lbdF12KHzQcIte/VevRjaHX8Ad9fo7x0rsL5zSfIgsBEr VFAsr9hMrs/BJTHzRMvtgDMAaPl+4G9P87rQ+FZ1xeerBanPUicRdm46zTmMSrDyUvnaKpmqAgl oZrjDgwo+kgPdphWmSpmRLqghpXa6K9AYLK6OA0cUN+SjWTTj1kOuW2tx2h/mTrj24pDZRRe0bo fpoZ8hJ7o0ynjJLZqt+sVtpykIFCnGinQWv5wnMXH+hooHURiWmKklHUt7EsV0bKJj4T9 X-Received: by 2002:a17:90b:288b:b0:38e:f6eb:2b38 with SMTP id 98e67ed59e1d1-393014944a5mr4243058a91.17.1786530853639; Wed, 12 Aug 2026 03:34:13 -0700 (PDT) X-Received: by 2002:a17:90b:288b:b0:38e:f6eb:2b38 with SMTP id 98e67ed59e1d1-393014944a5mr4242998a91.17.1786530853165; Wed, 12 Aug 2026 03:34:13 -0700 (PDT) Received: from mgandhi-thinkpadp16vgen1.punetw6.csb ([2401:4900:88fa:3d3d:2349:1310:a2eb:9912]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f9675e32sm1031413a91.0.2026.08.12.03.34.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 03:34:12 -0700 (PDT) From: "Milan P. Gandhi" To: linux-scsi@vger.kernel.org Cc: "Milan P. Gandhi" , Sathya Prakash Veerichetty , Kashyap Desai , Sumit Saxena , Sreekanth Reddy , "James E.J. Bottomley" , "Martin K. Petersen" , Himanshu Madhani , mpi3mr-linuxdrv.pdl@broadcom.com, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] scsi: mpi3mr: Fix target device refcount leak in mpi3mr_sas_port_add() Date: Wed, 12 Aug 2026 16:03:44 +0530 Message-ID: <20260812103344.174247-3-mgandhi@redhat.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812103344.174247-1-mgandhi@redhat.com> References: <20260812103344.174247-1-mgandhi@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mpi3mr_get_tgtdev_by_addr() increments the target device kref when it returns a device. If a subsequent error triggers a goto out_fail after the tgtdev reference is acquired, the reference is never released because the out_fail path does not call mpi3mr_tgtdev_put(). This prevents the target device structure from ever being freed. Add a tgtdev put in the out_fail path, guarded by a NULL check since tgtdev is only acquired for SAS_END_DEVICE types and the same cleanup path is shared by earlier error cases where tgtdev is still NULL. Fixes: e22bae30667a ("scsi: mpi3mr: Add expander devices to STL") Signed-off-by: Milan P. Gandhi --- drivers/scsi/mpi3mr/mpi3mr_transport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/mpi3mr/mpi3mr_transport.c b/drivers/scsi/mpi3mr/mpi3mr_transport.c index ea2c04384a0e..232af978d737 100644 --- a/drivers/scsi/mpi3mr/mpi3mr_transport.c +++ b/drivers/scsi/mpi3mr/mpi3mr_transport.c @@ -1507,6 +1507,8 @@ static struct mpi3mr_sas_port *mpi3mr_sas_port_add(struct mpi3mr_ioc *mrioc, list_for_each_entry_safe(mr_sas_phy, next, &mr_sas_port->phy_list, port_siblings) list_del(&mr_sas_phy->port_siblings); + if (tgtdev) + mpi3mr_tgtdev_put(tgtdev); kfree(mr_sas_port); return NULL; } -- 2.55.0