From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0AF243A80C for ; Wed, 12 Aug 2026 11:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533536; cv=none; b=UnUYypi6QlvQxa5Fi9tZnyi9eVJq97ob1qrrr3azALcRRPLxNpSElel+NEZqcrr408otxE/q2C6xtjH4l5/yL9iGxUAL7mrVOVwa8Tv4nx+ZWcbblA/I73qkhaxiCqtFquVZupjdxdXmfPJC6yKl3C3185SUIIZgS9ncXCsa6RI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533536; c=relaxed/simple; bh=rhIU1zG+Cz1JEJ/DZCxK23rcEZYVi7vpJbqoVBA+2qQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oyW69o7BFS7m1p182FoYJiGl78+M9glWLSOcM5Iv0foiMm46poQVM0eYHR0CYgM+0LL8u1Ej/DtZiX9FtQHVHAWh6aqJvgz2YwbGjRpUZFKn6BcEMzB7FnIymIP56oZxuEcZ3L0HDUdCh8jC9718kPSEA4cJdOQTUey9chtpGZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eyDDhKJQ; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eyDDhKJQ" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-47f92e3c14bso642543f8f.0 for ; Wed, 12 Aug 2026 04:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533533; x=1787138333; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=TzXAlvJrvz8VJKZL5THLFAhA3g1WFYpeVuZ+6qv41B0=; b=eyDDhKJQcUn/6qaVG70x5845SB6g7ihlqCZ1k9C8xA4s08vUsk807yQ2iMtWsio3AR eyWyrgb7t4KDldnvAQbkbVKu9qRmGkn8fyAb4KLpFZFPN3VV4L+kWVJRpgedCGc3rtS1 RNwFF3phhL4r1S04kTxp3VeywprfsEVJ4QIOBUGJYt8zZtMsXQYIw+WMa1c8yXcXI/Hk CyWCvNOCnMkPfCeVphomyYmgSylyVP4OV011SyQKlB+nw038Tea1oPI6Zss8wvXxUnCb JCer5DqazN1QUHGUOAyJkS/691E3Q9hpy47cZAuQyykkXhxzJYgH5Z4Kdn23CPmAWgdI hKEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533533; x=1787138333; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=TzXAlvJrvz8VJKZL5THLFAhA3g1WFYpeVuZ+6qv41B0=; b=PgYr9Pq9PuNHq5U+0UjD79nNaf+682hf80T//s5s65mXQuvWQdrjFPgRMXhxrhfTOM sfvYHhWQpPwd/6sTEpCvWIPymKLSft3BSBlVMyPgezF6v99fW20+KURcu0Wwc55rzPK1 fJCDwJcP5TFdH+V9jgOkBwAPdNp4qRTdi8wx0uA7TSy4/BA9Q29YiqHi/BSIIWQvnbAV 2/FIrOJIx8hqRSbHuxRNKoecBS5Y22K07w8+Z0ai4ouGyPCK/ezkiEgjas+3FUw4tL4O IJaXfyR2bBAnyCp71tkWOfefd7pZvQlQFbgshraZWguoOd9klCrMnQ+Tx6NOC3e4jhWA D1kQ== X-Forwarded-Encrypted: i=1; AHgh+RouKGsjyzfG/eaFOIB+PazV1ymEGn0v6W0nUUqb6bhh0inz02QUvV4yajjt3Y1NbS76Pj/VyNFNhLBXySE=@vger.kernel.org X-Gm-Message-State: AOJu0YyyjN7+/w16X0IDGCUnktwSqQlnZDt4kvfQ/wfMylcEfhABTjts 9loiWkgndYkM5XLB54yBdzJBJFGcixwDB0vJBYYzEZp8GVtmZNhrB5+C X-Gm-Gg: AR+sD11MHb/pM/URMz/b1tzJKXrJyQnYmFGy5i1I/w31cj+j8+YMueZXar2q8bhtWgB 0zd0usGe7SY0y0kVKulgKgzOjLAu8BXKbH/VQ0DbNdMCZXotk8ak4yqB6pQWo9eFiiid06QdPTr o1f5otQkQIj3PTvUOcTVTLS0Yn0qpfVocd18WRmLGSoWaNL/6X25Ni8kB0OJg7IGXaNONimWQOd PM0oD44N1P7cYwS7BQRntLYI5Cv2furLckNaAN2HLPZlfgsYE78UfRW5z/NL/Z8MRW0GcV8Kgrw zvQtnbWfQN7tC+wbEf0A80UnkT4K7wmVZREwKGRJSMeWbtDnU6gjQqkeLj/K0fHbsJrkR8/sF3y IzAnxnAfyLid8QSOEx3Q/vzZnlBg/ZR1lqR7A9tmVmWG6woFSgK/+Gdl9lUh1Y5Dx7uP0FRH7hx Lolucs5VvIshaGHW3XdgFDGL3V+6m8TzT0uZsXnb3YTmBP9kyNk0xJfxkkjEniMEqOE7y8tUmYL hMKTMFjJF59AGEwpMHDABsS28/EhZvjysa7icBB4Q== X-Received: by 2002:a05:6000:490d:b0:47f:ebe3:ca31 with SMTP id ffacd0b85a97d-48152dfd065mr6373537f8f.28.1786533533075; Wed, 12 Aug 2026 04:18:53 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d702c9sm6670072f8f.34.2026.08.12.04.18.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:18:52 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v2 7/9] platform/x86: hp-bioscfg: fix new_password_store overwriting current_password Date: Wed, 12 Aug 2026 16:18:27 +0500 Message-ID: <20260812111829.172273-8-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812111829.172273-1-meatuni001@gmail.com> References: <20260812111829.172273-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit current_password_store() and new_password_store() both call store_password_instance() with is_current = true: static ssize_t new_password_store(...) { return store_password_instance(kobj, buf, count, true); } so a write to new_password is routed to current_password instead, and the new_password field is never written by either sysfs entry point. Fix by passing false from new_password_store(), matching what the is_current parameter is meant to select. Fixes: 8646a3b5ee3a ("platform/x86: hp-bioscfg: passwdobj-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c index acb123985ede..6bd56d3f5bd0 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/passwdobj-attributes.c @@ -123,7 +123,7 @@ static ssize_t new_password_store(struct kobject *kobj, struct kobj_attribute *attr, const char *buf, size_t count) { - return store_password_instance(kobj, buf, count, true); + return store_password_instance(kobj, buf, count, false); } static struct kobj_attribute password_new_password = __ATTR_WO(new_password); -- 2.55.0