From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6EF43BDB4 for ; Wed, 12 Aug 2026 11:18:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533540; cv=none; b=X0AxG6/92CXdh/vgUBaVkIiY/tsptLpVki5RSHGS1PohzSChp7xbzni4jPjBGsHjoTSvVIk3TKjYedYljx4eHV1mU3jbTQ6sU+U3tq9fOY003R6aieDpTBBEEuM8+pEWYkWs6E1Chpps7GZmG73O6fFFObzjTUqWbqB14ylgZ0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533540; c=relaxed/simple; bh=ZqVUWs3x1BgozxV3FrsSk7Lzh34dxSnwsmeX8ZrIYuQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lFaMqHpKbISiCVvbAp8o4u1XMupOnGengTeJowPkunTFwgOkLVowJ2o4CQMV7N86VgcNLG65e2Z7a2Pjtik6g+HCJa+m/c2Q926e3AIQhEB4P1e5/3bcQnTCrS2yqxh4Wv/UEqj7nqwP0e9U1QRyZnWTOfcgIAKJW42/qQ+eI7k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PX2VFpLg; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PX2VFpLg" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47fde295992so628576f8f.0 for ; Wed, 12 Aug 2026 04:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533537; x=1787138337; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aGNNvpeBB2xFe8o+eAG+ITw+sBusoz0y2d8gJ/h4GCc=; b=PX2VFpLgt9rPC4lsIJ82yrS9XEqQVu+xI6CLJaQcPVxf/xvPlghy7hZ2Uk1LN2RlOT 1UmyaM0Xb4bH+QEX1LL9yReaqG6UwD9THwbSFqYhB9VV3ecyUM2j7TH24FBM+ZGhtQc+ F/Vc1UBZWvM3eAnMKR4/SZAsL9fST5KGYUyJQyaplCODubYJ/q4XiaDiP++KD1BfXqw+ mIvneW+OkI5wFnkPSV6KpD4v6aICpyV3fLONVU6apzquqQR1n8UVboqjxfn58oJgLtvH JtVcVNbiKl5hI6RwcZgn4qTBYLj1s8tbFtxgzr43kZQuT+g6c7i0HKBTh3tI+UvkE9am 0rmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533537; x=1787138337; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aGNNvpeBB2xFe8o+eAG+ITw+sBusoz0y2d8gJ/h4GCc=; b=La4ng6Xi7l0ZG9R7eiMzDW2EmEkQDnuLr0Ie+PKOuuFSDCvpbQ/Y1f7JeTSGdEaYYb zW8v6/2rAvhrNgNem6/LpUtaaNxABW25ElahZlF+G9LW70OWXJiSQC4G2l1ELB98/ZbI PFN8SZ0IDgmh06aUTlS7uv4URWS29/5sRldUmppEswb2FqmqqMuocepFWo0TyHlRrk3r QHy6qqxw0ndR6gobGdZhQrFlCQRHaO65bFmm6H5CQGpbhjN5rYFzKfy5/z4rwZ6Mh04b OdPymUw7jKDckzXgAXJFzHZnF6jAVImeMzLOIvXahjOvZ8kakT7jt1hay5KdVJzH85yA OIXw== X-Forwarded-Encrypted: i=1; AHgh+RqcCkVOcphUO8TUmFHXVJR/dHUs8hxLItw6VB1rhq6f3UUFx0aPhk+SbzDlLALwf1/Aw6wT2CEOySErWGg=@vger.kernel.org X-Gm-Message-State: AOJu0YwnZJmhZ9sKs7SISClpVbqMGs7KiQgeAzRCH28sE8fvhtuZrzMe e6Z65Bh4F+gMHyZYlLHBzVVD+f97miPd3ldXH0JlPjt7eJeRicLjmEvo X-Gm-Gg: AR+sD10rWWHrzk5SaAxgIrJ5+VQxoRvMxC19aKkTM7zZzRBI84J9LoMvxmqCgb/cZFN GCl2PjPAnpr8a5BkRDloz1aP09dfqy/aLL/gdiyvhq+2Tu7W5GC8FEXr9v+9SLoRF2rALWf1Bp0 O24/NWu5FFiNyx+XoNlneviOEMnO7JDvvlsGrHA8a16puIwNj0yvxrIhgDt1P4qf02sqTgZ3vb9 8WbCTUB+49oUqhKJ4/hd8vge7yQ2Owhhc/gCvy7N6ea1pP1wPORfKJ6AG4B70TsEhC4TC73p3tc gud3reADCB1cyr/dUZm7FAiRv6ZADqDpHDyUIEMV8GTYYViLZFHpr7ydX4K7C52zMpiYHF251Gw 6k4s6y7svXHU7CTvmhkvvuGftRfFvENfR9U73fDpA03ev72Z9KSz24rpy601AVRGDJ1U+IfCQBR 6oZhfK/cywcoYmqGTzkmurXqmEFT6THB0oUrUZRmiNYlmGdBD1wdlXFxSYZ4n9fj6tAclIxyx8x LtdKSzTJVq0KNacQ/t8IbTlFTAhrtF/FyGBEn84Gg== X-Received: by 2002:a05:6000:461c:b0:47f:71a0:c060 with SMTP id ffacd0b85a97d-4814febaf04mr11662868f8f.2.1786533536719; Wed, 12 Aug 2026 04:18:56 -0700 (PDT) Received: from fedora ([202.47.63.86]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d702c9sm6670072f8f.34.2026.08.12.04.18.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:18:56 -0700 (PDT) From: Muhammad Bilal To: platform-driver-x86@vger.kernel.org Cc: jorge.lopez2@hp.com, hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux@weissschuh.net, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH v2 8/9] platform/x86: hp-bioscfg: fix ORD_LIST_ELEMENTS never being parsed Date: Wed, 12 Aug 2026 16:18:28 +0500 Message-ID: <20260812111829.172273-9-meatuni001@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260812111829.172273-1-meatuni001@gmail.com> References: <20260812111829.172273-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The ACPI_TYPE_STRING case explicitly skips the string conversion for elem == ORD_LIST_ELEMENTS: if (elem != PREREQUISITES && elem != ORD_LIST_ELEMENTS) { ret = hp_convert_hexstr_to_str(..., &str_value, &value_len); if (ret) continue; } so by the time the ORD_LIST_ELEMENTS case in the eloc switch runs, str_value is NULL (it was freed and reset to NULL at the end of the previous iteration). That case then does: ret = hp_convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); hp_convert_hexstr_to_str() rejects a NULL input with -EINVAL, which sends this function to exit_list, and exit_list unconditionally returns 0. The net effect is that any ordered-list attribute with elements present silently ends up with an empty elements list, with no error surfaced anywhere. Fix by converting the current element directly, order_obj[elem], the same way the PREREQUISITES case already handles its own array elements, instead of reusing the unrelated str_value/value_len left over from earlier processing. Fixes: 4b2672ec71a3 ("platform/x86: hp-bioscfg: order-list-attributes") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c index f09489a085c8..704c69c18146 100644 --- a/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c +++ b/drivers/platform/x86/hp/hp-bioscfg/order-list-attributes.c @@ -261,7 +261,9 @@ static int hp_populate_ordered_list_elements_from_package(union acpi_object *ord * Ordered list data is stored in hex and comma separated format * Convert the data and split it to show each element */ - ret = hp_convert_hexstr_to_str(str_value, value_len, &tmpstr, &tmp_len); + ret = hp_convert_hexstr_to_str(order_obj[elem].string.pointer, + order_obj[elem].string.length, + &tmpstr, &tmp_len); if (ret) goto exit_list; -- 2.55.0