From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C5C540B108 for ; Wed, 12 Aug 2026 11:20:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533651; cv=none; b=IlEA23DAS40F7F5TXxz0gYJpUICB+JI4fsAsi6PHASIB33lAYpu26UODFy1Xx/8sgjGCYdDl0EZElXwaErUB+7xD61uUJi2Kh3JhuWfl/bL79ZJZoTRC2Vz3SBy3AoimeUI9jHsG4hkSzscZAk6keLQNCD+IFRBY+GqsUq1QzS0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533651; c=relaxed/simple; bh=+4UanzD44hCJmgC20DfI+OizByBl/tAq1xq63Nt1/hw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FyawYm5xb9AGLKxtfcglwWldI371yf7WvxmmxfUcQVrhHn+Qlm4PGv8QBvOSc5v00Vjhwv6frJzIBMTqw+a1mTqiFfrvY6YTrkscd9pXDzSwNSquyDzwhVj0DFRua/3+h1PYIY5HMK33pfCizGbnrn2/lN4LEOfO8gwsBNna1d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kA0Dt27X; arc=none smtp.client-ip=209.85.214.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kA0Dt27X" Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2cacb8416a1so10510655ad.1 for ; Wed, 12 Aug 2026 04:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533649; x=1787138449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qtuJK+NS7IlYpY3lUfxDpExS70jRA4KXDLtMxQhzExE=; b=kA0Dt27XPEg8AtDqlD0/tIcghWKbcJGQRYwtWBnMi5h1o/lY9hCX/LIRMZjwEU+cYN hUIxUtDwA7AnWCwNEiabIKgrDOjFsZ2w9m1jUd6NyEMx/IVoSaxp/LfnFUbmgNvdx3uX WyeuxYMUw3j65Is6w0+n7JZQIE1SHvj6yG5ivTfOccm3adHzEXheXnGRsLGYGNREJ2mN 13vIrBtXkNngk76UBJuCaAUcMsABZmDneXd0WR34RLPRir+BQIRpv5nuQGRB2+yTCTWv WKDxCG198/NQcLLxQDTRXW2Fssx9FhPKoDODPxq5d+wDhe2cw2Dl/COqq+HpXrxntTwl 5IRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533649; x=1787138449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qtuJK+NS7IlYpY3lUfxDpExS70jRA4KXDLtMxQhzExE=; b=N0eMakJhpgA+TM4ApiJt+J3wHCmpH/uIbBAHjohxr3fyVAK2DsLHaFbaPkHwUblEhn xggsfLcYx9f7/bgFPPvfIzP5HvrhnCf6XVjYCe/QLphL2UgEqi9oBGf/dkQ0qMe8JE1J HAyamwX9u4SJeB2wN9hy5CyAMMVBYGkrUW842ZHyH9jEGU7xHXhA6WpufegvnD5MJ0MI 4vV1SFxYfhOkL+IPxGV8wu71cb6fqUigj0LPxCtgxjZv6737IgTWL/MF/X11HubANRK/ trHh791PYEI34cQQIb9i4mRJlukxZzSIR2ebcmqx2Nq/inDhFtUNLg9/HO3PCLzydW4J Zk5g== X-Gm-Message-State: AOJu0Yz1KZbqZ+xohLIVEJ0PN3KWd4pbyDl8RSe9IHPciHxQ1MTFtbDO R1toMglhThVwdDd5T8/NooRwrqMRKPjXbHORhQd+GTDbRIRI/18x6NYR X-Gm-Gg: AR+sD11prtxh1g/tn2VCktir3Mc8YnOUyH6reTe9itON5eb7VawaFHg5y2geQCWRp8u UxSUuTsCTUwOFs78BEIVkMcxu9ZFgTCgMJj4A/o6xxQbBT+GP5BiqzsED5agXhs/czggl1lLIub C0sLUcyzKWv0OPnNN+dwxuCc3XAOBHUErUxD7he+OeWHpd3iuD4WuX3pfnRldeeWJbt0Ag80rJ8 Jbdc2NvIVKMefDUtJl7r5xaN24QGaAutGL4QDGb9byPZOs0rHXEKCRDlxhSo89lMPWNAy5NQSxV WRyzKDrox1lw48176cY8uht/qndMqYaLCqBHs8vVNIFJSscr8/tDIytRxtUldZBYpwjZHXHfmMI Qni6q31/ZWct4udYemZa3SG8NiVdAZXAatj//e4NhYW2Yt4dUbeGe1aFOz5snqcPfIEwakNWCKh xJju85Rk70/ESqWTYqMv9NaN2SfUEHG6Kmy3RhEVS0OC3e+ky5go1R0qDxDqTaStHJVJMeXOk/e QfruJ/XUps850znkbBN49WmyyY8rYzu93QM3OuwtoEQJjQUWkGRSmCMHOIViRzf8YH9oBhjMCwx c8/O X-Received: by 2002:a17:90b:48c7:b0:38e:7168:281 with SMTP id 98e67ed59e1d1-39301490a70mr4771248a91.10.1786533649457; Wed, 12 Aug 2026 04:20:49 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f935f5ecsm3193765a91.5.2026.08.12.04.20.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:20:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/3] mmc: meson-gx: Handle errors from optional IRQ lookup Date: Wed, 12 Aug 2026 18:20:21 +0700 Message-ID: <20260812112023.42254-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812112023.42254-1-phucduc.bui@gmail.com> References: <20260812112023.42254-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc platform_get_irq_optional() returns a positive IRQ number on success or a negative error code on failure. For an optional IRQ, -ENXIO indicates that no optional IRQ is available. Other errors, such as -EPROBE_DEFER and -EINVAL, should be propagated so that the caller can handle them appropriately. However, the driver currently stores the return value directly in cd_irq and continues probing. Propagate negative errors other than -ENXIO, and only assign the IRQ to cd_irq when a valid IRQ number is returned. Signed-off-by: bui duc phuc --- drivers/mmc/host/meson-gx-mmc.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c index 694bb443d5f3..af94c8138fcf 100644 --- a/drivers/mmc/host/meson-gx-mmc.c +++ b/drivers/mmc/host/meson-gx-mmc.c @@ -1185,7 +1185,11 @@ static int meson_mmc_probe(struct platform_device *pdev) if (host->irq < 0) return host->irq; - cd_irq = platform_get_irq_optional(pdev, 1); + ret = platform_get_irq_optional(pdev, 1); + if (ret < 0 && ret != -ENXIO) + return ret; + if (ret > 0) + cd_irq = ret; mmc_gpio_set_cd_irq(mmc, cd_irq); host->pinctrl = devm_pinctrl_get(&pdev->dev); -- 2.43.0