From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9AE38438014 for ; Wed, 12 Aug 2026 11:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533665; cv=none; b=hJY8dQbAikMiA/+foIZTzDKFUBFEJg2vHWFMoChUstbvPbTiW5+bPhOkNNl1q7KPeLC5W8QLOSPRkRv/FuzJ4y/1YsyHe7UJ7Tp4aj4GhpfQmZIazwOd+EqJFs6oXKQ1bFL0S51YXHX5gdWpFrwqw4oV/cYzp7hMAgOIX69Ej9g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786533665; c=relaxed/simple; bh=AQEbC5gXjnq96gD4UbxnJsrrXRSK8uBtmRVGLbSyuhI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ujXtWgWTT/JKn5dXDx6GU+eJDUk9NQ04/0MX4sVpS1ffvCJw+pHLA85XK6YXusoUzRwXygtWLo/EwNa18TR9xBrFFmvUJ0tnV/JZw6VDceiZ3Sh2WuSMDfs3W1nXNIn9SCCY8bwJIWX9yYJEIsSYYLWhor/mpoOKDDAlfOYqGkQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lILSSDuv; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lILSSDuv" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-38125cebfdaso1418568a91.1 for ; Wed, 12 Aug 2026 04:21:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786533663; x=1787138463; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=doym3QyHT8bL7rPyfRL2QEekEkOSH3JrEcV5LcFpHT4=; b=lILSSDuvd2PlLtSY2uzE95zBDvcg7bHZUUirPl3InUMuTh2qaUI/6tE4xa3QMTEM3x jSyMm55r0wUSVbMWwZ9oCu00JELdehFLAhwGdOPEkeaMKECLGsZfVmgbQDk7Ty/swtvK F1LYbqYHJpfu4A99pxObUQ7lT0sEJoa1beWeykipkHk5pK6TXYx95u+2V+nd2cimONV/ qaQXWn0vDvUxhc7ZLPZGSGQIxkudK7BuM+Q6e/f34dx4LZLySSoWhXGF/42rVyXUgkHo dUp11x0cgCp5OILA/wFYkHTw5KZypIaytF/ncOvE00WcydcDBw/gZ3moCpopjKGk/b9u 6GvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786533663; x=1787138463; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=doym3QyHT8bL7rPyfRL2QEekEkOSH3JrEcV5LcFpHT4=; b=cNO2dn05Z1p2gom2NBEMf+iZukdk330ZOCeyTxKKh80oixPAKjnKvzFwSXJaCRqK1s LxynyNcSjTF0vL3W86VXuOrjo3mqjMLbYp1NspdIuxRLW4UfWgWLg32mR1sTULUHEPh1 +F78MS9QQNfy6xzIAmGR106yEBMCJgIUBGlPn1ypvMTd6fuLs/5igDd597/dHdIUPqV6 UD+ipSQj9kg1UUYDbpMCOARl1+udCYT2peOgXaIQzfTx4U9Y4kl6ahJWBd0bHYRUa/0c 05Ts2W6K6kZr+P+amxtDXvyfWgQOguiHWnXRDgw+ooAjJF4N8sopKOACZCWy1GPItgmM /WNQ== X-Gm-Message-State: AOJu0YyJfOlpN0zCM9ZIjECmo5le2R/59Sh/Qpp0Z1VO3VZ9hehchgj8 H8fgpGs3XDvPdMXNdPs3mLlI/sFTqYkgXlJEGF0/YBu9MdmCzwGsEdJ5 X-Gm-Gg: AR+sD102c82lPa2dloJkaIh+5+PGhu6YGSS6neF8ESalMUUctpEYXviSJlMwm+id/aT 7KucgqJyTWpowcxNOzcaJJxompjmYyJu0qKV7bdS2S9z9j46887eUysIeTI4vkp0B0bZASKzays R6XJLTqKnQdyQXXl/POZ5PMbeQL230X0Ch6jfQHRq/yEo15wfArZDEQnT9K5XW0bzpzVMQ44kBW xwIvnhjVb41zwBjkurShIebmGg5GxDQv+3ukTVrHQJxZwZ1PYhv/v/gTbGTOnkLWRa1Cyqrf6gY BVx8AAZwsjRxrz6vMo/tUOW5wJ35dBfCFOfWTCXx4VovAI+8HZ9nEnop7nYLuC9DBqzKLsHipQO 9nlDlJwWNTSjSFyrLn08wwkVqz+Wgt/3DDEgoxH/aw6183g0FKEzGt602YBlK4tpm4noRjglm6u DKrd1RLaccnsSa7MDL/cAbT0XtKoW0xZWx03mLsSgBAFalomQrQAUo7c4R4+IftZbQBkemdOy3f dNpwQk7BYwKw0UDKOjLB5i1jcRcy1Mj1vAjgJ0xDC3E/ULuYlas/zpNz4tLW5KE4lvIz93jHY6g xJbDRWr8fg== X-Received: by 2002:a17:90b:3807:b0:38d:f096:a1dc with SMTP id 98e67ed59e1d1-393013e58ecmr4752057a91.11.1786533662842; Wed, 12 Aug 2026 04:21:02 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-392f935f5ecsm3193765a91.5.2026.08.12.04.20.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 04:21:02 -0700 (PDT) From: phucduc.bui@gmail.com To: Ulf Hansson , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jisheng Zhang , Stepan Ionichev , Colin Ian King , Pedro Demarchi Gomes , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 3/3] mmc: davinci: Handle optional IRQ return value correctly Date: Wed, 12 Aug 2026 18:20:23 +0700 Message-ID: <20260812112023.42254-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812112023.42254-1-phucduc.bui@gmail.com> References: <20260812112023.42254-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc host->sdio_irq is assigned from platform_get_irq_optional(), which returns a positive IRQ number on success or a negative error code on failure. Therefore, 0 is not a possible return value from this API. Check for a positive IRQ number before requesting the SDIO IRQ instead of treating zero as a valid IRQ. Signed-off-by: bui duc phuc --- drivers/mmc/host/davinci_mmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 4765d2dee599..dddd152d2ec4 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1303,7 +1303,7 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) if (ret) goto mmc_add_host_fail; - if (host->sdio_irq >= 0) { + if (host->sdio_irq > 0) { ret = devm_request_irq(&pdev->dev, host->sdio_irq, mmc_davinci_sdio_irq, 0, mmc_hostname(mmc), host); -- 2.43.0