From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 046612ED141 for ; Wed, 12 Aug 2026 13:03:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539813; cv=none; b=QDcO8Pl4skv5GAu3qoQv/PYeSRUcVG1/4rqQ03Js+LCbwBcuAkXEopWwTjqr15SgMATI1YyHfvo8PqGeYVromaVIF5PvVTZSiNOctwmEVKyB+6F3pIFu4oLIzJruuuZIt0R6yTGWG0sfSFeYFvE0cBIACilZfZ9RJGkFPiErfhQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539813; c=relaxed/simple; bh=i44kIOmMPvCarHWNjUJRT9zNmQ092mTSsP/Kh3BjiP8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ucfseMQe+RgRjvO/AZGxl74TVHg+S4qDNBo9wfATxEHeYf9ova+kwiGYuBix2VWnkynLFB79qQfU+VthJPZXIBHSu66hoocC2koSAiqrnjSPsnl+JiAHRZ9Sd0y1GR86Gmxii8Wn0vqtdkYE1Da1ZgspzCIyu1TwXYucsgOsRxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P3yyDQAF; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P3yyDQAF" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47f502ff678so101838f8f.0 for ; Wed, 12 Aug 2026 06:03:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786539810; x=1787144610; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=as36wFWfEYJzqaxcovAhzmJbolrDk8C4787yYGJjYG8=; b=P3yyDQAF8Pp2a54wmKRnjUHsV3CBBVX+Tjm4pwgyJoRjHkYzhKA1yeC0f/0mTDxchW dLOpLQkIktFcsmm/uluKLT5JILuYkTEo+lFzFhFfgKPbuvB0NCIlJeJrHHSAgkvyighK 8hv4HP44HM5+sB938ctGLI4J5dVtzhyekAnpfQgVvRWpM38S4b5VO4ta+rZcYVOHFnYa ScO+hvhbuj0I/sxBZ23CsP8zbf4k9HSgxq3qiDjIxzUFr4hoMsWwZOHgFy1XraMRHXDH XIKpQ20N9cJyjMgo83aWRpqrhRGubHmXUdNJlpLpILFjqwUeEKFpNznJi0t0d4c6XQxR 2MSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786539810; x=1787144610; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=as36wFWfEYJzqaxcovAhzmJbolrDk8C4787yYGJjYG8=; b=mhqlmPFUPN1ifLdysqQxAVnLdFXFnr7w74W4nqfilhbOYS4zsocroWbyQ5M3hkKcf5 MFNK+Z5sdp+VJRifCQcwmdDAR2fTmkGi+N9kKXhpnfPkmCgEEho0AQFIyXrh/+R3sEkh CuOQW03T06G1fEFVI5FXVGS78HdxDrkm3Wj1XRxKP2w9KF3bjEmATK0dc73y73Yb1Q15 G1ezBUZ+BuHKLMIiy951ogwZVjaaj098NtIoWIlGd+kW2iKEuao344c9MRvfxAZiAMgG 9v0bMiJXMmyu9/zUlFuKy/pXWapgRHCjy22jRCWgw423nS/vz3g25Rto6rArTkSopEvZ wL7w== X-Forwarded-Encrypted: i=1; AHgh+RqfAosN408bWMukhqXX2zrqX1iV930zcymhRgIKrk13hjtq9+Dq+QsCoYeWRNwcZA2L5SJGre9b/zHRJOc=@vger.kernel.org X-Gm-Message-State: AOJu0YyxifQ5V4FHGzzorogE4Og29m2pE3TsJco5zeDZvhNuPP7sZhzn iKjCBmI3u3PPFna2gvsupIRxmed8FAfuWorqiMIxv5ZZ+JLfjNc+4bZbqDUQgBCt X-Gm-Gg: AR+sD109AybIc3u5rpcNEmqWXyqhAehjRi4MoXGf8gjo+YwiILik1bQetHGQ4x76c4S LzmFXmU+VoOKcbv+mukjrGdsFKKZEFYz4gd/d7xAlRFOed7n2ie1u5/l/exYcNE5JM3a5xrGYzT 5TbxfnMKJiqnuTCFo/iGidh1iWwYb+JPZhqMwrR37ze0+OJDsl7HEBGOnMC4cSX2K3PRPnjPLtu hiI3ORzjWqVPKYNVEhvmbK6QZRTSuF3l8nQttytsbVkW27277G44LJUjVdhsDUVz/KSrkjz3V3f 0Hu0mR4JdpFeO0aS1d4BuPg83LC9OEX0ry/QOJ2izJzJ8CfV3euqI+vCsoLopSXPUqU/aniRT6X DcXB48+zhY7v3Q+gi1eXTNCIvoxnvjq0ApIooEOAMbQZURhzpfuzrh6oi+BNCgnPA8LR2vfeEt5 IS0i0e+73BwH0/7H95pTp6PwcvU3QuVUIpl3BQGHB19O5mE5MQ9TqozNd1JOCColZD7xCiuQKvu leE6Px5p5yhGH60WvfPz/+dVMqxvMDRv9O3va69xJ/8G6acg1wFtaQw/GpV1WO87bLN X-Received: by 2002:a5d:64e6:0:b0:47f:e8af:7687 with SMTP id ffacd0b85a97d-481528da9a6mr3640852f8f.1.1786539809937; Wed, 12 Aug 2026 06:03:29 -0700 (PDT) Received: from OrangePi5-Plus.BB-HOME (20014C4E1B84A6001A34C2DD5D9E0419.dsl.pool.telekom.hu. [2001:4c4e:1b84:a600:1a34:c2dd:5d9e:419]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d5cd2esm7316360f8f.26.2026.08.12.06.03.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 06:03:29 -0700 (PDT) From: Igor Paunovic To: Tomeu Vizoso Cc: Igor Paunovic , Oded Gabbay , Heiko Stuebner , Guangshuo Li , Jiaxing Hu , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] accel/rocket: fix shared-device lifecycle on probe failure and unbind Date: Wed, 12 Aug 2026 15:03:04 +0200 Message-ID: <20260812130311.8252-1-royalnet026@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260731064933.12548-1-royalnet026@gmail.com> References: <20260731064933.12548-1-royalnet026@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Tomeu, A ping on this one. It has been on the list since 31 July and 2/2 carries Jiaxing's Reviewed-by. I am pinging now rather than just waiting because the failure it describes stopped being a code reading yesterday. I hit it on hardware while testing Jiaxing's v7 RK3576 series on RK3588, on a tree that did not have this series applied. The sequence is the one 2/2 predicts: unbind core 0 while cores 1 and 2 stay bound, then bind it back. What happens without these patches, on an Orange Pi 5 Plus with all three NPU cores: - the returning core takes the index of a core that is still live. The driver prints rocket fdab0000.npu: Rockchip NPU core 2 version: 1179210309 for the device that is physically core 0; - inference stops being correct. The same MobileNet V1 input that classified as "military uniform" before the rebind classifies as "toilet tissue" after it, and the oracle hashes change with it; - throughput falls from 88.6 to 1.9 inferences per second, and core 0 stops taking interrupts entirely - 0.00 per inference where it had been taking 41.74 - while core 1 absorbs everything; - the next unbind then dies. Ten "NPU job timed out" in a row, followed by Unable to handle kernel paging request at virtual address dead000000000122 pc : destroy_workqueue+0x1b8/0x3e0 Call trace: destroy_workqueue+0x1b8/0x3e0 drm_sched_fini+0x178/0x1a8 [gpu_sched] rocket_job_fini+0x28/0x60 [rocket] rocket_core_fini+0x4c/0x78 [rocket] rocket_remove+0x6c/0x150 [rocket] ... unbind_store That is LIST_POISON2 being dereferenced. The sysfs write never returns, the task is in uninterruptible sleep and cannot be killed, and the machine needs a reboot. That is the second bullet of 2/2's commit message happening: the bind reuses the index of a still-live core and overwrites its slot while its IRQ handler and its DRM scheduler are still active. With the two patches applied and nothing else changed, the same sequence - core 2 out and back, core 0 out and back, all three out and all three back - runs clean. Twelve inference runs across two modules, one oracle hash for all of them, correct classification every time, and nothing in dmesg beyond the probe messages. I am happy to resend with the tag collected if that is easier. There is also a practical reason to have it in: the three-core RK3588 test that Jiaxing asked for on his v7 cannot run to completion on a tree without this, because the core-0 rebind step is what trips it. Thanks, Igor