From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 108B2446BE0 for ; Wed, 12 Aug 2026 13:04:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539899; cv=none; b=Fh8wW36AACDocHIRd4YKBOYbm0f7qjVrpbmuyxa4T8JelJdtQ6Ol26wYZkcudHTtqPrDSG2Yl99H4fCqPSCcu9Q4yapb5/RTGgSHKpkVWsivCl1QTF6AVDRQtpw1+kSwuO1Xp8I1k30t1zQ1NPJTOdYX1DuSOXJUp+gH4kFDzAs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786539899; c=relaxed/simple; bh=8yuS6AavRTKKvfqeG0/EbP7jYrRvTZGn9Ze0tTYIojY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VaNfs0On8QRNp88NoWLoIIN0sAwmLjIY7LuzBX15j/b8bxtiVuRo5zK5r6wp9PYIPMGSFUH1a2RyPXNuZVKcjcQMucsOx9Y9Pl3lU9NvHfew3+n88udHFWo6S8K68YEL0U9JrmnEUtcj2iEyLyRN6ipaLFjcvIjhJCXniHjywms= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fImPCSa5; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fImPCSa5" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f93b2fe4cso527800f8f.0 for ; Wed, 12 Aug 2026 06:04:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786539894; x=1787144694; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0Sjo2pf9/HRrEOX8Q8Nkk1IQP122bRFXP6EiLXN0F/g=; b=fImPCSa5crLyZ4QjbHwDpWfx2mze6nm06ycuXGGMfbVw+aWHiBS1tHkyinJoaE0/zq d45ZZF2gN9Qw9Oq+g1ztKA9XIW4nok2kRukPZYytG4l0TInqrxHEQhmCkImvOVl5lUAo i4P9PiwtOI5IdW5W3tG6pPUaVugqyKk+agcxR9jsDv1Zn85HbPbjMEelHexwZgMqQEqo aii0bVBDHFMjpuaw9tTh9ufk14mowvqCwRh5cz7Wl5HBM2QhS+GoOtHyDTtU6Uao8vmh 4If0JcYYKMwhOnLuBgvz2PE2PiJihhYZZF0vuCxKdF0I4RAWMwstAmZIjpZ66aEioz8i zjfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786539894; x=1787144694; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=0Sjo2pf9/HRrEOX8Q8Nkk1IQP122bRFXP6EiLXN0F/g=; b=luu5C8NwcAgKqiqcVXPN94GSmHckrYwGvm45FbgYelVC77bq9+Ykwrd25UjIQQfdXD t9FXuRe5qwdYgO0JdYUsJGqQ9pbYY9GFtfJ/GR4dR84fUhdsMq5DPdZzmk/lk4K66IKP 6LWFzsNxZCPkvDoqR5JMqoiaukKwWG5VN320jjdpaybADw9marAmFdH5G1WMO7gx1b76 W+lzcEdcwIAP6vaI+wy+4QfdgtllDgis8kObPhU+aztRnuBoKTg/NAWBjRpVjwCSuvEu uGpOu2+SK+9RI5DlVr3mhn+mhwrren8hO2C9xMedfnJRjfVKhb6PlYGcL/SFZGmTTWTf X3Jg== X-Forwarded-Encrypted: i=1; AHgh+RqMrxQqW9LNG5hfZZJDR7PjNwnY/gV6hlgMjirr6KbRPR4SqtRihSRvRHJTatdDvK+m8xZnscmhfnM09aU=@vger.kernel.org X-Gm-Message-State: AOJu0YyHXeZt4TXT6ICb8h8rC+s41gHJ4SdzXkU+if+tIpWgUB9ToXwI TvrYk5VrVm8m8tq5QaDE7KG+MGvBWpGTxr/8NzRgav/VHmSyY6Y5T9So6QO45sSs X-Gm-Gg: AR+sD10p/7R12gNwxYWMeNSXMaTUPV6qHyiujNQddllPjgcm9VhCPUMP9k98JcTE/KO 6WtI0FCVDoCsqr1eJWIVdnhxnRct6YHCzTK+cLChRMxNRTcrQ1lGawv4xSkVnpejACX/jMtlLaG pXcr71iAB9L2jI7IaQJiWiW4W2hdAaKTxIv3lm86QtMO83cBH1F3qzaFiqGBEKSUm1NZFSwkFq4 30v6PO8pK5o+XTuqENiqNkJ5KsuoE9jkoYSwFkZKUsynUZan//2rPbE3Tb9+Qm0pg3rKUGWGATP Tm8UV0rwFugZ2f1CTFlMZgOML/BVdU4g1hSzA6CavFN7HYsi8PumCYVHPYzamF6cmt36BSWuaHG T6K+8Z6d7nPGb6jMRbjVZXHzX0glYAjvjzZ5FcH5gwOG9MSEYmM4NO4Tpxj89qAY8nrGjLykqHV fEdPFHMw0677fH/J7im/1ZKrN4zKqQMMernJ1FzH7sn2CbBWjVKKmlM7fDhiXC7L9KT1A8e1ouX jFW8dTj5Rruf1RosrwxE5lTg1kjISoB2qf+ X-Received: by 2002:a05:6000:470b:b0:481:5657:5299 with SMTP id ffacd0b85a97d-481565752a7mr3865987f8f.0.1786539893963; Wed, 12 Aug 2026 06:04:53 -0700 (PDT) Received: from osama.. ([2a02:908:185:7e40:3d2e:78f3:cfb2:413d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48150d5eb2csm7040804f8f.30.2026.08.12.06.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 06:04:53 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH v3 5/6] drm/panel: Use devm_mipi_dsi_attach in display vendor panels Date: Wed, 12 Aug 2026 15:04:22 +0200 Message-ID: <20260812130429.16850-5-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260812130429.16850-1-osama.abdelkader@gmail.com> References: <20260812130429.16850-1-osama.abdelkader@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the managed MIPI DSI attach helper in JDI, Sharp, Sony, Visionox and Leadtek panel drivers and drop the corresponding manual detach calls from remove paths. Signed-off-by: Osama Abdelkader --- v3: - Move the changelog after the `---`. v2: - break long description lines. - add Signed-off-by tag drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c | 8 +------- drivers/gpu/drm/panel/panel-jdi-lt070me05000.c | 8 +------- drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 +------- drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c | 8 +------- drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 7 +------ drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c | 8 +------- drivers/gpu/drm/panel/panel-sony-td4353-jdi.c | 8 +------- drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c | 8 +------- drivers/gpu/drm/panel/panel-visionox-r66451.c | 8 +------- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 4 +--- 10 files changed, 10 insertions(+), 65 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c index cbe354b51bce..ce299160d3ab 100644 --- a/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c +++ b/drivers/gpu/drm/panel/panel-jdi-fhd-r63452.c @@ -202,7 +202,7 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); return ret; @@ -214,12 +214,6 @@ static int jdi_fhd_r63452_probe(struct mipi_dsi_device *dsi) static void jdi_fhd_r63452_remove(struct mipi_dsi_device *dsi) { struct jdi_fhd_r63452 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c index 01bd748aecec..d9cba45eb729 100644 --- a/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c +++ b/drivers/gpu/drm/panel/panel-jdi-lt070me05000.c @@ -380,7 +380,7 @@ static int jdi_panel_probe(struct mipi_dsi_device *dsi) if (ret < 0) return ret; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { jdi_panel_del(jdi); return ret; @@ -392,12 +392,6 @@ static int jdi_panel_probe(struct mipi_dsi_device *dsi) static void jdi_panel_remove(struct mipi_dsi_device *dsi) { struct jdi_panel *jdi = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", - ret); jdi_panel_del(jdi); } diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index 0856df5a6ee2..b660d7055810 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -585,7 +585,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "mipi_dsi_attach failed: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -598,12 +598,6 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi) static void ltk050h3146w_remove(struct mipi_dsi_device *dsi) { struct ltk050h3146w *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c index 7f19fd5b8060..6ec6f81877aa 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk500hd1829.c @@ -651,7 +651,7 @@ static int ltk500hd1829_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "mipi_dsi_attach failed: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -664,12 +664,6 @@ static int ltk500hd1829_probe(struct mipi_dsi_device *dsi) static void ltk500hd1829_remove(struct mipi_dsi_device *dsi) { struct ltk500hd1829 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c index 989b030ea22d..11615551e8a6 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c @@ -244,7 +244,7 @@ static int sharp_nt_panel_probe(struct mipi_dsi_device *dsi) if (ret < 0) return ret; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { sharp_nt_panel_del(sharp_nt); return ret; @@ -256,11 +256,6 @@ static int sharp_nt_panel_probe(struct mipi_dsi_device *dsi) static void sharp_nt_panel_remove(struct mipi_dsi_device *dsi) { struct sharp_nt_panel *sharp_nt = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); sharp_nt_panel_del(sharp_nt); } diff --git a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c index 0456f3d705e7..236d45121a44 100644 --- a/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c +++ b/drivers/gpu/drm/panel/panel-sharp-ls060t1sx01.c @@ -235,7 +235,7 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -248,12 +248,6 @@ static int sharp_ls060_probe(struct mipi_dsi_device *dsi) static void sharp_ls060_remove(struct mipi_dsi_device *dsi) { struct sharp_ls060 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c index a14c86c60d19..08e4adf9e0f0 100644 --- a/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c +++ b/drivers/gpu/drm/panel/panel-sony-td4353-jdi.c @@ -216,7 +216,7 @@ static int sony_td4353_jdi_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -229,12 +229,6 @@ static int sony_td4353_jdi_probe(struct mipi_dsi_device *dsi) static void sony_td4353_jdi_remove(struct mipi_dsi_device *dsi) { struct sony_td4353_jdi *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c index 216a6ad8696e..5ce8b1cdf024 100644 --- a/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c +++ b/drivers/gpu/drm/panel/panel-sony-tulip-truly-nt35521.c @@ -474,7 +474,7 @@ static int truly_nt35521_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -487,12 +487,6 @@ static int truly_nt35521_probe(struct mipi_dsi_device *dsi) static void truly_nt35521_remove(struct mipi_dsi_device *dsi) { struct truly_nt35521 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-visionox-r66451.c b/drivers/gpu/drm/panel/panel-visionox-r66451.c index 690cccedd438..40bbc3ea6958 100644 --- a/drivers/gpu/drm/panel/panel-visionox-r66451.c +++ b/drivers/gpu/drm/panel/panel-visionox-r66451.c @@ -306,7 +306,7 @@ static int visionox_r66451_probe(struct mipi_dsi_device *dsi) drm_panel_add(&ctx->panel); - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); drm_panel_remove(&ctx->panel); @@ -318,12 +318,6 @@ static int visionox_r66451_probe(struct mipi_dsi_device *dsi) static void visionox_r66451_remove(struct mipi_dsi_device *dsi) { struct visionox_r66451 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach DSI host: %d\n", ret); - drm_panel_remove(&ctx->panel); } diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c index 50f8a84537ca..7a60b1d436df 100644 --- a/drivers/gpu/drm/panel/panel-visionox-rm69299.c +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c @@ -388,7 +388,7 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) dsi->format = MIPI_DSI_FMT_RGB888; dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); if (ret < 0) { dev_err(dev, "dsi attach failed ret = %d\n", ret); goto err_dsi_attach; @@ -404,8 +404,6 @@ static int visionox_rm69299_probe(struct mipi_dsi_device *dsi) static void visionox_rm69299_remove(struct mipi_dsi_device *dsi) { struct visionox_rm69299 *ctx = mipi_dsi_get_drvdata(dsi); - - mipi_dsi_detach(ctx->dsi); drm_panel_remove(&ctx->panel); } -- 2.43.0