From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DD7844E041 for ; Wed, 12 Aug 2026 14:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544430; cv=none; b=oycXOP4vRxCnIRJW1OhLLYwVDCVcLOUOhl0ggLL0sk9CgBVJaZoH9+sqQ2WQNwbbe7hSx4QZhlfvYTI+SivnTANHqE7ll1Qutm84gK4tCUszi7kyy7QF5Rbnix1yzQ6GAokLhwC/KOWQk/MEsrP+AT/P88YX2qJncN5i2MISuTw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544430; c=relaxed/simple; bh=oeZfOb3yMlzgZ6U+x6LQ+R8Wx+b/NSvf1PN/ab84Lsk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Vn1RWLyGHJiS97xq+kw6LMaQ1jI0zUqLlmACZopM6k8d7mbeCpOonud5IIVlTHSXRvzF5Ulzhfy+eTmJ07457245XdPVR0cLiKjPDVARlpWTyQ7gk0IbUsSAPX6nnJD1c3TfDxopXofZlHBYhchhgHviNI0gdEWldHVSyQppdUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=eQ4YzCSs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="eQ4YzCSs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D8DB61F00ADE; Wed, 12 Aug 2026 14:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786544428; bh=CDLz+Mc42aHxy/v7Uem4HL7pasWmvjBSSIEq0pceeCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=eQ4YzCSs3LRL46v83L7Rn44ToT3bZ0x/2CTe3cwSdvODDVqtlPFfc+4/ju6K5iOsY w9TIs1LOEQyFej+iPRsEkitMVYBt+iajLfPm94f5hoiukWZOzUtCL6k4n9H/f4qfMi OjHt2KvN4UIFlp8lr3J1QDii+mC7eVEKnjGqNyyPlGezLTn1DXDgTeEk3U17liAC3+ 4shZtpU/YI4dq2KJVKNL1aYDA6IT76cTttpjgWHR2Ei2fBTttLex4Gu6/TZMQK4laO B5WPGTgV9i20VKrXqhYxsZscHbHZ6KFSovst7EY2P8skZmsOXPnKPR1zYxTGoAMSIU gmaQkTpc0NqZg== Received: from johan by xi.lan with local (Exim 4.99.4) (envelope-from ) id 1wu9og-00000000ELh-26Rr; Wed, 12 Aug 2026 16:20:26 +0200 From: Johan Hovold To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 1/3] powerpc/ps3: switch to dynamic system bus root device Date: Wed, 12 Aug 2026 16:20:14 +0200 Message-ID: <20260812142016.55136-2-johan@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260812142016.55136-1-johan@kernel.org> References: <20260812142016.55136-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core expects devices to be dynamically allocated and will, for example, complain loudly if a device that lacks a release function is ever freed. Use root_device_register() to allocate and register the root device instead of open coding using a static device. Signed-off-by: Johan Hovold --- arch/powerpc/platforms/ps3/system-bus.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/ps3/system-bus.c b/arch/powerpc/platforms/ps3/system-bus.c index 0537a678a32f..4ead6ccea259 100644 --- a/arch/powerpc/platforms/ps3/system-bus.c +++ b/arch/powerpc/platforms/ps3/system-bus.c @@ -20,9 +20,7 @@ #include "platform.h" -static struct device ps3_system_bus = { - .init_name = "ps3_system", -}; +static struct device *ps3_system_bus; /* FIXME: need device usage counters! */ static struct { @@ -486,8 +484,8 @@ static int __init ps3_system_bus_init(void) mutex_init(&usage_hack.mutex); - result = device_register(&ps3_system_bus); - BUG_ON(result); + ps3_system_bus = root_device_register("ps3_system"); + BUG_ON(IS_ERR(ps3_system_bus)); result = bus_register(&ps3_system_bus_type); BUG_ON(result); @@ -744,7 +742,7 @@ int ps3_system_bus_device_register(struct ps3_system_bus_device *dev) static unsigned int dev_lpm_count; if (!dev->core.parent) - dev->core.parent = &ps3_system_bus; + dev->core.parent = ps3_system_bus; dev->core.bus = &ps3_system_bus_type; dev->core.release = ps3_system_bus_release_device; -- 2.54.0