From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE27453A3B for ; Wed, 12 Aug 2026 14:20:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544430; cv=none; b=mykRsiokk9Z28UOu5kVV9kl6qB6PFPHR26BeJTMXh+LE8YBKW5zSshzsKlHHw/0b/qKYpJgAH4//XsVr9xvSUAP08Dn5p3GBCckQYaa+JjoWxn1SI+i2TSWUkUdyqFxxy4Ck17k4UTbRJMm2bh2/2sIrUvyl+zjUmTiexbIgubA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544430; c=relaxed/simple; bh=fXuRtCOIMbiEVQ0RG2k3Ks6dfzhYNlmpB9Wft6NfpnA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gt4lKNyJJAbEBzofg55oIXuax2XnSJ5YmvJwelbbE2ufU8YR/SqG/baxT6QcwcR9h6t+q2++VaL6j8hu/qZua5L0CkUxppwr77FcB4YDpUnNFNnDznuutFrCK6yV6sgR3XUUkX6wPH2Kkwk+M7qgsfb3U8pLLPNL/KeRi+ZgOis= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gszUJ8Gh; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gszUJ8Gh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB6761F00A3A; Wed, 12 Aug 2026 14:20:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786544428; bh=P7iOr3nQ+DZjRKBXriTn+qJo7TLaZ9kPfjGghjh5ty8=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=gszUJ8Gh/6zGJ5FUSb8cczQIrcov9KAGSOHDGMsH0gg9ohT5yJcd8kF42asYXXx31 O29GbsLjDDNGQB1v/4T5aZna4Q4q9Rs636GYThmUOOPBw/dke7D3+aiq/PYT9Q5ZSf vPYcOV4yoYI1VsUl7EglSNm+G34+vVz14jUJGsR4klQeG/RwO+pVWuopquulvtVm5I hL9ca0oCFqdwdiziVu3eU+UXcJs2Bv4Eb8fiDIn/zT6AeLGOfzwW6jQn8FrjQGcggo ROpo7TPGeFP3vJT9OdxbMkP1YmftGvdIP2K0uo/9F6eg8+4YxSOPaFsdjZE7p+T8/V 59iTNocwij4ag== Received: from johan by xi.lan with local (Exim 4.99.4) (envelope-from ) id 1wu9og-00000000ELj-29UR; Wed, 12 Aug 2026 16:20:26 +0200 From: Johan Hovold To: Geoff Levand , Madhavan Srinivasan , Michael Ellerman Cc: Nicholas Piggin , Christophe Leroy , Greg Kroah-Hartman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 RESEND 2/3] powerpc/pseries: switch to dynamic ibmebus root device Date: Wed, 12 Aug 2026 16:20:15 +0200 Message-ID: <20260812142016.55136-3-johan@kernel.org> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260812142016.55136-1-johan@kernel.org> References: <20260812142016.55136-1-johan@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Driver core expects devices to be dynamically allocated and will, for example, complain loudly if a device that lacks a release function is ever freed. Use root_device_register() to allocate and register the root device instead of open coding using a static device. Also add the missing sanity check when registering ibmebus devices to avoid use-after-free if the bus failed to register (which would previously have triggered a bunch of use-after-free warnings). Signed-off-by: Johan Hovold --- arch/powerpc/platforms/pseries/ibmebus.c | 39 ++++++++++++++---------- 1 file changed, 23 insertions(+), 16 deletions(-) diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c index 2d0f991da2c8..48076fe6ab30 100644 --- a/arch/powerpc/platforms/pseries/ibmebus.c +++ b/arch/powerpc/platforms/pseries/ibmebus.c @@ -52,9 +52,7 @@ #include #include -static struct device ibmebus_bus_device = { /* fake "parent" device */ - .init_name = "ibmebus", -}; +static struct device *ibmebus_bus_device; /* fake "parent" device */ const struct bus_type ibmebus_bus_type; @@ -172,7 +170,10 @@ static int ibmebus_create_device(struct device_node *dn) struct platform_device *dev; int ret; - dev = of_device_alloc(dn, NULL, &ibmebus_bus_device); + if (!ibmebus_bus_device) + return -ENOENT; + + dev = of_device_alloc(dn, NULL, ibmebus_bus_device); if (!dev) return -ENOMEM; @@ -448,6 +449,7 @@ EXPORT_SYMBOL(ibmebus_bus_type); static int __init ibmebus_bus_init(void) { + struct device *root; int err; printk(KERN_INFO "IBM eBus Device Driver\n"); @@ -459,23 +461,28 @@ static int __init ibmebus_bus_init(void) return err; } - err = device_register(&ibmebus_bus_device); - if (err) { - printk(KERN_WARNING "%s: device_register returned %i\n", + root = root_device_register("ibmebus"); + if (IS_ERR(root)) { + err = PTR_ERR(root); + printk(KERN_WARNING "%s: root_device_register returned %i\n", __func__, err); - put_device(&ibmebus_bus_device); - bus_unregister(&ibmebus_bus_type); - - return err; + goto err_deregister_bus; } + ibmebus_bus_device = root; + err = ibmebus_create_devices(ibmebus_matches); - if (err) { - device_unregister(&ibmebus_bus_device); - bus_unregister(&ibmebus_bus_type); - return err; - } + if (err) + goto err_deregister_root; return 0; + +err_deregister_root: + ibmebus_bus_device = NULL; + root_device_unregister(root); +err_deregister_bus: + bus_unregister(&ibmebus_bus_type); + + return err; } machine_postcore_initcall(pseries, ibmebus_bus_init); -- 2.54.0