From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 787813515C4 for ; Wed, 12 Aug 2026 14:22:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544528; cv=none; b=A2qPvamPYloNJ7qNxy2fpQ+F2Y+P2rFL1Rtl+/6x9x5chS8PT2JbhUzcvVUed7y+WF+hNFhdFC3/UqCbbcYDBMsbQbI+XwbbuTfQbmpM+89yZB0/xX9jiDVX0ZsxclGHqb3xMDluxnuypRwGGWZuxxgk3h6K+N8WJHD1re5JFQ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544528; c=relaxed/simple; bh=uBzC8LW5kiA0kXyAuz/toC+bpHX49mN12npaltPocps=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Z+GISFhuVHWkRQ4ySKwE92p8F8lzysgqGpaEZAmQqPshxnBR2+4eWTYOWbfKOqWF3BnugKhrh+F+78D6EdKTgiWMohX/TfqWAQP6fv10TFShsa+OjCx3264NOKITTBkSg9LYiTzEuf0+Xud/SsHaoB662vY/eAmK9EXP7ihrThQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=KYr2NKbE; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KYr2NKbE" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49545ba3d4eso5041125e9.3 for ; Wed, 12 Aug 2026 07:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786544525; x=1787149325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aSBaDCiHXcH7od8kZUYH0XWJkxiBBbB5RxDxKzyH17s=; b=KYr2NKbEVFiHZJqBCNfFi0duZvqXOGbKhmlHmZP+qHZ2FbssVCrqULgB2OwbOo06PU BL0LknDQq7Um4vcRhhy491vS80ArlvBVQz4j5X+n4EVsS2/G0qq/AyT56vmrzTEQ9CfU geGvXB4SWzahoU8MxeYiC6Lco2BsK2dc6Wcr0Zl4iFDW3OwK5nLtIPDc7nTqKNuefdou aZcRJTCBcdohFKVaWG0cf4BTuADAN4VCs20urq53VH7/B316gdf3rJakZ2wU/i1l09/9 3iUpWceCAiJ0m/ceMnAj6fZGMF67Y1leGBSc2LZu8A3YUMtNB+JWPCeHSGb7z5IDSm5I Wg6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786544525; x=1787149325; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aSBaDCiHXcH7od8kZUYH0XWJkxiBBbB5RxDxKzyH17s=; b=VQHWUpsxguSLCd/YlV+1n5X45Ukq1J5k4wz9M3DIanPf74Vo5kSsFkb1xfeOeouqym pOk/IPHpImmfIXaomUdX5o9hq/DbBBXhfEBBkluVdGtXz8rlXwO3zjGBbpZoB9ZVCG6g MnH4WPxqA+rhhf2H1ONJ4HSkxSryfDX1Dsr5cbaGYlS9S42PFiwkR5dMYZz7BQZtjZe3 fzYpiVuadywJnHxzXQ4JPBPIycTX068C/6Q8R6+KZipzaPydAFi0YozskvxvrwMK3Bia WKRRwKl54Jc+oqp7FHQ2kh0Mu5u2vF2Tp6gYPgLiHioKtjtOOf5THk8CS1rQw29fbkjh 9aeQ== X-Forwarded-Encrypted: i=1; AHgh+RrYfNYOxM5GDQ7fJa6hfnzvM7nOqNtCbWEj7zw4Uly8lUA1a+1zB6jf0UkYZ8WS/JazfecMqYHtISsFqag=@vger.kernel.org X-Gm-Message-State: AOJu0YwfrWDRyRwBaolJXWHBGA4k8y2PLnF1y2iRpr1YSvS0bkiQG5pP gedZBnlXAJUgWTBPSuiUFchEpthl4WNWk5XStMiCa++m13LGaKi1DJSL X-Gm-Gg: AR+sD13we0m7lXkLxrAmddncgno940jHw2tvoSVKT+d9hfhZLA0J9Fe/UMmiztmQ209 kIhDEQ+JedjOYc/Sc0hnP4KpaJnh5trH3KUMkjabzLQQHXKeDs46/guuXiTb2XS/F6zBi0VnxAV NlVy1LEtCZmUnmW3W5dbXIjWekaK0zBMbboUjbzt9oTHFvFVYELtVCuRDtNpZlCtalka0yGd5EY NduzPcQOIs7++EH+epecbF5R0VEGXcdGZzWswUQ0GKy8kcWjlE+Gg0KgKvp2co8+G3+w795/xit UBFk8tCHwifppJF/S000ZmvrANPAFjOyneWnp3jQh3FlhZTRS5imy0HSZUrDVvKcuwauGL2DD8v Pd8OhJ9yRAovU1bU6cqBqyYaK24M4zpq6RgYhodfck/SAuQAf04JqGVJE82fHXAyN7IOpl1iR45 l0UvqcPR3CDVaPcP12HWEukU2cKuDslKogazxFvYunvPka/ZktMJn/fdJjPVoVyW36KVImu8nz1 jyTSiEz1msI6uZ5G223mKTj/GpxwutWWxGD X-Received: by 2002:a05:600c:3f0c:b0:495:4d5c:903e with SMTP id 5b1f17b1804b1-4997c10aebbmr85438685e9.7.1786544524351; Wed, 12 Aug 2026 07:22:04 -0700 (PDT) Received: from osama.. ([2a02:908:185:7e40:3d2e:78f3:cfb2:413d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997c993d80sm55360995e9.12.2026.08.12.07.22.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 07:22:03 -0700 (PDT) From: Osama Abdelkader To: luca.ceresoli@bootlin.com, Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jerry Han , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Osama Abdelkader Subject: [PATCH v4 1/6] drm/panel: Use managed helpers in BOE panels Date: Wed, 12 Aug 2026 16:21:54 +0200 Message-ID: <20260812142155.51941-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use the managed MIPI DSI attach and panel add helpers in BOE panel drivers and drop the corresponding manual detach and panel remove calls from remove paths. Suggested-by: Luca Ceresoli Signed-off-by: Osama Abdelkader --- v4: - use devm_drm_panel_add instead of drm_panel_add. drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c | 19 ++++----------- drivers/gpu/drm/panel/panel-boe-himax8279d.c | 23 ++---------------- drivers/gpu/drm/panel/panel-boe-td4320.c | 23 ++++-------------- drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c | 24 ++++++------------- drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c | 23 ++++-------------- drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c | 24 ++----------------- 6 files changed, 25 insertions(+), 111 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c index 84c21c62a43e..e9519923c6d8 100644 --- a/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c +++ b/drivers/gpu/drm/panel/panel-boe-bf060y8m-aj0.c @@ -357,9 +357,11 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) return dev_err_probe(dev, PTR_ERR(boe->panel.backlight), "Failed to create backlight\n"); - drm_panel_add(&boe->panel); + ret = devm_drm_panel_add(dev, &boe->panel); + if (ret) + return ret; - ret = mipi_dsi_attach(dsi); + ret = devm_mipi_dsi_attach(dev, dsi); if (ret < 0) { dev_err(dev, "Failed to attach to DSI host: %d\n", ret); return ret; @@ -368,18 +370,6 @@ static int boe_bf060y8m_aj0_probe(struct mipi_dsi_device *dsi) return 0; } -static void boe_bf060y8m_aj0_remove(struct mipi_dsi_device *dsi) -{ - struct boe_bf060y8m_aj0 *boe = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - - drm_panel_remove(&boe->panel); -} - static const struct of_device_id boe_bf060y8m_aj0_of_match[] = { { .compatible = "boe,bf060y8m-aj0" }, { /* sentinel */ } @@ -388,7 +378,6 @@ MODULE_DEVICE_TABLE(of, boe_bf060y8m_aj0_of_match); static struct mipi_dsi_driver boe_bf060y8m_aj0_driver = { .probe = boe_bf060y8m_aj0_probe, - .remove = boe_bf060y8m_aj0_remove, .driver = { .name = "panel-sw43404-boe-fhd-amoled", .of_match_table = boe_bf060y8m_aj0_of_match, diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c index 4a8560b4b899..facf37bd1c14 100644 --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c @@ -851,9 +851,7 @@ static int panel_add(struct panel_info *pinfo) if (ret) return ret; - drm_panel_add(&pinfo->base); - - return 0; + return devm_drm_panel_add(dev, &pinfo->base); } static int panel_probe(struct mipi_dsi_device *dsi) @@ -881,23 +879,7 @@ static int panel_probe(struct mipi_dsi_device *dsi) if (err < 0) return err; - err = mipi_dsi_attach(dsi); - if (err < 0) - drm_panel_remove(&pinfo->base); - - return err; -} - -static void panel_remove(struct mipi_dsi_device *dsi) -{ - struct panel_info *pinfo = mipi_dsi_get_drvdata(dsi); - int err; - - err = mipi_dsi_detach(dsi); - if (err < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err); - - drm_panel_remove(&pinfo->base); + return devm_mipi_dsi_attach(&dsi->dev, dsi); } static struct mipi_dsi_driver panel_driver = { @@ -906,7 +888,6 @@ static struct mipi_dsi_driver panel_driver = { .of_match_table = panel_of_match, }, .probe = panel_probe, - .remove = panel_remove, }; module_mipi_dsi_driver(panel_driver); diff --git a/drivers/gpu/drm/panel/panel-boe-td4320.c b/drivers/gpu/drm/panel/panel-boe-td4320.c index 23558a76dd72..73b762817e3e 100644 --- a/drivers/gpu/drm/panel/panel-boe-td4320.c +++ b/drivers/gpu/drm/panel/panel-boe-td4320.c @@ -202,29 +202,17 @@ static int boe_td4320_probe(struct mipi_dsi_device *dsi) if (ret) return dev_err_probe(dev, ret, "Failed to get backlight\n"); - drm_panel_add(&ctx->panel); + ret = devm_drm_panel_add(dev, &ctx->panel); + if (ret) + return ret; - ret = mipi_dsi_attach(dsi); - if (ret < 0) { - drm_panel_remove(&ctx->panel); + ret = devm_mipi_dsi_attach(dev, dsi); + if (ret < 0) return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); - } return 0; } -static void boe_td4320_remove(struct mipi_dsi_device *dsi) -{ - struct boe_td4320 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - - drm_panel_remove(&ctx->panel); -} - static const struct of_device_id boe_td4320_of_match[] = { { .compatible = "boe,td4320" }, { /* sentinel */ } @@ -233,7 +221,6 @@ MODULE_DEVICE_TABLE(of, boe_td4320_of_match); static struct mipi_dsi_driver boe_td4320_driver = { .probe = boe_td4320_probe, - .remove = boe_td4320_remove, .driver = { .name = "panel-boe-td4320", .of_match_table = boe_td4320_of_match, diff --git a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c index a70a2e58f88c..c5f18e310b43 100644 --- a/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c +++ b/drivers/gpu/drm/panel/panel-boe-th101mb31ig002-28a.c @@ -391,25 +391,16 @@ static int boe_th101mb31ig002_dsi_probe(struct mipi_dsi_device *dsi) if (ret) return ret; - drm_panel_add(&ctx->panel); - - ret = mipi_dsi_attach(dsi); - if (ret < 0) { - dev_err_probe(&dsi->dev, ret, - "Failed to attach panel to DSI host\n"); - drm_panel_remove(&ctx->panel); + ret = devm_drm_panel_add(&dsi->dev, &ctx->panel); + if (ret) return ret; - } - return 0; -} - -static void boe_th101mb31ig002_dsi_remove(struct mipi_dsi_device *dsi) -{ - struct boe_th101mb31ig002 *ctx = mipi_dsi_get_drvdata(dsi); + ret = devm_mipi_dsi_attach(&dsi->dev, dsi); + if (ret < 0) + return dev_err_probe(&dsi->dev, ret, + "Failed to attach panel to DSI host\n"); - mipi_dsi_detach(dsi); - drm_panel_remove(&ctx->panel); + return 0; } static const struct of_device_id boe_th101mb31ig002_of_match[] = { @@ -431,7 +422,6 @@ static struct mipi_dsi_driver boe_th101mb31ig002_driver = { .of_match_table = boe_th101mb31ig002_of_match, }, .probe = boe_th101mb31ig002_dsi_probe, - .remove = boe_th101mb31ig002_dsi_remove, }; module_mipi_dsi_driver(boe_th101mb31ig002_driver); diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c index 20b6e11a7d84..8a6c4d5c6320 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-ll2.c @@ -198,29 +198,17 @@ static int boe_tv101wum_ll2_probe(struct mipi_dsi_device *dsi) if (ret) return dev_err_probe(dev, ret, "Failed to get backlight\n"); - drm_panel_add(&ctx->panel); + ret = devm_drm_panel_add(dev, &ctx->panel); + if (ret) + return ret; - ret = mipi_dsi_attach(dsi); - if (ret < 0) { - drm_panel_remove(&ctx->panel); + ret = devm_mipi_dsi_attach(dev, dsi); + if (ret < 0) return dev_err_probe(dev, ret, "Failed to attach to DSI host\n"); - } return 0; } -static void boe_tv101wum_ll2_remove(struct mipi_dsi_device *dsi) -{ - struct boe_tv101wum_ll2 *ctx = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "Failed to detach from DSI host: %d\n", ret); - - drm_panel_remove(&ctx->panel); -} - static const struct of_device_id boe_tv101wum_ll2_of_match[] = { { .compatible = "boe,tv101wum-ll2" }, { /* sentinel */ } @@ -229,7 +217,6 @@ MODULE_DEVICE_TABLE(of, boe_tv101wum_ll2_of_match); static struct mipi_dsi_driver boe_tv101wum_ll2_driver = { .probe = boe_tv101wum_ll2_probe, - .remove = boe_tv101wum_ll2_remove, .driver = { .name = "panel-boe-tv101wum_ll2", .of_match_table = boe_tv101wum_ll2_of_match, diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c index 150dff3ab6c3..cf9f15fae272 100644 --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c @@ -1736,9 +1736,7 @@ static int boe_panel_add(struct boe_panel *boe) boe->base.funcs = &boe_panel_funcs; boe->base.dev = &boe->dsi->dev; - drm_panel_add(&boe->base); - - return 0; + return devm_drm_panel_add(dev, &boe->base); } static int boe_panel_probe(struct mipi_dsi_device *dsi) @@ -1765,24 +1763,7 @@ static int boe_panel_probe(struct mipi_dsi_device *dsi) mipi_dsi_set_drvdata(dsi, boe); - ret = mipi_dsi_attach(dsi); - if (ret) - drm_panel_remove(&boe->base); - - return ret; -} - -static void boe_panel_remove(struct mipi_dsi_device *dsi) -{ - struct boe_panel *boe = mipi_dsi_get_drvdata(dsi); - int ret; - - ret = mipi_dsi_detach(dsi); - if (ret < 0) - dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", ret); - - if (boe->base.dev) - drm_panel_remove(&boe->base); + return devm_mipi_dsi_attach(&dsi->dev, dsi); } static const struct of_device_id boe_of_match[] = { @@ -1820,7 +1801,6 @@ static struct mipi_dsi_driver boe_panel_driver = { .of_match_table = boe_of_match, }, .probe = boe_panel_probe, - .remove = boe_panel_remove, }; module_mipi_dsi_driver(boe_panel_driver); -- 2.43.0