From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E255455185 for ; Wed, 12 Aug 2026 14:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544824; cv=none; b=Eb2pdRrnogTcCCrOZ5x2YrxJB56tr/R45XEKQIg9YvXqZ8O2xReigommQ96IfYccBy/d/18sOWxfbfWPNuuaM07hfGn//ngGvZcdnSPOE99aO0kD+wFNL51M5ooaDs8OLFGMAnqYocAvnWZvwent0uLVcJRvWyQrx9hW4cYm5TU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786544824; c=relaxed/simple; bh=WlxY3wKIIciSK5xxJfmy8JG1Ui2W6Ke5GnD2nFInhFM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IfRJ73t5eh9uPE0smUgI4g5xXwOzBycwWeN6VRJNnG/9/g2AAxHQxC4iBpxOoI3v+m2BH0oVNx2EGk7eDaCrhfuZ1AQ+AEm2cZP4kRXYrOVGcIYYTu4xZyqQONxurUK6zyNut1KkTEa1Myf4MhWuuEnuTEIMZJhbyEb+rErXb14= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=kgHN6hEi; arc=none smtp.client-ip=209.85.160.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="kgHN6hEi" Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c8e2e39easo11216031cf.0 for ; Wed, 12 Aug 2026 07:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786544821; x=1787149621; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=WlxY3wKIIciSK5xxJfmy8JG1Ui2W6Ke5GnD2nFInhFM=; b=kgHN6hEi+OVMsAnhBh1YzI00xhtcCPzF06j9MhfA9vRGC4i59xCfvtljGURH2Q5PRR w6chLPersmDoxLp9VxCc2fERTxWdPAlUiw+62nL1DVUVtfZ8ZepWhdKcnbF3ckHc+eWx k1FvRCfGul3F6a0SWGhioNMzc8usfFoAuaKNUaoQqYU6cuP8pYBiQHs12hxuuw2K3TU/ I7B6tSsUCwizdI4r6sL8MaHXxp/NXaMXqHxMlrfRvtKmKXcroQsqbimfQvk59+d8KJ/i YaGK+M+fHOSqlM4jAHCfQZb+V9pc5XGJfteqz5HyKVtyLUepvrcg+9kPQFvuAbk1kT8J PBLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786544821; x=1787149621; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WlxY3wKIIciSK5xxJfmy8JG1Ui2W6Ke5GnD2nFInhFM=; b=P9LjLMyqz0XcmISVjgAmxN2U5rGI34U9maXi45WM1GQls92zQ1Q5KZHVQiUefBtkAY p0igEPnpFbEdc/JKZ8JJmSLrYCTogo+qA9Yd0sHzSvnMaWParrXbFiD6lkAlbHcWLclG 2sGlzmZOfpkpoQ1nD1X7kOVxP6+bew5yn0Nd0QndxftJvZ9TtHDLwFZkfM3BwzrMJQAK xh+joQ2xz92WRGp8sti16s4KkWoPbp1zvFyOOzuT7sr21BWNQbhsumM9obH/NcGhMjkp QtkiXiSP7fO9qZFqzI+Sf4U98nXA1yUOfdtinG4ldPfZzPj2QF6TjsYNhbCCynVdttPx bi5g== X-Forwarded-Encrypted: i=1; AHgh+Rpqy5xctzLGyw/OUhqQOx1dMZgimmtkd/0lCaX/5efIBZkPhBXtvZybdtBgxOZlrwo7iN0lhU/R41ujPVw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0rGq0s5FaYLEFqqxQ5nVpoDiECxsZx/qwgd/q1ZwnbfUSvggc j6cGz88Q0Z2Dh+e/uh7O0UN241Rotr5DfmA2zL8YrHH59ZggOsxYkGZ3orIH7GRW9kQ= X-Gm-Gg: AR+sD13YKwQwxTuZLMBwdCTztBxrzeepkMaBXf4dEumCglPT5z0r6SwIX1YI4H1hR8q EiLV6xKTCoc6X44bYETrcLgH+Og4LCxYWr4E4G9CdQgRbS+hwOUxBM7tMuOiOD4VqsUX8EcKkcQ SVNduv6d9XnJSrNAoSoVt9SHnRGXv/onG3zcUtsCZE86Yx3V6r0zPz2oQVz8ltZwUVc3m2e/cyP MspcG6eTnw280/8A4jZxw9eBpqIwoDIkENGKS4CyNLG3Vxey4RLmLryO9qMCdcsvO4dJMdbWSFt XDHxHA835a1U6D7TZ7ZOFDMwzQLeAZr+hmJyTfBuxuTi+vBVHGaZeq3YazqwQ8MSCsbXseodEF5 5B31ikUNUA5X+QyvxwDpPCyajaX0zIaBHuA99hf7Yxc2Vz2SdeIE55w273LYsSdF8IqBWZ1F649 a6f2F694zdE5fE870wB9j9P8iSwKCKIrJr1x+erQujKbA= X-Received: by 2002:a05:622a:1349:b0:527:809c:f9cf with SMTP id d75a77b69052e-52d647ed01dmr43708531cf.21.1786544821147; Wed, 12 Aug 2026 07:27:01 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-52d61c08e92sm19033711cf.1.2026.08.12.07.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 07:27:00 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wu9v1-000000036gU-37I5; Wed, 12 Aug 2026 11:26:59 -0300 Date: Wed, 12 Aug 2026 11:26:59 -0300 From: Jason Gunthorpe To: David Woodhouse Cc: Michal Hocko , Steven Rostedt , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Sebastian Andrzej Siewior , Clark Williams , Simona Vetter , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Christian =?utf-8?B?S8O2bmln?= , "Paul E. McKenney" , Sean Christopherson , Paolo Bonzini , linux-mm@kvack.org, kvm@vger.kernel.org, linux-rt-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/mmu_notifier: Remove non_block_start/end() from notifier invocation Message-ID: <20260812142659.GD662699@ziepe.ca> References: <20260811142730.GG544626@ziepe.ca> <20260811104229.72fdd928@gandalf.local.home> <37b83b429b9f14ea6ad4ca1c13cc8e565ec09033.camel@infradead.org> <44c51ace9b0dc44b795f6f48c91cda440eed910b.camel@infradead.org> <20260812122759.GA662699@ziepe.ca> <20260812134934.GC662699@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Aug 12, 2026 at 03:05:43PM +0100, David Woodhouse wrote: > the non_block_{start,end} guards around the MMU notifiers, which are > basically never being called anyway and don't actually seem to protect > against any real bugs. If you think this blocked stuff is dead code then lets remove it, but I'm pretty sure it is called and I remember seeing bug reports about it being triggered in the wild. Vetter certainly added it because their tests were actually triggering and they had bugs in their DRM stack directly connected to this. It might not trigger for your hypervisor case but we aren't here just to make only kvm work now are we? Jason