From: Martino Dell'Ambrogio <tillo@tillo.ch>
To: Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, linux@armlinux.org.uk, andrew@lunn.ch,
hkallweit1@gmail.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, maxime.chevallier@bootlin.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] net: sfp: allow prefix matching in quirk lookup
Date: Wed, 12 Aug 2026 17:12:25 +0200 [thread overview]
Message-ID: <20260812151225.1146669-1-tillo@tillo.ch> (raw)
In-Reply-To: <20260811001427.1036657-1-kuba@kernel.org>
On Mon, 10 Aug 2026 17:14:27 -0700, Jakub Kicinski wrote:
> [Severity: Low]
> Should the commit message describe what this patch alone does?
>
> At this commit SFP_QUIRK_F_PREFIX has no users: every entry in
> sfp_quirks[] still uses SFP_QUIRK/SFP_QUIRK_S/SFP_QUIRK_F, so
> q->prefix_match is false for all entries and the new branch in
> sfp_match() is not reachable.
Fair point. I'll reword it in v3 so it describes just the mechanism,
and leave the user-visible symptom to the patch that adds the entries.
> [Severity: Medium]
> Was it intended for the prefix relaxation to apply to vendor_name as
> well as vendor_pn?
No, it wasn't. The PN field is the only one I have ever seen garbage
in, and your Hisense-Leox/Hisense example shows the vendor loosening
could bite for real given the first-match table semantics.
v3 scopes the flag to the part field only (part_prefix_match, vendor
comparison always exact). As it turns out the FS entry does not need
prefix matching at all (see my reply on 2/2), so the only remaining
user is the XGSPONST2001 entry, whose "OEM" vendor string then matches
exactly.
Thanks,
Martino
next prev parent reply other threads:[~2026-08-12 15:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 7:43 [PATCH net-next v2 0/2] net: sfp: quirk support for XGS-PON ONT sticks with unclean EEPROMs Martino Dell'Ambrogio
2026-08-06 7:43 ` [PATCH net-next v2 1/2] net: sfp: allow prefix matching in quirk lookup Martino Dell'Ambrogio
2026-08-11 0:14 ` Jakub Kicinski
2026-08-12 15:12 ` Martino Dell'Ambrogio [this message]
2026-08-06 7:43 ` [PATCH net-next v2 2/2] net: sfp: add quirks for OEM XGSPONST2001 and FS XGS-SFP-ONT-MACI Martino Dell'Ambrogio
2026-08-11 0:14 ` Jakub Kicinski
2026-08-12 15:12 ` Martino Dell'Ambrogio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812151225.1146669-1-tillo@tillo.ch \
--to=tillo@tillo.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®