From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AFBCA34E745 for ; Wed, 12 Aug 2026 17:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786555375; cv=none; b=DJ+LE/OSm4A6bzPLekm36dq9RjmZD44KfVe+qMxeGd7alzxMo4ZqdkDVMQ7wjgV0KxSNRnQ3GVW4SlnOczDgjRkl/sCE1l6dsEiGej0sXNzuQhN3DeuN8OKOZDHtUKG5nQRjWhGAjI6gSvWK+7rKimm/Zu3HGpqUs2BcoPLN2uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786555375; c=relaxed/simple; bh=xfBluy7Chl/vLJhCzywHuDMFmQp+P0Rb+La08jMwq8g=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IlR4qLEbF7TbbjYT+q1laY1JWKZUib550gGVs7eEtVe0raRnbDJfTA/n5SfnWgew6hWB/Ms8t9zNXM83MXogmdeKmODB2saem4dKrDtxk8GVLjGWDtw8VmZLiqKPDBdIkpSV0Ssa1fsMA0G4LiyMabtfH7GxaSg6KDQ4eEg0sSE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=DBoqFVja; arc=none smtp.client-ip=209.85.219.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="DBoqFVja" Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-8f0e5e36912so7521646d6.2 for ; Wed, 12 Aug 2026 10:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1786555373; x=1787160173; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=B05U0xMoca4JG8dTYzovZSbd79SZOJKbHErof79XjFA=; b=DBoqFVjaOdCuUcFx8GIXsI+Y5i9KYzwTmBQyZaFaiu9Pk0DLuAAhdyRp0Emp+q4i+E Zdizt+B/4edmTPVtBb+KzGTWp2yi+ByJpL9bX9Hqzl8BJ0ReLkyEs+irW3nTCdlSlGol 9LmEn77930gOy6Usb0dtNGB9dfeyLHkvzhtpNJBAa0LXg2NVhMAY3rVSxGUiKJxJY9gh ldE0zEvYl0nw5AMqvZDG12SjxE7Yg8iDp8sJq/Q+OQigECfnmSTG0Qe9F5bNwNWzzFEl tI8ByG8cz56sLWygZQT0fP0MqOoDB0NzIpOSBHegTajf1NRB739dr0yrnioihaLWlcZZ UCrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786555373; x=1787160173; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=B05U0xMoca4JG8dTYzovZSbd79SZOJKbHErof79XjFA=; b=HLyeW4d6Dp+8PT7TWiQOFkDVWN0cPGZKfDeS0eIld9xfTGi3hdRwnAKxva+9nU/W2Q 1yiJq4BahT5Vm2lV+0CvHKQRhfn1usgKeUogobb/SAu86yInAR9zzMb/OAtHIeaEgRKY 41uvIwgevGUphmA51/RIPggCx7IT4lpS9phSrdoq7B25Tvlxcu2y/FVRE7KNC5BYZ/Up 8SgCuUaLQI4PHej82JvkYVzDzX5eL7Y+xAz6TAsQNkJZi094sCjGp9h+evFqYxW/00CR P3gaoLuMET9H1CPpSYxfH9HLEFJ4QYKbZlV38ul+9E612wmPCeq4iCZvJiB8EucxHTKK oKaw== X-Forwarded-Encrypted: i=1; AHgh+RoXyU3KPWFef1plX0y6UXE7BAyR3aVimp24huXZiik6HP89s5X0ig7ph7DNT3OjFeQg0PAraqOGv4ac7nA=@vger.kernel.org X-Gm-Message-State: AOJu0YzsNaQKvVDjMHQXYHh8BXuD63hxtUU1nDK2dyYNJezJToyNc6Ft IDC63Ub306U/mm4hLB+rzk/BfMiNvX5aMV6pMiPkBgrluncotCAAptLHH2g4Yk5EXV4= X-Gm-Gg: AR+sD12BaIorQTxADVlpzY/MMLipDX6NBI/+NPJN9CsnpZXmk84+aRWXpjIzCIzZMgs ohgPwJ0clz6Q5BsMAX/RosjyA5CQYgNPgKhdeyviJ2Mv9z1jSLWaiTiNZw9lU4Sok+YEvwFbzns 6F41ZM2NvM9/9R6Ll+bUHMzqpL+Gs6v0UHfvOIX/7I7VeCl4BpZXsyKQDKuaU7RcOlFOXs5ncnK oB4ugEAdC23cdOIwOdMrMytf4Vt3IQnRfE6rUVxoJRDO6fnIYt0ZDP/wsTHPYq/Gq1rzsFL2MgI DTVmwgcn1pv9BNAd8VSc0mnVMmnaiLwv+FGsL1XNMbluGxFHIsGPbcRBi/IKvzL11ACX3JOzwFQ TFATL3uWT0gPiR+W392ZXGuhX9xLHPysvLHxJyxdF+Rf015fWOjKwHao4AaM/Fz/jarlcEAW/MK 0TAFYQg0GDcrlK6dbbZ8j2EELDCUp7uENKVc9jcyDTElgdv8vO8LzgubgQm0IPsR2O X-Received: by 2002:a05:620a:1a17:b0:92e:59b0:df08 with SMTP id af79cd13be357-936b3a20e6emr569522885a.3.1786555372598; Wed, 12 Aug 2026 10:22:52 -0700 (PDT) Received: from zippy.localdomain ([73.62.185.64]) by smtp.gmail.com with ESMTPSA id af79cd13be357-936b5f720eesm173587685a.47.2026.08.12.10.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 10:22:52 -0700 (PDT) From: Alex Elder To: bhelgaas@google.com, robh@kernel.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, lorenzo.bianconi@oss.qualcomm.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 0/4] PCI: of: warn on bogus device_type property Date: Wed, 12 Aug 2026 12:22:43 -0500 Message-ID: <20260812172247.276554-1-elder@riscstar.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The purpose of this series lies in its final patch, where a new check is added whenever a PCI devicetree node is found to already exist when one might otherwise be dynamically created. PCI has a well-defined bus and device discovery process. The PCI_DYNAMIC_OF_NODES Kconfig option allows PCI devices to *also* have a devicetree node. This enables certain things that are not possible with PCI enumeration alone. While working on a Qualcomm platform, I learned that some PCI endpoint nodes were defined with device_type = "pci" properties. Herve Codina pointed out that this was not correct. Rob Herring indicated that people seem to have trouble getting the PCI devicetree nodes right, and asked whether we could warn if this particular problem occurred. The last patch in this series implements that check and warning. The first three patches are fairly trivial changes to clean up some related code. This is the only changed patch since v1. -Alex Between version 1 and version 2: - Check the PCI devicetree node even when PCI_DYNAMIC_OF_NODES is not enabled Version 1 is available here: https://lore.kernel.org/lkml/20260807194100.455599-1-elder@riscstar.com/ Alex Elder (4): PCI: of: drop the reg_num argument to of_pci_set_address() PCI: of: don't zero flags in of_pci_get_addr_flags() PCI: of: make a flags argument optional PCI: of: introduce of_pci_verify_node() drivers/pci/bus.c | 1 + drivers/pci/of.c | 26 ++++++++++++++++++++++++++ drivers/pci/of_property.c | 20 ++++++++++---------- drivers/pci/pci.h | 3 +++ 4 files changed, 40 insertions(+), 10 deletions(-) base-commit: db2ddb87143519e20a95aa36c60b36107b736a58 -- 2.53.0