From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D603C32D0F5 for ; Wed, 12 Aug 2026 18:57:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786561071; cv=none; b=oXNPPxUUI3OznzGvi8YiOx+Vbq8p0Rp1Wk04xk2TgkrrQXnUrYE0M7TyDjbVIwCsO1tZG9qasAJbBGVNfY1+bfP/zH3VP4Y22Es5HoVLDAkBsbOh2zA6VxeIx53muT7CuU1Lq/r4kSGD9buLQHw9HZtSCENZa5tMMpzxAZ1b8Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786561071; c=relaxed/simple; bh=zSlSaYUbU1ffsUmFeCx108UKK0wEENYkJjaU17IPQcs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=KpRQN6XN+vy5k8MMREKURATERTPtQT0Zo65RdO8fmupVtSjWVhwP+jk6AHAZE/i6cQ+tRqmPyV3aV5cWthP5exJkEqJ1OXTCglew5o8m1cTabNEpgaCGiWNbfQUkt5OtkPuS1PvATEpyIBRX8lHN+3Q053Bo4B/U3Mvk9xkZzcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bcspvx+Q; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bcspvx+Q" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-8487b7b3fc8so1532554b3a.3 for ; Wed, 12 Aug 2026 11:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786561069; x=1787165869; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=SbuKYxlpXdTIHYEQZH0kyOsSn8MfjOwovOK6ivNRmwQ=; b=bcspvx+QsBXmTjILRxkw7UpWZb6EcrJbqn0zKvVj3eEo4evkU4kFIRqK7+4o2Lrbio ji4oVRiuWf4ozfENqWgGBMOc+c+LI6HUg1TaOAzvP2aLlJj3vdbkPPaAk6LtTQEFOKWl T/2XR3Iib7nZcpHDrrh0xwRMEzZT/0r8FJecL+eaHE5NLn62AnzwT8D8/GogJ+IoLUpB CMTAJmzK/C4h1c7SFynUtl/Wbb9hE1cmztxGK+sw0O7PmaiITtMa+4knfrFWfLhvN3Hw kYCgrBr+EedtugsRkYLir21dH9vjrX6f0eXnBcnMe9vaWYdOnCidLh/3u7Txv/WUp7yD 3I8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786561069; x=1787165869; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=SbuKYxlpXdTIHYEQZH0kyOsSn8MfjOwovOK6ivNRmwQ=; b=HntM0AccAUBldCsHW8fHtCCY1SvFNy9X4RPkBt8Fusx5H+yRJQvjv0jjMbfcAnp/eQ 7oTBhvv9TUJCIRyzA6I0D47oID8TvHyh+y29f+la+IMREkrAW4j07Fgk0XiqEonL1KAM ch3Is6CS+KUWkgIp12EGsNBox+r068TR3jdds+enfUsWOkl84tLaLJhjW6sHwDqFwjYg F9hgIDEN7mgFWH1OO/LmnhRrRnhtsuWm8Xm3HeoTmt4hl1904HZdao7enCAf4wv538Xx cLOokZg2FeML3EA0SaWeoHH5zEPPlcUd4o7brH03uwbH8vKwqPmg8l3TwSajHXVOFd59 UVzQ== X-Forwarded-Encrypted: i=1; AHgh+RomJthzRKWvaMOnIaoTmi2SE4yOhV+6C4MauwmoKCpw0qSdmZ7QgYB2mHDOg4qZ86TOKRJQdaEmA2pAUdY=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4sP1V94W/NTJTrSii9+1n4u1TufNTQpbDXv2iJWdBVHOS3410 BSC3AduOmWrXmEzunJeNzLDgFwfz9vKMNHPI8Q7lOkf+EFfkZOTyUhvBGt5spGqV X-Gm-Gg: AR+sD13uQcJpqwxlfZ4W0h55pmsoTNVI+mCzmRvvhTdCC0ZEP/87oAiVl8Q4j40hGMq oIgEYZJBUbg+Tk4+VETbMUgFhbXsKTI7aaCipptYEYYgFBmo3aKQVagzq4Tx/3UX07ROqEZJNLe nlXrnkOcro8PBPYkqEWRbp3Y4w+YCv2xKY6E8+2s96Ini1Q2iLI/eNzoImUNR7Y92/pIwJeB4u0 sUTkpCF5rQ2HrNyLAJEt8shdPlu+GOi71HMdBjVtjwolO2BoF/mKWxzf3fREITKNIO/KBkpTSAa H7kk9MyxQsXY2loxJwwgkFkvTtKXKBtJJTjJFemubAp8HC6ccA6pO14Xthe2FaKQd+tYJaVUsRM osCqt+vM6RdSA24+WpQYslnW+4N7BgedtlzMQTvVI+8sLvvKsIC6Ex1mXBWJnczu/pg4ObFWuzp tCccZNhrrcXr1lgM4Gczoxr9FPV5DPYiIoLVj1pVwcOicAF8tvQX9X1I/68oeXPXDeMFINaUE51 yC/2OH31X+xzNWpsvQ42gT4t0/jolKTNcT0VDXHHg0PNdg9wlHHDUtsKXTyDQP9QIWyqWYDX3Hl 19Wtp8WULpWb0kY1GHgSIi5ry3a9AyHGGVr8yQ== X-Received: by 2002:a05:6a21:60c4:b0:3bf:b8d8:8296 with SMTP id adf61e73a8af0-3cc55488526mr571271637.26.1786561069171; Wed, 12 Aug 2026 11:57:49 -0700 (PDT) Received: from ryzen.lan ([2601:644:8000:7a86::e35]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbef722b616sm85689a12.28.2026.08.12.11.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2026 11:57:48 -0700 (PDT) From: Rosen Penev To: linux-crypto@vger.kernel.org Cc: Herbert Xu , "David S. Miller" , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] crypto: amcc: trng: use devm_of_iomap() Date: Wed, 12 Aug 2026 11:57:47 -0700 Message-ID: <20260812185747.79173-1-rosenp@gmail.com> X-Mailer: git-send-email 2.55.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert of_iomap() to devm_of_iomap() so that the TRNG register mapping is automatically unmapped on driver detach, eliminating the need for manual iounmap() calls in the error and remove paths. Assisted-by: opencode:big-pickle Signed-off-by: Rosen Penev --- drivers/crypto/amcc/crypto4xx_trng.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/amcc/crypto4xx_trng.c b/drivers/crypto/amcc/crypto4xx_trng.c index cfd66b779ce1..4dd699c41c8a 100644 --- a/drivers/crypto/amcc/crypto4xx_trng.c +++ b/drivers/crypto/amcc/crypto4xx_trng.c @@ -82,9 +82,9 @@ void ppc4xx_trng_probe(struct crypto4xx_core_device *core_dev) return; } - dev->trng_base = of_iomap(trng, 0); + dev->trng_base = devm_of_iomap(core_dev->device, trng, 0, NULL); of_node_put(trng); - if (!dev->trng_base) + if (IS_ERR(dev->trng_base)) goto err_out; rng = kzalloc_obj(*rng); @@ -108,9 +108,7 @@ void ppc4xx_trng_probe(struct crypto4xx_core_device *core_dev) return; err_out: - iounmap(dev->trng_base); kfree(rng); - dev->trng_base = NULL; core_dev->trng = NULL; } @@ -121,7 +119,6 @@ void ppc4xx_trng_remove(struct crypto4xx_core_device *core_dev) devm_hwrng_unregister(core_dev->device, core_dev->trng); ppc4xx_trng_enable(dev, false); - iounmap(dev->trng_base); kfree(core_dev->trng); } } -- 2.55.0